core.git: 2 commits - binaryurp/source canvas/source

[Noel Grandin (via logerrit)]

 binaryurp/source/currentcontext.cxx        |    3 +--
 canvas/source/cairo/cairo_canvashelper.cxx |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 08ed26c3b814896b2728b04cc006165f434e6ede
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Mon Nov 11 11:15:33 2024 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Nov 11 15:47:08 2024 +0100

    clang-tidy: performance-unnecessary-copy-initialization in canvas
    
    Change-Id: I1d08cfe979529614ab2c66702c33a9045b026f23
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176391
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/canvas/source/cairo/cairo_canvashelper.cxx 
b/canvas/source/cairo/cairo_canvashelper.cxx
index 75c69a5847ab..701ad1e47859 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -421,7 +421,7 @@ constexpr OUStringLiteral 
PARAMETRICPOLYPOLYGON_IMPLEMENTATION_NAME = u"Canvas::
     static cairo_pattern_t* patternFromParametricPolyPolygon( 
::canvas::ParametricPolyPolygon const & rPolygon )
     {
         cairo_pattern_t* pPattern = nullptr;
-        const ::canvas::ParametricPolyPolygon::Values aValues = 
rPolygon.getValues();
+        const ::canvas::ParametricPolyPolygon::Values& aValues = 
rPolygon.getValues();
         double x0, x1, y0, y1, cx, cy, r0, r1;
 
         switch( aValues.meType )
commit aa48441b0bde7df62e338e1f466652fa560804c7
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Mon Nov 11 11:15:03 2024 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Nov 11 15:47:00 2024 +0100

    clang-tidy: performance-unnecessary-copy-initialization in binaryurp
    
    Change-Id: I8af73afaf063294786890a71abe97add283289a5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176390
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
    Tested-by: Jenkins

diff --git a/binaryurp/source/currentcontext.cxx 
b/binaryurp/source/currentcontext.cxx
index 530525907686..aadefdd51a44 100644
--- a/binaryurp/source/currentcontext.cxx
+++ b/binaryurp/source/currentcontext.cxx
@@ -41,9 +41,8 @@ css::uno::UnoInterfaceReference get() {
 }
 
 void set(css::uno::UnoInterfaceReference const & value) {
-    css::uno::UnoInterfaceReference cc(value);
     if (!uno_setCurrentContext(
-            cc.m_pUnoI,
+            value.m_pUnoI,
             u"" UNO_LB_UNO ""_ustr.pData, nullptr))
     {
         throw css::uno::RuntimeException(u"uno_setCurrentContext failed"_ustr);