sax/source/tools/converter.cxx | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit 957fea5f3d554c870903687d56e49d4777b69ef8
Author: Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Fri Nov 1 20:52:30 2024 +0100
Commit: Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Tue Nov 5 20:30:40 2024 +0100
tdf#163486: PVS: variable is assigned but not used
Since
commit 2e25618fe7370e9f378da0b03bca8fac471f01f3
Author: Mike Kaganski <mike.kagan...@collabora.com>
Date: Mon Jul 8 12:12:49 2024 +0500
Make convert*Angle strict
V1001 The 'fAngle' variable is assigned but is not used by the end of the
function.
V1001 The 'fAngle' variable is assigned but is not used by the end of the
function.
Change-Id: Ie0c9059e18518cae46854715fa7d39cc9c942549
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175933
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index f5218a47d46e..0c1613a32a89 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -904,8 +904,7 @@ bool Converter::convert10thDegAngle(sal_Int16& rAngle,
std::u16string_view rStri
{ // isWrongOOo10thDegAngle = true: nothing to do here. Wrong, but
backward compatible.
if (!aRest.empty())
{
- // Wrong unit
- fAngle = 0;
+ // Wrong unit. Don't change rAngle, rely on callers checking
boolean return
return false;
}
if (!isWrongOOo10thDegAngle)
@@ -942,8 +941,7 @@ bool Converter::convert10thDegAngle(sal_Int16& rAngle,
std::string_view rString,
{ // isWrongOOo10thDegAngle = true: nothing to do here. Wrong, but
backward compatible.
if (!aRest.empty())
{
- // Wrong unit
- fAngle = 0;
+ // Wrong unit. Don't change rAngle, rely on callers checking
boolean return
return false;
}
if (!isWrongOOo10thDegAngle)
