core.git: starmath/source

[Bogdan Buzea (via logerrit)]

 starmath/source/mathml/mathmlimport.cxx |   16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

New commits:
commit e877bd2a25b391244abff329a83d8a2b0c656493
Author:     Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Mon Oct 21 12:02:02 2024 +0200
Commit:     David Gilbert <freedesk...@treblig.org>
CommitDate: Mon Nov 4 22:46:50 2024 +0100

    tdf#163486: PVS: Identical branches
    
    V1037 Two or more case-branches perform the same actions. Check lines: 574, 
577
    V1037 Two or more case-branches perform the same actions. Check lines: 738, 
752, 759
    V1037 Two or more case-branches perform the same actions. Check lines: 
1949, 1953
    
    Change-Id: I2a6b6cc16ff58d432e5a7b14a6a1d7fa4f1a15b4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175313
    Tested-by: Jenkins
    Reviewed-by: David Gilbert <freedesk...@treblig.org>

diff --git a/starmath/source/mathml/mathmlimport.cxx 
b/starmath/source/mathml/mathmlimport.cxx
index 4a0ac6a438e2..91bc834a27b0 100644
--- a/starmath/source/mathml/mathmlimport.cxx
+++ b/starmath/source/mathml/mathmlimport.cxx
@@ -571,8 +571,6 @@ void SmXMLContext_Helper::RetrieveAttrs(
                 sFontFamily = aIter.toString();
                 break;
             case XML_COLOR:
-                sColor = aIter.toString();
-                break;
             case XML_MATHCOLOR:
                 sColor = aIter.toString();
                 break;
@@ -735,6 +733,10 @@ void 
SmXMLTokenAttrHelper::ApplyAttrs(MathMLMathvariantValue eDefaultMv)
             vVariant.push_back(TNITALIC);
             break;
         case MathMLMathvariantValue::Bold:
+        case MathMLMathvariantValue::BoldFraktur:
+            // TODO: Fraktur
+        case MathMLMathvariantValue::BoldScript:
+            // TODO: Script
             vVariant.push_back(TBOLD);
             break;
         case MathMLMathvariantValue::Italic:
@@ -747,17 +749,9 @@ void 
SmXMLTokenAttrHelper::ApplyAttrs(MathMLMathvariantValue eDefaultMv)
         case MathMLMathvariantValue::DoubleStruck:
             // TODO
             break;
-        case MathMLMathvariantValue::BoldFraktur:
-            // TODO: Fraktur
-            vVariant.push_back(TBOLD);
-            break;
         case MathMLMathvariantValue::Script:
             // TODO
             break;
-        case MathMLMathvariantValue::BoldScript:
-            // TODO: Script
-            vVariant.push_back(TBOLD);
-            break;
         case MathMLMathvariantValue::Fraktur:
             // TODO
             break;
@@ -1946,8 +1940,6 @@ uno::Reference<xml::sax::XFastContextHandler> 
SmXMLDocContext_Impl::createFastCh
     {
         //Consider semantics a dummy except for any starmath annotations
         case XML_ELEMENT(MATH, XML_SEMANTICS):
-            xContext = new SmXMLRowContext_Impl(GetSmImport());
-            break;
         /*General Layout Schemata*/
         case XML_ELEMENT(MATH, XML_MROW):
             xContext = new SmXMLRowContext_Impl(GetSmImport());