filter/source/pdf/impdialog.cxx | 2 +-
filter/uiconfig/ui/pdfgeneralpage.ui | 12 ++++++------
sc/qa/uitest/calc_tests4/exportToPDF.py | 2 +-
sd/qa/uitest/impress_tests/exportToPDF.py | 2 +-
svx/source/dialog/compressgraphicdialog.cxx | 2 +-
svx/uiconfig/ui/compressgraphicdialog.ui | 4 ++--
sw/qa/uitest/writer_tests4/exportToPDF.py | 2 +-
7 files changed, 13 insertions(+), 13 deletions(-)
New commits:
commit 412a775d0ab90cd963216c40e9ae1189179809ba
Author: Aditya Sahu <adityasahu1...@gmail.com>
AuthorDate: Fri Nov 1 11:32:53 2024 -0400
Commit: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
CommitDate: Sat Nov 2 09:58:41 2024 +0100
tdf#145161: Change pdf and image compression dialog string
Since image/pdf compression does not always reduce image
or pdf resolution, change the misleading label from
"reduce" to "change" wherever possible.
Keep identifiers having "reduce" in their name as is
as of now, only change the string values containing
"reduce" to "change".
Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 547f9526338e..3d86c3acabb4 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -550,7 +550,7 @@ ImpPDFTabGeneralPage::ImpPDFTabGeneralPage(weld::Container*
pPage, weld::DialogC
, mxRbJPEGCompression(m_xBuilder->weld_radio_button(u"jpegcompress"_ustr))
, mxQualityFrame(m_xBuilder->weld_widget(u"qualityframe"_ustr))
, mxNfQuality(m_xBuilder->weld_metric_spin_button(u"quality"_ustr,
FieldUnit::PERCENT))
- ,
mxCbReduceImageResolution(m_xBuilder->weld_check_button(u"reduceresolution"_ustr))
+ ,
mxCbReduceImageResolution(m_xBuilder->weld_check_button(u"changeresolution"_ustr))
, mxCoReduceImageResolution(m_xBuilder->weld_combo_box(u"resolution"_ustr))
, mxCbPDFA(m_xBuilder->weld_check_button(u"pdfa"_ustr))
, mxCbPDFUA(m_xBuilder->weld_check_button(u"pdfua"_ustr))
diff --git a/filter/uiconfig/ui/pdfgeneralpage.ui
b/filter/uiconfig/ui/pdfgeneralpage.ui
index f09113793d07..ef6d9767b06b 100644
--- a/filter/uiconfig/ui/pdfgeneralpage.ui
+++ b/filter/uiconfig/ui/pdfgeneralpage.ui
@@ -275,8 +275,8 @@
</packing>
</child>
<child>
- <object class="GtkCheckButton" id="reduceresolution">
- <property name="label" translatable="yes"
context="pdfgeneralpage|reduceresolution">Reduce ima_ge resolution
to:</property>
+ <object class="GtkCheckButton" id="changeresolution">
+ <property name="label" translatable="yes"
context="pdfgeneralpage|changeresolution">Change ima_ge resolution
to:</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="receives-default">False</property>
@@ -287,8 +287,8 @@
<relation type="label-for" target="resolution"/>
</accessibility>
<child internal-child="accessible">
- <object class="AtkObject"
id="reduceresolution-atkobject">
- <property name="AtkObject::accessible-description"
translatable="yes"
context="pdfgeneralpage|extended_tip|reduceresolution">Select to resample or
down-size the images to a lower number of pixels per inch.</property>
+ <object class="AtkObject"
id="changeresolution-atkobject">
+ <property name="AtkObject::accessible-description"
translatable="yes"
context="pdfgeneralpage|extended_tip|changeresolution">Select to resample or
down-size the images to a lower number of pixels per inch.</property>
</object>
</child>
</object>
@@ -318,7 +318,7 @@
</object>
</child>
<accessibility>
- <relation type="labelled-by" target="reduceresolution"/>
+ <relation type="labelled-by" target="changeresolution"/>
</accessibility>
<child internal-child="accessible">
<object class="AtkObject" id="resolution-atkobject">
@@ -1091,7 +1091,7 @@
<widget name="selection"/>
<widget name="losslesscompress"/>
<widget name="box3"/>
- <widget name="reduceresolution"/>
+ <widget name="changeresolution"/>
<widget name="watermark"/>
</widgets>
</object>
diff --git a/sc/qa/uitest/calc_tests4/exportToPDF.py
b/sc/qa/uitest/calc_tests4/exportToPDF.py
index a2cd0e55a451..35e96a044df6 100644
--- a/sc/qa/uitest/calc_tests4/exportToPDF.py
+++ b/sc/qa/uitest/calc_tests4/exportToPDF.py
@@ -35,7 +35,7 @@ class exportToPDF(UITestCase):
with
self.ui_test.execute_dialog_through_command('.uno:ExportToPDF',
close_button="") as xDialog:
selectedChildren = ['bookmarks', 'display', 'effects',
'enablea11y',
- 'enablecopy', 'exporturl',
'reduceresolution', 'tagged']
+ 'enablecopy', 'exporturl',
'changeresolution', 'tagged']
for child in selectedChildren:
self.assertEqual("true",
get_state_as_dict(xDialog.getChild(child))['Selected'])
diff --git a/sd/qa/uitest/impress_tests/exportToPDF.py
b/sd/qa/uitest/impress_tests/exportToPDF.py
index 6cf6a63e1da0..b9cdc9934faf 100644
--- a/sd/qa/uitest/impress_tests/exportToPDF.py
+++ b/sd/qa/uitest/impress_tests/exportToPDF.py
@@ -37,7 +37,7 @@ class exportToPDF(UITestCase):
with
self.ui_test.execute_dialog_through_command('.uno:ExportToPDF',
close_button="") as xDialog:
selectedChildren = ['bookmarks', 'display', 'effects',
'enablea11y',
- 'enablecopy', 'exporturl',
'reduceresolution', 'tagged']
+ 'enablecopy', 'exporturl',
'changeresolution', 'tagged']
for child in selectedChildren:
self.assertEqual("true",
get_state_as_dict(xDialog.getChild(child))['Selected'])
diff --git a/svx/source/dialog/compressgraphicdialog.cxx
b/svx/source/dialog/compressgraphicdialog.cxx
index 7fd293dae9d6..90f3b21892c5 100644
--- a/svx/source/dialog/compressgraphicdialog.cxx
+++ b/svx/source/dialog/compressgraphicdialog.cxx
@@ -125,7 +125,7 @@ void CompressGraphicsDialog::Initialize()
m_xLosslessRB = m_xBuilder->weld_radio_button(u"radio-lossless"_ustr);
m_xQualityMF = m_xBuilder->weld_spin_button(u"spin-quality"_ustr);
m_xQualitySlider = m_xBuilder->weld_scale(u"scale-quality"_ustr);
- m_xReduceResolutionCB =
m_xBuilder->weld_check_button(u"checkbox-reduce-resolution"_ustr);
+ m_xReduceResolutionCB =
m_xBuilder->weld_check_button(u"checkbox-change-resolution"_ustr);
m_xMFNewWidth = m_xBuilder->weld_spin_button(u"spin-new-width"_ustr);
m_xMFNewHeight = m_xBuilder->weld_spin_button(u"spin-new-height"_ustr);
m_xResolutionLB = m_xBuilder->weld_combo_box(u"combo-resolution"_ustr);
diff --git a/svx/uiconfig/ui/compressgraphicdialog.ui
b/svx/uiconfig/ui/compressgraphicdialog.ui
index 69c92ba4ebc7..511b3355041f 100644
--- a/svx/uiconfig/ui/compressgraphicdialog.ui
+++ b/svx/uiconfig/ui/compressgraphicdialog.ui
@@ -313,8 +313,8 @@
<property name="margin-start">12</property>
<property name="margin-top">6</property>
<child>
- <object class="GtkCheckButton"
id="checkbox-reduce-resolution">
- <property name="label" translatable="yes"
context="compressgraphicdialog|checkbox-reduce-resolution">Change image
resolution to:</property>
+ <object class="GtkCheckButton"
id="checkbox-change-resolution">
+ <property name="label" translatable="yes"
context="compressgraphicdialog|checkbox-change-resolution">Change image
resolution to:</property>
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">False</property>
diff --git a/sw/qa/uitest/writer_tests4/exportToPDF.py
b/sw/qa/uitest/writer_tests4/exportToPDF.py
index e2ca9d72bd34..76e2e0420700 100644
--- a/sw/qa/uitest/writer_tests4/exportToPDF.py
+++ b/sw/qa/uitest/writer_tests4/exportToPDF.py
@@ -33,7 +33,7 @@ class exportToPDF(UITestCase):
with
self.ui_test.execute_dialog_through_command('.uno:ExportToPDF',
close_button="") as xDialog:
selectedChildren = ['bookmarks', 'display', 'effects',
'enablea11y',
- 'enablecopy', 'exporturl',
'reduceresolution', 'tagged']
+ 'enablecopy', 'exporturl',
'changeresolution', 'tagged']
for child in selectedChildren:
self.assertEqual("true",
get_state_as_dict(xDialog.getChild(child))['Selected'])
