core.git: Branch 'distro/collabora/co-24.04' - vcl/source

[Xisco Fauli (via logerrit)]

 vcl/source/app/svdata.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a2eb59fafd94c9fb647950cd248caf5ad9dfa39f
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Thu Oct 31 17:07:56 2024 +0100
Commit:     Michael Meeks <michael.me...@collabora.com>
CommitDate: Thu Oct 31 17:38:41 2024 +0100

    tdf#163486: PVS: Initial and final values of the iterator are the same
    
    Since
    commit 4a4602ad7513262a6c0423f17b42791a852b7e23
    Author: Michael Meeks <michael.me...@collabora.com>
    Date:   Fri Mar 10 10:36:22 2023 +0000
    
        lok: add trimMemory capability, and expand dumpState to caches
    
    V625    Consider inspecting the 'for' operator. Initial and final values of 
the iterator are the same.
    
    Change-Id: I9ddd2593ace4234f720a6561b0dcbd85dbc18ef2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175859
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
    Reviewed-by: Michael Meeks <michael.me...@collabora.com>

diff --git a/vcl/source/app/svdata.cxx b/vcl/source/app/svdata.cxx
index e919bfda7c3d..5f1ac99f5fe1 100644
--- a/vcl/source/app/svdata.cxx
+++ b/vcl/source/app/svdata.cxx
@@ -436,7 +436,7 @@ void ImplSVData::dumpState(rtl::OStringBuffer &rState)
     rState.append("     items:");
 
     for (auto it = maGDIData.maScaleCache.begin();
-         it != maGDIData.maScaleCache.begin(); ++it)
+         it != maGDIData.maScaleCache.end(); ++it)
     {
         rState.append("
        ");
         rState.append(static_cast<sal_Int32>(it->first.maDestSize.Width()));