core.git: libreofficekit/qa

[Caolán McNamara (via logerrit)]

 libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit f69980d036b3f388982d7b1b2907cc165ee04b52
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Wed Oct 30 09:15:37 2024 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Wed Oct 30 14:47:26 2024 +0100

    Don't call std::string::erase with end()
    
    Change-Id: I64afcbe7138de7c7655a8107fd25e3ac8393a55d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175824
    Tested-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx
index 0f80a365ab0f..c998eeeccb2b 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx
@@ -219,7 +219,9 @@ void recentUnoChanged( GtkWidget* pSelector, gpointer /* 
pItem */ )
 static void addToRecentUnoCommands(GtvApplicationWindow* pWindow, const 
std::string& rUnoCmd, std::string aArgs)
 {
     GtvMainToolbar* pToolbar = 
gtv_application_window_get_main_toolbar(pWindow);
-    aArgs.erase(std::find(aArgs.begin(), aArgs.end(), '
'));
+    auto it = std::find(aArgs.begin(), aArgs.end(), '
');
+    if (it != aArgs.end())
+        aArgs.erase(it);
     const std::string rUnoCmdStr = rUnoCmd + " | " + aArgs;