sw/qa/extras/tiledrendering/tiledrendering.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 7b91fc00a01e973937861a212750b12ffaaf9501
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Tue Oct 29 09:28:17 2024 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Tue Oct 29 10:50:46 2024 +0100
workaround loplugin:cppunitassertequals
There is no operator<< for SfxPoolItem, so a straightforward convert to
CPPUNIT_ASSERT_EQUAL is not possible.
/home/noel/libo/sw/qa/extras/tiledrendering/tiledrendering.cxx:2725:5:
error: rather call CPPUNIT_ASSERT_EQUAL when comparing 'const
SfxPoolItem' and 'SvxWeightItem' (or rewrite as an explicit operator ==
call when the operator itself is the topic)
[loplugin:cppunitassertequals]
2725 | CPPUNIT_ASSERT(*pPoolItem == aBoldWeightItem); // a bold
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Change-Id: Ia92779d54d252245e1d3b8e32c574e4226342f36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175771
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de>
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 5fb832b66b29..ccff88a6809d 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -2722,7 +2722,7 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest,
testIMEFormattingAtEndOfParagraph)
aSet.ClearItem();
pShellCursor->GetPoint()->GetNode().GetTextNode()->GetParaAttr(aSet, 1, 2);
pPoolItem = aSet.GetItem(RES_CHRATR_WEIGHT);
- CPPUNIT_ASSERT(*pPoolItem == aBoldWeightItem); // a bold
+ CPPUNIT_ASSERT(pPoolItem->operator==(aBoldWeightItem)); // a bold
aSet.ClearItem();
pShellCursor->GetPoint()->GetNode().GetTextNode()->GetParaAttr(aSet, 2, 3);
pPoolItem = aSet.GetItem(RES_CHRATR_WEIGHT);
