accessibility/source/extended/AccessibleBrowseBox.cxx | 2
basctl/source/accessibility/accessibledialogwindow.cxx | 7 --
chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx | 2
chart2/source/tools/StatisticsHelper.cxx | 2
connectivity/source/parse/sqliterator.cxx | 2
dbaccess/source/core/dataaccess/ModelImpl.cxx | 2
dbaccess/source/core/misc/apitools.cxx | 2
desktop/source/deployment/misc/dp_dependencies.cxx | 2
embeddedobj/source/commonembedding/persistence.cxx | 2
embeddedobj/source/msole/ownview.cxx | 2
extensions/source/propctrlr/formcomponenthandler.cxx | 2
extensions/source/propctrlr/genericpropertyhandler.cxx | 2
extensions/source/propctrlr/propertyhandler.cxx | 2
extensions/source/update/check/updatehdl.cxx | 2
filter/source/pdf/pdfexport.cxx | 2
framework/source/helper/statusindicatorfactory.cxx | 4 -
framework/source/helper/tagwindowasmodified.cxx | 2
framework/source/services/frame.cxx | 2
framework/source/uiconfiguration/imagemanagerimpl.cxx | 4 -
framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx | 4 -
framework/source/uiconfiguration/uiconfigurationmanager.cxx | 2
linguistic/source/convdic.cxx | 2
oox/source/drawingml/chart/seriesconverter.cxx | 4 -
oox/source/drawingml/graphicshapecontext.cxx | 2
oox/source/drawingml/misccontexts.cxx | 2
package/source/xstor/xstorage.cxx | 2
pyuno/source/module/pyuno_struct.cxx | 2
reportdesign/source/core/api/Functions.cxx | 2
reportdesign/source/core/api/Groups.cxx | 2
sc/source/filter/excel/xechart.cxx | 2
sc/source/ui/inc/tabvwsh.hxx | 3 -
sc/source/ui/vba/vbaapplication.cxx | 2
sc/source/ui/view/tabvwsha.cxx | 29
+++++-----
scripting/source/provider/ProviderCache.cxx | 6 +-
sd/source/console/PresenterAccessibility.cxx | 2
sd/source/core/CustomAnimationCloner.cxx | 2
sd/source/filter/eppt/pptexanimations.cxx | 2
sd/source/filter/grf/sdgrffilter.cxx | 2
sd/source/ui/unoidl/unosrch.cxx | 2
sdext/source/minimizer/pagecollector.cxx | 2
sfx2/source/doc/docfile.cxx | 2
sfx2/source/doc/sfxbasemodel.cxx | 2
slideshow/source/engine/slide/targetpropertiescreator.cxx | 2
stoc/source/security/access_controller.cxx | 2
stoc/source/servicemanager/servicemanager.cxx | 2
svl/source/misc/documentlockfile.cxx | 2
svx/source/form/datanavi.cxx | 6 +-
svx/source/items/galleryitem.cxx | 4 -
sw/source/filter/html/htmlforw.cxx | 4 -
sw/source/uibase/utlui/content.cxx | 2
sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx | 4 -
sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx | 6 --
toolkit/source/controls/dialogcontrol.cxx | 2
ucb/source/ucp/hierarchy/hierarchycontent.cxx | 2
ucb/source/ucp/hierarchy/hierarchydata.cxx | 2
unotools/source/config/fontcfg.cxx | 2
vcl/source/treelist/transfer.cxx | 2
xmloff/source/chart/SchXMLPlotAreaContext.cxx | 2
xmloff/source/draw/sdxmlexp.cxx | 4 -
59 files changed, 87 insertions(+), 92 deletions(-)
New commits:
commit 7bbe74b2be45afff4418b29deca6448795d86715
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Oct 27 13:19:14 2024 +0000
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Oct 27 20:19:12 2024 +0100
cid#1555789 COPY_INSTEAD_OF_MOVE
and
cid#1556865 COPY_INSTEAD_OF_MOVE
cid#1556871 COPY_INSTEAD_OF_MOVE
cid#1556939 COPY_INSTEAD_OF_MOVE
cid#1556951 COPY_INSTEAD_OF_MOVE
cid#1556964 COPY_INSTEAD_OF_MOVE
cid#1556966 COPY_INSTEAD_OF_MOVE
cid#1556968 COPY_INSTEAD_OF_MOVE
cid#1556971 COPY_INSTEAD_OF_MOVE
cid#1556989 COPY_INSTEAD_OF_MOVE
cid#1557001 COPY_INSTEAD_OF_MOVE
cid#1557011 COPY_INSTEAD_OF_MOVE
cid#1557032 COPY_INSTEAD_OF_MOVE
cid#1557038 COPY_INSTEAD_OF_MOVE
cid#1557041 COPY_INSTEAD_OF_MOVE
cid#1557055 COPY_INSTEAD_OF_MOVE
cid#1557056 COPY_INSTEAD_OF_MOVE
cid#1557057 COPY_INSTEAD_OF_MOVE
cid#1557065 COPY_INSTEAD_OF_MOVE
cid#1557068 COPY_INSTEAD_OF_MOVE
cid#1557087 COPY_INSTEAD_OF_MOVE
cid#1557090 COPY_INSTEAD_OF_MOVE
cid#1557093 COPY_INSTEAD_OF_MOVE
cid#1557113 COPY_INSTEAD_OF_MOVE
cid#1557122 COPY_INSTEAD_OF_MOVE
cid#1557126 COPY_INSTEAD_OF_MOVE
cid#1557145 COPY_INSTEAD_OF_MOVE
cid#1557151 COPY_INSTEAD_OF_MOVE
cid#1557152 COPY_INSTEAD_OF_MOVE
cid#1557197 COPY_INSTEAD_OF_MOVE
cid#1557216 COPY_INSTEAD_OF_MOVE
cid#1557245 COPY_INSTEAD_OF_MOVE
cid#1557272 COPY_INSTEAD_OF_MOVE
cid#1557310 COPY_INSTEAD_OF_MOVE
cid#1557314 COPY_INSTEAD_OF_MOVE
cid#1557318 COPY_INSTEAD_OF_MOVE
cid#1557333 COPY_INSTEAD_OF_MOVE
cid#1557340 COPY_INSTEAD_OF_MOVE
cid#1557358 COPY_INSTEAD_OF_MOVE
cid#1557359 COPY_INSTEAD_OF_MOVE
cid#1557365 COPY_INSTEAD_OF_MOVE
cid#1557367 COPY_INSTEAD_OF_MOVE
cid#1557395 COPY_INSTEAD_OF_MOVE
cid#1557418 COPY_INSTEAD_OF_MOVE
cid#1557488 COPY_INSTEAD_OF_MOVE
cid#1557493 COPY_INSTEAD_OF_MOVE
cid#1557506 COPY_INSTEAD_OF_MOVE
cid#1557514 COPY_INSTEAD_OF_MOVE
cid#1557528 COPY_INSTEAD_OF_MOVE
cid#1557534 COPY_INSTEAD_OF_MOVE
cid#1557537 COPY_INSTEAD_OF_MOVE
cid#1557562 COPY_INSTEAD_OF_MOVE
cid#1557563 COPY_INSTEAD_OF_MOVE
cid#1557592 COPY_INSTEAD_OF_MOVE
cid#1557608 COPY_INSTEAD_OF_MOVE
cid#1557615 COPY_INSTEAD_OF_MOVE
cid#1557619 COPY_INSTEAD_OF_MOVE
cid#1557637 COPY_INSTEAD_OF_MOVE
cid#1557648 COPY_INSTEAD_OF_MOVE
cid#1557712 COPY_INSTEAD_OF_MOVE
cid#1557750 COPY_INSTEAD_OF_MOVE
cid#1557762 COPY_INSTEAD_OF_MOVE
cid#1557765 COPY_INSTEAD_OF_MOVE
Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
Tested-by: Jenkins
diff --git a/accessibility/source/extended/AccessibleBrowseBox.cxx
b/accessibility/source/extended/AccessibleBrowseBox.cxx
index debdf15e2443..250040030a5f 100644
--- a/accessibility/source/extended/AccessibleBrowseBox.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBox.cxx
@@ -151,7 +151,7 @@ AccessibleBrowseBox::getAccessibleAtPoint( const
awt::Point& rPoint )
if (xCurrChildComp.is()
&&
VCLUnoHelper::ConvertToVCLRect(xCurrChildComp->getBounds()).Contains(aPoint))
- xChild = xCurrChild;
+ xChild = std::move(xCurrChild);
}
}
return xChild;
diff --git a/basctl/source/accessibility/accessibledialogwindow.cxx
b/basctl/source/accessibility/accessibledialogwindow.cxx
index b7740a6484b5..39b19e8a4462 100644
--- a/basctl/source/accessibility/accessibledialogwindow.cxx
+++ b/basctl/source/accessibility/accessibledialogwindow.cxx
@@ -671,10 +671,7 @@ Locale AccessibleDialogWindow::getLocale( )
return Application::GetSettings().GetLanguageTag().getLocale();
}
-
// XAccessibleComponent
-
-
Reference< XAccessible > AccessibleDialogWindow::getAccessibleAtPoint( const
awt::Point& rPoint )
{
OExternalLockGuard aGuard( this );
@@ -692,7 +689,7 @@ Reference< XAccessible >
AccessibleDialogWindow::getAccessibleAtPoint( const awt
Point aPos = VCLUnoHelper::ConvertToVCLPoint(rPoint);
if ( aRect.Contains( aPos ) )
{
- xChild = xAcc;
+ xChild = std::move(xAcc);
break;
}
}
@@ -702,7 +699,6 @@ Reference< XAccessible >
AccessibleDialogWindow::getAccessibleAtPoint( const awt
return xChild;
}
-
void AccessibleDialogWindow::grabFocus( )
{
OExternalLockGuard aGuard( this );
@@ -711,7 +707,6 @@ void AccessibleDialogWindow::grabFocus( )
m_pDialogWindow->GrabFocus();
}
-
sal_Int32 AccessibleDialogWindow::getForeground( )
{
OExternalLockGuard aGuard( this );
diff --git a/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx
b/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx
index cd70c5a22368..182e50050f6f 100644
--- a/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx
@@ -483,7 +483,7 @@ bool TextLabelItemConverter::ApplySpecialItem( sal_uInt16
nWhichId, const SfxIte
GetPropertySet()->getPropertyValue(u"Symbol"_ustr) >>=
aSymbol;
if (aSymbol.Graphic != xGraphic)
{
- aSymbol.Graphic = xGraphic;
+ aSymbol.Graphic = std::move(xGraphic);
GetPropertySet()->setPropertyValue(u"Symbol"_ustr,
uno::Any(aSymbol));
bChanged = true;
}
diff --git a/chart2/source/tools/StatisticsHelper.cxx
b/chart2/source/tools/StatisticsHelper.cxx
index b29e54b80122..260c40eef2ca 100644
--- a/chart2/source/tools/StatisticsHelper.cxx
+++ b/chart2/source/tools/StatisticsHelper.cxx
@@ -133,7 +133,7 @@ void lcl_addSequenceToDataSource(
xDataSource->getDataSequences());
aSequences.realloc( aSequences.getLength() + 1 );
auto pSequences = aSequences.getArray();
- pSequences[ aSequences.getLength() - 1 ] = xLSeq;
+ pSequences[ aSequences.getLength() - 1 ] = std::move(xLSeq);
xSink->setData( aSequences );
}
diff --git a/connectivity/source/parse/sqliterator.cxx
b/connectivity/source/parse/sqliterator.cxx
index 626d9cab112b..e0ea16b36ae0 100644
--- a/connectivity/source/parse/sqliterator.cxx
+++ b/connectivity/source/parse/sqliterator.cxx
@@ -455,7 +455,7 @@ void OSQLParseTreeIterator::traverseOneTableName(
OSQLTables& _rTables,const OSQ
// get the object representing this table/query
OSQLTable aTable = impl_locateRecordSource( aComposedName );
if ( aTable.is() )
- _rTables[ aTableRange ] = aTable;
+ _rTables[ aTableRange ] = std::move(aTable);
}
void OSQLParseTreeIterator::impl_fillJoinConditions(const OSQLParseNode*
i_pJoinCondition)
diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx
b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 49503a9d7b56..9970f97ddf83 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -1398,7 +1398,7 @@ bool ODatabaseModelImpl::hasTrustedScriptingSignature(
{
task::DocumentMacroConfirmationRequest aRequest;
aRequest.DocumentURL = m_sDocFileLocation;
- aRequest.DocumentStorage = xStorage;
+ aRequest.DocumentStorage = std::move(xStorage);
aRequest.DocumentSignatureInformation = aInfo;
aRequest.DocumentVersion = aODFVersion;
aRequest.Classification = task::InteractionClassification_QUERY;
diff --git a/dbaccess/source/core/misc/apitools.cxx
b/dbaccess/source/core/misc/apitools.cxx
index 384d5962bd2d..2693f59eebb9 100644
--- a/dbaccess/source/core/misc/apitools.cxx
+++ b/dbaccess/source/core/misc/apitools.cxx
@@ -74,7 +74,7 @@ void OSubComponent::release() noexcept
if (xParent.is())
{
MutexGuard aGuard( rBHelper.rMutex );
- m_xParent = xParent;
+ m_xParent = std::move(xParent);
}
// destroy the object if xHoldAlive decrement the refcount to 0
diff --git a/desktop/source/deployment/misc/dp_dependencies.cxx
b/desktop/source/deployment/misc/dp_dependencies.cxx
index b9044f256977..d06dabd47788 100644
--- a/desktop/source/deployment/misc/dp_dependencies.cxx
+++ b/desktop/source/deployment/misc/dp_dependencies.cxx
@@ -148,7 +148,7 @@ check(dp_misc::DescriptionInfoset const & infoset) {
minimalVersionOpenOfficeOrg));
}
if (!sat) {
- unsatisfiedRange[unsat++] = e;
+ unsatisfiedRange[unsat++] = std::move(e);
}
}
unsatisfied.realloc(unsat);
diff --git a/embeddedobj/source/commonembedding/persistence.cxx
b/embeddedobj/source/commonembedding/persistence.cxx
index c72d788e3d04..15ad2ea51e89 100644
--- a/embeddedobj/source/commonembedding/persistence.cxx
+++ b/embeddedobj/source/commonembedding/persistence.cxx
@@ -1431,7 +1431,7 @@ void SAL_CALL OCommonEmbeddedObject::storeAsEntry( const
uno::Reference< embed::
}
m_bWaitSaveCompleted = true;
- m_xNewObjectStorage = xSubStorage;
+ m_xNewObjectStorage = std::move(xSubStorage);
m_xNewParentStorage = xStorage;
m_aNewEntryName = sEntName;
m_aNewDocMediaDescriptor = GetValuableArgs_Impl( lArguments, true );
diff --git a/embeddedobj/source/msole/ownview.cxx
b/embeddedobj/source/msole/ownview.cxx
index d462f41a23d7..b9443998e4aa 100644
--- a/embeddedobj/source/msole/ownview.cxx
+++ b/embeddedobj/source/msole/ownview.cxx
@@ -142,7 +142,7 @@ bool OwnView_Impl::CreateModelFromURL( const OUString&
aFileURL )
xCloseable->addCloseListener( uno::Reference<
util::XCloseListener >(this) );
::osl::MutexGuard aGuard( m_aMutex );
- m_xModel = xModel;
+ m_xModel = std::move(xModel);
bResult = true;
}
}
diff --git a/extensions/source/propctrlr/formcomponenthandler.cxx
b/extensions/source/propctrlr/formcomponenthandler.cxx
index 9933ce2f9dce..86acd8a1e483 100644
--- a/extensions/source/propctrlr/formcomponenthandler.cxx
+++ b/extensions/source/propctrlr/formcomponenthandler.cxx
@@ -225,7 +225,7 @@ namespace pcr
if( xStringResourceResolver.is() &&
xStringResourceResolver->getLocales().hasElements() )
{
- xRet = xStringResourceResolver;
+ xRet = std::move(xStringResourceResolver);
}
}
catch(const UnknownPropertyException&)
diff --git a/extensions/source/propctrlr/genericpropertyhandler.cxx
b/extensions/source/propctrlr/genericpropertyhandler.cxx
index fc91e007ae36..1abc97c962f5 100644
--- a/extensions/source/propctrlr/genericpropertyhandler.cxx
+++ b/extensions/source/propctrlr/genericpropertyhandler.cxx
@@ -310,7 +310,7 @@ namespace pcr
m_xComponent.set( xIntrospectionAccess->queryAdapter(
cppu::UnoType<XPropertySet>::get() ), UNO_QUERY_THROW );
// now that we survived so far, remember
m_xComponentIntrospectionAccess
- m_xComponentIntrospectionAccess = xIntrospectionAccess;
+ m_xComponentIntrospectionAccess = std::move(xIntrospectionAccess);
m_xPropertyState.set(m_xComponent, css::uno::UNO_QUERY);
m_bPropertyMapInitialized = false;
diff --git a/extensions/source/propctrlr/propertyhandler.cxx
b/extensions/source/propctrlr/propertyhandler.cxx
index bd6ba2af7407..cdedd0897e5d 100644
--- a/extensions/source/propctrlr/propertyhandler.cxx
+++ b/extensions/source/propctrlr/propertyhandler.cxx
@@ -85,7 +85,7 @@ namespace pcr
OSL_ENSURE( m_aPropertyListeners.getLength() == 0,
"PropertyHandler::inspect: derived classes are expected to forward the
removePropertyChangeListener call to their base class (me)!" );
// remember the new component, and give derived classes the chance to
react on it
- m_xComponent = xNewComponent;
+ m_xComponent = std::move(xNewComponent);
onNewComponent();
// add the listeners, again
diff --git a/extensions/source/update/check/updatehdl.cxx
b/extensions/source/update/check/updatehdl.cxx
index 711a86e3cd6c..7f26c06e4555 100644
--- a/extensions/source/update/check/updatehdl.cxx
+++ b/extensions/source/update/check/updatehdl.cxx
@@ -853,7 +853,7 @@ bool UpdateHandler::showWarning( const OUString
&rWarningText,
aDescriptor.Type = awt::WindowClass_MODALTOP;
aDescriptor.WindowServiceName = "warningbox";
aDescriptor.ParentIndex = -1;
- aDescriptor.Parent = xPeer;
+ aDescriptor.Parent = std::move(xPeer);
aDescriptor.Bounds = awt::Rectangle( 10, 10, 250, 150 );
aDescriptor.WindowAttributes = nWindowAttributes;
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index e636f16e33ed..470a53cc38c5 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -997,7 +997,7 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
aContext.SignContact = sSignContact;
aContext.SignReason = sSignReason;
aContext.SignPassword = sSignPassword;
- aContext.SignCertificate = aSignCertificate;
+ aContext.SignCertificate = std::move(aSignCertificate);
aContext.SignTSA = sSignTSA;
aContext.UseReferenceXObject = bUseReferenceXObject;
diff --git a/framework/source/helper/statusindicatorfactory.cxx
b/framework/source/helper/statusindicatorfactory.cxx
index fe88000996f8..b4b1366554d7 100644
--- a/framework/source/helper/statusindicatorfactory.cxx
+++ b/framework/source/helper/statusindicatorfactory.cxx
@@ -319,7 +319,7 @@ void
StatusIndicatorFactory::implts_makeParentVisibleIfAllowed()
if (xFrame.is())
xParentWindow = xFrame->getContainerWindow();
else
- xParentWindow = xPluggWindow;
+ xParentWindow = std::move(xPluggWindow);
// don't disturb user in case he put the loading document into the
background!
// Suppress any setVisible() or toFront() call in case the initial show was
@@ -477,7 +477,7 @@ void StatusIndicatorFactory::impl_showProgress()
}
std::scoped_lock g(m_mutex);
- m_xProgress = xProgress;
+ m_xProgress = std::move(xProgress);
}
void StatusIndicatorFactory::impl_hideProgress()
diff --git a/framework/source/helper/tagwindowasmodified.cxx
b/framework/source/helper/tagwindowasmodified.cxx
index 5776d5cee19e..8f4fb11f02ec 100644
--- a/framework/source/helper/tagwindowasmodified.cxx
+++ b/framework/source/helper/tagwindowasmodified.cxx
@@ -135,7 +135,7 @@ void TagWindowAsModified::impl_update (const
css::uno::Reference< css::frame::XF
// Note: frame was set as member outside ! we have to refresh
connections
// regarding window and model only here.
m_xWindow = std::move(pWindow);
- m_xModel = xModel;
+ m_xModel = std::move(xModel);
}
m_xModel->addModifyListener (this);
diff --git a/framework/source/services/frame.cxx
b/framework/source/services/frame.cxx
index 081ead8e70b7..aa9568700a5c 100644
--- a/framework/source/services/frame.cxx
+++ b/framework/source/services/frame.cxx
@@ -1165,7 +1165,7 @@ css::uno::Reference< css::frame::XFrame > SAL_CALL
XFrameImpl::findFrame( const
)
{
if (xParent->getName() == sTargetFrameName)
- xTarget = xParent;
+ xTarget = std::move(xParent);
else
{
sal_Int32 nRightFlags = nSearchFlags &
~css::frame::FrameSearchFlag::CHILDREN;
diff --git a/framework/source/uiconfiguration/imagemanagerimpl.cxx
b/framework/source/uiconfiguration/imagemanagerimpl.cxx
index e85d9a08789b..3dcfe40d764f 100644
--- a/framework/source/uiconfiguration/imagemanagerimpl.cxx
+++ b/framework/source/uiconfiguration/imagemanagerimpl.cxx
@@ -818,7 +818,7 @@ void ImageManagerImpl::replaceImages(
ConfigurationEvent aReplaceEvent;
aReplaceEvent.aInfo <<= nImageType;
aReplaceEvent.Accessor <<= xOwner;
- aReplaceEvent.Source = xOwner;
+ aReplaceEvent.Source = std::move(xOwner);
aReplaceEvent.ResourceURL = m_aResourceString;
aReplaceEvent.ReplacedElement = Any();
aReplaceEvent.Element <<= uno::Reference< XNameAccess
>(pReplacedImages);
@@ -1062,7 +1062,7 @@ void ImageManagerImpl::reload()
ConfigurationEvent aRemoveEvent;
aRemoveEvent.aInfo <<= static_cast<sal_uInt16>(i);
aRemoveEvent.Accessor <<= xOwner;
- aRemoveEvent.Source = xOwner;
+ aRemoveEvent.Source = std::move(xOwner);
aRemoveEvent.ResourceURL = m_aResourceString;
aRemoveEvent.Element <<= uno::Reference< XNameAccess
>( pRemovedImages );
implts_notifyContainerListener( aRemoveEvent, NotifyOp_Remove
);
diff --git a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
index 155334b72ed1..eeebdfc73730 100644
--- a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
+++ b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
@@ -1313,7 +1313,7 @@ void SAL_CALL
ModuleUIConfigurationManager::removeSettings( const OUString& Reso
aEvent.ResourceURL = ResourceURL;
aEvent.Accessor <<= xThis;
- aEvent.Source = xIfac;
+ aEvent.Source = std::move(xIfac);
aEvent.Element <<= xRemovedSettings;
aEvent.ReplacedElement <<= pDefaultDataSettings->xSettings;
@@ -1328,7 +1328,7 @@ void SAL_CALL
ModuleUIConfigurationManager::removeSettings( const OUString& Reso
aEvent.ResourceURL = ResourceURL;
aEvent.Accessor <<= xThis;
- aEvent.Source = xIfac;
+ aEvent.Source = std::move(xIfac);
aEvent.Element <<= xRemovedSettings;
aGuard.clear();
diff --git a/framework/source/uiconfiguration/uiconfigurationmanager.cxx
b/framework/source/uiconfiguration/uiconfigurationmanager.cxx
index 91b4624595ec..29be73cc0a72 100644
--- a/framework/source/uiconfiguration/uiconfigurationmanager.cxx
+++ b/framework/source/uiconfiguration/uiconfigurationmanager.cxx
@@ -660,7 +660,7 @@ void UIConfigurationManager::impl_Initialize()
m_aUIElements[i].nElementType = i;
m_aUIElements[i].bModified = false;
- m_aUIElements[i].xStorage = xElementTypeStorage;
+ m_aUIElements[i].xStorage = std::move(xElementTypeStorage);
}
}
else
diff --git a/linguistic/source/convdic.cxx b/linguistic/source/convdic.cxx
index 8ec888e38660..ac1f7436e572 100644
--- a/linguistic/source/convdic.cxx
+++ b/linguistic/source/convdic.cxx
@@ -86,7 +86,7 @@ static void ReadThroughDic( const OUString &rMainURL,
ConvDicXMLImport &rImport
// prepare ParserInputSource
xml::sax::InputSource aParserInput;
- aParserInput.aInputStream = xIn;
+ aParserInput.aInputStream = std::move(xIn);
// finally, parser the stream
try
diff --git a/oox/source/drawingml/chart/seriesconverter.cxx
b/oox/source/drawingml/chart/seriesconverter.cxx
index efa7f303662e..cc80c202f90d 100644
--- a/oox/source/drawingml/chart/seriesconverter.cxx
+++ b/oox/source/drawingml/chart/seriesconverter.cxx
@@ -399,7 +399,7 @@ void DataLabelConverter::convertFromModel( const Reference<
XDataSeries >& rxDat
xCustomLabel->setString( pRun->getText() );
xCustomLabel->setFieldType(
DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT );
}
- aSequenceRange[ nPos++ ] = xCustomLabel;
+ aSequenceRange[ nPos++ ] = std::move(xCustomLabel);
}
if( nParagraphs > 1 && nPos < nSequenceSize )
@@ -407,7 +407,7 @@ void DataLabelConverter::convertFromModel( const Reference<
XDataSeries >& rxDat
css::uno::Reference< XDataPointCustomLabelField >
xCustomLabel = DataPointCustomLabelField::create( xContext );
xCustomLabel->setFieldType(
DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_NEWLINE );
xCustomLabel->setString(u"
"_ustr);
- aSequenceRange[ nPos++ ] = xCustomLabel;
+ aSequenceRange[ nPos++ ] = std::move(xCustomLabel);
}
}
diff --git a/oox/source/drawingml/graphicshapecontext.cxx
b/oox/source/drawingml/graphicshapecontext.cxx
index 9207c6244e9c..85de7df3fffc 100644
--- a/oox/source/drawingml/graphicshapecontext.cxx
+++ b/oox/source/drawingml/graphicshapecontext.cxx
@@ -84,7 +84,7 @@ ContextHandlerRef GraphicShapeContext::onCreateContext(
sal_Int32 aElementToken,
Reference<XInputStream> xMediaStream = lcl_GetMediaStream(path,
getFilter());
if (xMediaStream.is())
{
- mpShapePtr->getGraphicProperties().m_xMediaStream =
xMediaStream;
+ mpShapePtr->getGraphicProperties().m_xMediaStream =
std::move(xMediaStream);
mpShapePtr->getGraphicProperties().m_sMediaPackageURL =
lcl_GetMediaReference(path);
}
}
diff --git a/oox/source/drawingml/misccontexts.cxx
b/oox/source/drawingml/misccontexts.cxx
index bca0a459171f..e080f3840e90 100644
--- a/oox/source/drawingml/misccontexts.cxx
+++ b/oox/source/drawingml/misccontexts.cxx
@@ -323,7 +323,7 @@ BlipContext::BlipContext(ContextHandler2Helper const &
rParent, const AttributeL
auto xGraphic = aGraphic.GetXGraphic();
mrBlipProps.mxFillGraphic = xGraphic;
if (mpBlipFill)
- mpBlipFill->mxGraphic = xGraphic;
+ mpBlipFill->mxGraphic = std::move(xGraphic);
}
}
diff --git a/package/source/xstor/xstorage.cxx
b/package/source/xstor/xstorage.cxx
index 73ec8207f1b7..c85a83a3f8e1 100644
--- a/package/source/xstor/xstorage.cxx
+++ b/package/source/xstor/xstorage.cxx
@@ -4383,7 +4383,7 @@ void SAL_CALL OStorage::setPropertyValue( const OUString&
aPropertyName, const u
throw lang::IllegalArgumentException( THROW_WHERE,
uno::Reference< uno::XInterface >(), 0 );
}
- m_pImpl->m_xNewRelInfoStream = xInRelStream;
+ m_pImpl->m_xNewRelInfoStream = std::move(xInRelStream);
m_pImpl->m_aRelInfo = uno::Sequence< uno::Sequence<
beans::StringPair > >();
m_pImpl->m_nRelInfoStatus = RELINFO_CHANGED_STREAM;
m_pImpl->m_bBroadcastModified = true;
diff --git a/pyuno/source/module/pyuno_struct.cxx
b/pyuno/source/module/pyuno_struct.cxx
index e1592eac929d..977ac8d70e69 100644
--- a/pyuno/source/module/pyuno_struct.cxx
+++ b/pyuno/source/module/pyuno_struct.cxx
@@ -407,7 +407,7 @@ PyRef PyUNOStruct_new (
if (self == nullptr)
return PyRef(); // == error
self->members = new PyUNOInternals;
- self->members->xInvocation = xInvocation;
+ self->members->xInvocation = std::move(xInvocation);
self->members->wrappedObject = targetInterface;
return PyRef( reinterpret_cast<PyObject*>(self), SAL_NO_ACQUIRE );
diff --git a/reportdesign/source/core/api/Functions.cxx
b/reportdesign/source/core/api/Functions.cxx
index 3d8bd6b6d61f..4ac080febf1f 100644
--- a/reportdesign/source/core/api/Functions.cxx
+++ b/reportdesign/source/core/api/Functions.cxx
@@ -125,7 +125,7 @@ void SAL_CALL OFunctions::replaceByIndex( ::sal_Int32
Index, const uno::Any& Ele
TFunctions::iterator aPos = m_aFunctions.begin();
::std::advance(aPos,Index);
aOldElement <<= *aPos;
- *aPos = xFunction;
+ *aPos = std::move(xFunction);
}
container::ContainerEvent
aEvent(static_cast<container::XContainer*>(this), uno::Any(Index), Element,
aOldElement);
diff --git a/reportdesign/source/core/api/Groups.cxx
b/reportdesign/source/core/api/Groups.cxx
index 4a1170e4c6b8..a6d9b0633e15 100644
--- a/reportdesign/source/core/api/Groups.cxx
+++ b/reportdesign/source/core/api/Groups.cxx
@@ -128,7 +128,7 @@ void SAL_CALL OGroups::replaceByIndex( ::sal_Int32 Index,
const uno::Any& Elemen
TGroups::iterator aPos = m_aGroups.begin();
::std::advance(aPos,Index);
aOldElement <<= *aPos;
- *aPos = xGroup;
+ *aPos = std::move(xGroup);
}
container::ContainerEvent
aEvent(static_cast<container::XContainer*>(this), uno::Any(Index), Element,
aOldElement);
diff --git a/sc/source/filter/excel/xechart.cxx
b/sc/source/filter/excel/xechart.cxx
index 8f5334cfdc0a..d5dd440be239 100644
--- a/sc/source/filter/excel/xechart.cxx
+++ b/sc/source/filter/excel/xechart.cxx
@@ -1769,7 +1769,7 @@ bool XclExpChSerErrorBar::Convert( XclExpChSourceLink&
rValueLink, sal_uInt16& r
OUString aCurrRole;
if( aValueProp.GetProperty( aCurrRole, EXC_CHPROP_ROLE
) && (aCurrRole == aRole) )
{
- xValueSeq = xTmpValueSeq;
+ xValueSeq = std::move(xTmpValueSeq);
break;
}
}
diff --git a/sc/source/ui/vba/vbaapplication.cxx
b/sc/source/ui/vba/vbaapplication.cxx
index 299e6adb4527..3d15627aa7c5 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -621,7 +621,7 @@ ScVbaApplication::getActiveSheet()
xWorkbook->getActiveSheet();
if ( xWorksheet.is() )
{
- result = xWorksheet;
+ result = std::move(xWorksheet);
}
}
diff --git a/scripting/source/provider/ProviderCache.cxx
b/scripting/source/provider/ProviderCache.cxx
index 2c1b1c27639a..b32ab099002e 100644
--- a/scripting/source/provider/ProviderCache.cxx
+++ b/scripting/source/provider/ProviderCache.cxx
@@ -98,7 +98,7 @@ ProviderCache::getAllProviders()
Reference<provider::XScriptProvider> xScriptProvider =
rDetail.second.provider;
if ( xScriptProvider.is() )
{
- pproviders[ providerIndex++ ] = xScriptProvider;
+ pproviders[ providerIndex++ ] = std::move(xScriptProvider);
}
else
{
@@ -106,7 +106,7 @@ ProviderCache::getAllProviders()
try
{
xScriptProvider = createProvider(rDetail.second);
- pproviders[ providerIndex++ ] = xScriptProvider;
+ pproviders[ providerIndex++ ] = std::move(xScriptProvider);
}
catch ( const Exception& )
{
@@ -158,7 +158,7 @@ ProviderCache::populateCache()
{
serviceName = *pName;
ProviderDetails details;
- details.factory = factory;
+ details.factory = std::move(factory);
m_hProviderDetailsCache[ serviceName ] =
std::move(details);
}
}
diff --git a/sd/source/console/PresenterAccessibility.cxx
b/sd/source/console/PresenterAccessibility.cxx
index da3af5563fd3..6b100c8d634b 100644
--- a/sd/source/console/PresenterAccessibility.cxx
+++ b/sd/source/console/PresenterAccessibility.cxx
@@ -715,7 +715,7 @@ void PresenterAccessible::AccessibleObject::SetWindow (
mxContentWindow->removeWindowListener(this);
}
- mxContentWindow = xContentWindow;
+ mxContentWindow = std::move(xContentWindow);
mxBorderWindow.set(rxBorderWindow, UNO_QUERY);
if (mxContentWindow.is())
diff --git a/sd/source/core/CustomAnimationCloner.cxx
b/sd/source/core/CustomAnimationCloner.cxx
index 495c8ce6ee93..8c89a5874f43 100644
--- a/sd/source/core/CustomAnimationCloner.cxx
+++ b/sd/source/core/CustomAnimationCloner.cxx
@@ -108,7 +108,7 @@ namespace sd
Reference< XShape > xTarget( pTarget->getUnoShape(),
UNO_QUERY );
if( xSource.is() && xTarget.is() )
{
- maShapeMap[xSource] = xTarget;
+ maShapeMap[xSource] = std::move(xTarget);
}
}
}
diff --git a/sd/source/filter/eppt/pptexanimations.cxx
b/sd/source/filter/eppt/pptexanimations.cxx
index b40137bb9cdc..7f1e2be5133b 100644
--- a/sd/source/filter/eppt/pptexanimations.cxx
+++ b/sd/source/filter/eppt/pptexanimations.cxx
@@ -706,7 +706,7 @@ void AnimationExporter::exportNode( SvStream& rStrm,
Reference< XAnimationNode >
{
if ( xChildNode->getType() ==
AnimationNodeType::AUDIO )
{
- xAudioNode = xChildNode;
+ xAudioNode = std::move(xChildNode);
nAudioGroup = mnCurrentGroup;
}
else
diff --git a/sd/source/filter/grf/sdgrffilter.cxx
b/sd/source/filter/grf/sdgrffilter.cxx
index 3d7b2faba601..91737b1727ff 100644
--- a/sd/source/filter/grf/sdgrffilter.cxx
+++ b/sd/source/filter/grf/sdgrffilter.cxx
@@ -306,7 +306,7 @@ bool SdGRFFilter::Export()
uno::Any aSelection(
pDrawController->getSelection() );
uno::Reference< lang::XComponent > xSelection;
if ( aSelection >>= xSelection )
- xSource = xSelection;
+ xSource = std::move(xSelection);
}
}
xExporter->setSourceDocument( xSource );
diff --git a/sd/source/ui/unoidl/unosrch.cxx b/sd/source/ui/unoidl/unosrch.cxx
index 545dcb8a4283..13e9643e95fb 100644
--- a/sd/source/ui/unoidl/unosrch.cxx
+++ b/sd/source/ui/unoidl/unosrch.cxx
@@ -324,7 +324,7 @@ uno::Reference< css::uno::XInterface > SAL_CALL
SdUnoSearchReplaceShape::findNex
// get next shape on our page
uno::Reference< drawing::XShape > xFound2( GetNextShape(
mpPage, xCurrentShape ) );
if( xFound2.is() && (xFound2.get() != xCurrentShape.get())
)
- xCurrentShape = xFound2;
+ xCurrentShape = std::move(xFound2);
else
xCurrentShape = nullptr;
diff --git a/sdext/source/minimizer/pagecollector.cxx
b/sdext/source/minimizer/pagecollector.cxx
index f86444abbfae..265922803e7c 100644
--- a/sdext/source/minimizer/pagecollector.cxx
+++ b/sdext/source/minimizer/pagecollector.cxx
@@ -106,7 +106,7 @@ void PageCollector::CollectMasterPages( const Reference<
XModel >& rxModel, std:
if ( aIter == rMasterPageList.end() )
{
MasterPageEntity aMasterPageEntity;
- aMasterPageEntity.xMasterPage = xMasterPage;
+ aMasterPageEntity.xMasterPage = std::move(xMasterPage);
aMasterPageEntity.bUsed = false;
rMasterPageList.push_back( aMasterPageEntity );
}
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 2619b58cb48e..c96e338cbe11 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -4743,7 +4743,7 @@ OUString SfxMedium::SwitchDocumentToTempFile()
SetPhysicalName_Impl( OUString() );
SetName( aOrigURL );
GetMedium_Impl();
- pImpl->xStorage = xStorage;
+ pImpl->xStorage = std::move(xStorage);
}
}
}
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 0e2001428ff3..e77fdf2048c9 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3233,7 +3233,7 @@ void SfxBaseModel::impl_store( const OUString&
sURL
if ( bCopyTo )
{
// restore DocumentProperties if a copy was created
- m_pData->m_xDocumentProperties = xOldDocProps;
+ m_pData->m_xDocumentProperties = std::move(xOldDocProps);
}
Reference < task::XInteractionHandler > xHandler;
diff --git a/slideshow/source/engine/slide/targetpropertiescreator.cxx
b/slideshow/source/engine/slide/targetpropertiescreator.cxx
index c0d6b38bfef7..2752d543e55c 100644
--- a/slideshow/source/engine/slide/targetpropertiescreator.cxx
+++ b/slideshow/source/engine/slide/targetpropertiescreator.cxx
@@ -208,7 +208,7 @@ namespace slideshow::internal
if( xTargetShape.is() )
{
// override target shape with parent-supplied
- aTarget.mxRef = xTargetShape;
+ aTarget.mxRef = std::move(xTargetShape);
aTarget.mnParagraphIndex = nParagraphIndex;
}
else
diff --git a/stoc/source/security/access_controller.cxx
b/stoc/source/security/access_controller.cxx
index e6ab2b45bd54..02aa9da547fe 100644
--- a/stoc/source/security/access_controller.cxx
+++ b/stoc/source/security/access_controller.cxx
@@ -445,7 +445,7 @@ Reference< security::XPolicy > const &
AccessController::getPolicy()
MutexGuard guard( m_aMutex );
if (! m_xPolicy.is())
{
- m_xPolicy = xPolicy;
+ m_xPolicy = std::move(xPolicy);
}
}
return m_xPolicy;
diff --git a/stoc/source/servicemanager/servicemanager.cxx
b/stoc/source/servicemanager/servicemanager.cxx
index be529abef58e..80aaae31bfbd 100644
--- a/stoc/source/servicemanager/servicemanager.cxx
+++ b/stoc/source/servicemanager/servicemanager.cxx
@@ -526,7 +526,7 @@ void SAL_CALL OServiceManagerWrapper::setPropertyValue(
}
MutexGuard aGuard( m_aMutex );
- m_xContext = xContext;
+ m_xContext = std::move(xContext);
}
else
diff --git a/svl/source/misc/documentlockfile.cxx
b/svl/source/misc/documentlockfile.cxx
index f3641a5e049d..5ee13a68bbf0 100644
--- a/svl/source/misc/documentlockfile.cxx
+++ b/svl/source/misc/documentlockfile.cxx
@@ -91,7 +91,7 @@ bool GenDocumentLockFile::CreateOwnLockFile()
::ucbhelper::Content aTargetContent( GetURL(), xEnv,
comphelper::getProcessComponentContext() );
ucb::InsertCommandArgument aInsertArg;
- aInsertArg.Data = xInput;
+ aInsertArg.Data = std::move(xInput);
aInsertArg.ReplaceExisting = false;
uno::Any aCmdArg;
aCmdArg <<= aInsertArg;
diff --git a/svx/source/form/datanavi.cxx b/svx/source/form/datanavi.cxx
index a66e64a472e9..e0ce5ee2ae7e 100644
--- a/svx/source/form/datanavi.cxx
+++ b/svx/source/form/datanavi.cxx
@@ -1786,7 +1786,7 @@ namespace svxform
Reference< XNameContainer > xContainer =
xFormsSupp->getXForms();
if ( xContainer.is() )
{
- m_xDataContainer = xContainer;
+ m_xDataContainer = std::move(xContainer);
const Sequence< OUString > aNameList =
m_xDataContainer->getElementNames();
for ( const OUString& rName : aNameList )
{
@@ -2311,7 +2311,7 @@ namespace svxform
Reference< css::xml::dom::XNode > xNewNode =
m_xUIHelper->renameNode( m_pItemNode->m_xNode,
m_xNameED->get_text() );
m_xUIHelper->setNodeValue( xNewNode,
m_xDefaultED->get_text() );
- m_pItemNode->m_xNode = xNewNode;
+ m_pItemNode->m_xNode = std::move(xNewNode);
}
}
catch ( Exception const & )
@@ -2979,7 +2979,7 @@ namespace svxform
m_xBindLB->append_text(sEntry);
if ( !m_xTempBinding.is() )
- m_xTempBinding = xPropSet;
+ m_xTempBinding = std::move(xPropSet);
}
}
}
diff --git a/svx/source/items/galleryitem.cxx b/svx/source/items/galleryitem.cxx
index 91f2d24ebbc2..b69062f75386 100644
--- a/svx/source/items/galleryitem.cxx
+++ b/svx/source/items/galleryitem.cxx
@@ -115,8 +115,8 @@ bool SvxGalleryItem::PutValue( const css::uno::Any& rVal,
sal_uInt8 /* nMemberId
m_nType = nType;
m_aURL = aURL;
- m_xDrawing = xDrawing;
- m_xGraphic = xGraphic;
+ m_xDrawing = std::move(xDrawing);
+ m_xGraphic = std::move(xGraphic);
return true;
}
diff --git a/sw/source/filter/html/htmlforw.cxx
b/sw/source/filter/html/htmlforw.cxx
index 42db807771f9..9d90df1842e2 100644
--- a/sw/source/filter/html/htmlforw.cxx
+++ b/sw/source/filter/html/htmlforw.cxx
@@ -311,7 +311,7 @@ void SwHTMLWriter::OutForm( bool bTag_On, const SwStartNode
*pStartNd )
{
// A form should be opened in the table/area which isn't completely
// inside the table. Then we must also now open the form.
- xNewFormComps = xCurrentFormComps;
+ xNewFormComps = std::move(xCurrentFormComps);
}
}
@@ -329,7 +329,7 @@ void SwHTMLWriter::OutForm( bool bTag_On, const SwStartNode
*pStartNd )
//!!!nWarn = 1; // Control will be assigned to wrong form
}
- mxFormComps = xNewFormComps;
+ mxFormComps = std::move(xNewFormComps);
OutForm( true, mxFormComps );
uno::Reference< beans::XPropertySet > xTmp;
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 828c295d77a0..59927e931a4c 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -6089,7 +6089,7 @@ void SwContentTree::EditEntry(const weld::TreeIter&
rEntry, EditEntryMode nMode)
Reference< XIndexAccess>
xIdxAcc(xModel->getDocumentIndexes());
Reference< XNameAccess >xLocalNameAccess(xIdxAcc,
UNO_QUERY);
if(EditEntryMode::RENAME == nMode)
- xNameAccess = xLocalNameAccess;
+ xNameAccess = std::move(xLocalNameAccess);
else if(xLocalNameAccess.is() &&
xLocalNameAccess->hasByName(pBase->GetTOXName()))
{
Any aIdx =
xLocalNameAccess->getByName(pBase->GetTOXName());
diff --git a/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
b/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
index 552a5babb438..14e1149356bf 100644
--- a/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
+++ b/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
@@ -9530,7 +9530,7 @@ void DomainMapper_Impl::ImportGraphic(const
writerfilter::Reference<Properties>
{
// Remember this object is anchored to the current paragraph.
AnchoredObjectInfo aInfo;
- aInfo.m_xAnchoredObject = xTextContent;
+ aInfo.m_xAnchoredObject = std::move(xTextContent);
if (m_pGraphicImport)
{
// We still have the graphic import around, remember the
original margin, so later
@@ -9549,7 +9549,7 @@ void DomainMapper_Impl::ImportGraphic(const
writerfilter::Reference<Properties>
{
// Remember this object is anchored to the current paragraph.
AnchoredObjectInfo aInfo;
- aInfo.m_xAnchoredObject = xTextContent;
+ aInfo.m_xAnchoredObject = std::move(xTextContent);
aInfo.m_xRedlineForInline = m_aRedlines.top().back();
m_aTextAppendStack.top().m_aAnchoredObjects.push_back(aInfo);
}
diff --git a/sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx
b/sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx
index f874466affdc..9192f1055a89 100644
--- a/sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx
+++ b/sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx
@@ -211,19 +211,17 @@ void OOXMLDocumentImpl::importSubStreamRelations(const
OOXMLStream::Pointer_t& p
if(xRelation.is())
{
- mxCustomXmlProsDom = xRelation;
+ mxCustomXmlProsDom = std::move(xRelation);
}
}
else if(OOXMLStream::EMBEDDINGS == nType)
{
- mxEmbeddings = xcpInputStream;
+ mxEmbeddings = std::move(xcpInputStream);
}
else if(OOXMLStream::CHARTS == nType)
{
importSubStreamRelations(cStream, OOXMLStream::EMBEDDINGS);
}
-
-
}
void OOXMLDocumentImpl::setXNoteId(const sal_Int32 nId)
diff --git a/toolkit/source/controls/dialogcontrol.cxx
b/toolkit/source/controls/dialogcontrol.cxx
index d123194dfcfc..110e56c88406 100644
--- a/toolkit/source/controls/dialogcontrol.cxx
+++ b/toolkit/source/controls/dialogcontrol.cxx
@@ -112,7 +112,7 @@ public:
Reference< T > xElement;
if ( ! ( aElement >>= xElement ) )
throw IllegalArgumentException();
- things[ aName ] = xElement;
+ things[ aName ] = std::move(xElement);
}
virtual void SAL_CALL removeByName( const OUString& aName ) override
{
diff --git a/ucb/source/ucp/hierarchy/hierarchycontent.cxx
b/ucb/source/ucp/hierarchy/hierarchycontent.cxx
index da0a328fe8ff..5a1c062f8ef5 100644
--- a/ucb/source/ucp/hierarchy/hierarchycontent.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchycontent.cxx
@@ -1392,7 +1392,7 @@ void HierarchyContent::insert( sal_Int32
nNameClashResolve,
// Identifier changed?
bool bNewId = ( xId->getContentIdentifier()
!= m_xIdentifier->getContentIdentifier() );
- m_xIdentifier = xId;
+ m_xIdentifier = std::move(xId);
if ( !storeData() )
{
diff --git a/ucb/source/ucp/hierarchy/hierarchydata.cxx
b/ucb/source/ucp/hierarchy/hierarchydata.cxx
index 114fbc742cef..725e4c3d1c26 100644
--- a/ucb/source/ucp/hierarchy/hierarchydata.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchydata.cxx
@@ -875,7 +875,7 @@ bool HierarchyEntry::first( iterator & it )
OSL_ENSURE( xHierNameAccess.is(),
"HierarchyEntry::first - No hier. name access!" );
- it.dir = xHierNameAccess;
+ it.dir = std::move(xHierNameAccess);
it.officeDirs = m_xOfficeInstDirs;
}
diff --git a/unotools/source/config/fontcfg.cxx
b/unotools/source/config/fontcfg.cxx
index 2813131b1472..398925353a6f 100644
--- a/unotools/source/config/fontcfg.cxx
+++ b/unotools/source/config/fontcfg.cxx
@@ -154,7 +154,7 @@ OUString DefaultFontConfiguration::tryLocale( const
OUString& rBcp47, const OUSt
{
Any aAny = m_xConfigAccess->getByName(
it->second.aConfigLocaleString );
if( aAny >>= xNode )
- it->second.xAccess = xNode;
+ it->second.xAccess = std::move(xNode);
}
}
catch (const NoSuchElementException&)
diff --git a/vcl/source/treelist/transfer.cxx b/vcl/source/treelist/transfer.cxx
index 0fbe9304d0d1..150f3ccbfb57 100644
--- a/vcl/source/treelist/transfer.cxx
+++ b/vcl/source/treelist/transfer.cxx
@@ -2204,7 +2204,7 @@ TransferableDataHelper
TransferableDataHelper::CreateFromPrimarySelection()
if( xTransferable.is() )
{
aRet = TransferableDataHelper( xTransferable );
- aRet.mxClipboard = xSelection;
+ aRet.mxClipboard = std::move(xSelection);
}
}
catch( const css::uno::Exception& )
diff --git a/xmloff/source/chart/SchXMLPlotAreaContext.cxx
b/xmloff/source/chart/SchXMLPlotAreaContext.cxx
index 7beeee3a4fbb..b4eb49345ae1 100644
--- a/xmloff/source/chart/SchXMLPlotAreaContext.cxx
+++ b/xmloff/source/chart/SchXMLPlotAreaContext.cxx
@@ -1039,7 +1039,7 @@ static void lcl_setErrorBarSequence ( const
uno::Reference< chart2::XChartDocume
xDataSource->getDataSequences());
aSequences.realloc( aSequences.getLength() + 1 );
- aSequences.getArray()[ aSequences.getLength() - 1 ] = xLabelSeq;
+ aSequences.getArray()[ aSequences.getLength() - 1 ] = std::move(xLabelSeq);
xDataSink->setData( aSequences );
}
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index 2f8126e34322..74ee70aa6a33 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -1517,11 +1517,11 @@ OUString SdXMLExport::ImpCreatePresPageStyleName( const
Reference<XDrawPage>& xD
if( xPropSet2.is() )
xPropSet = PropertySetMerger_CreateInstance( xPropSet1,
xPropSet2 );
else
- xPropSet = xPropSet1;
+ xPropSet = std::move(xPropSet1);
}
else
{
- xPropSet = xPropSet1;
+ xPropSet = std::move(xPropSet1);
}
const rtl::Reference< SvXMLExportPropertyMapper > aMapperRef(
GetPresPagePropsMapper() );
commit 4c9f9736cdd90225b40aff7414d4479f3692613a
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Oct 27 16:51:51 2024 +0000
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Oct 27 20:19:00 2024 +0100
cid#1603630 Big parameter passed by value
Change-Id: I8b0f01d6e93f40a2c7dbdbabcd299096c5bddae7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175699
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx
index 43ca32993d80..842474dd7af7 100644
--- a/sc/source/ui/inc/tabvwsh.hxx
+++ b/sc/source/ui/inc/tabvwsh.hxx
@@ -487,7 +487,8 @@ private:
bool DoTableBackgroundDialog( sal_Int32 nResult, const
VclPtr<AbstractScTabBgColorDlg>& pDlg, const std::shared_ptr<SfxRequest>& xReq,
Color aOldTabBgColor, sal_uInt16 nSlot );
void ExecuteStyleEdit(SfxRequest& rReq, SfxStyleSheetBase* pStyleSheet,
sal_uInt16 nRetMask, sal_uInt16 nSlotId,
bool bAddUndo, bool bUndo,
- ScStyleSaveData& rOldData, ScStyleSaveData&
rNewData,
+ const std::shared_ptr<ScStyleSaveData>& rOldData,
+ const std::shared_ptr<ScStyleSaveData>& rNewData,
SfxStyleFamily eFamily, bool bStyleToMarked, bool
bListAction,
SdrObject* pEditObject, ESelection aSelection);
void ExecuteStyleEditDialog(VclPtr<SfxAbstractTabDialog> pDlg,
diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index f79601df9f39..a01da9d50b3f 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -962,8 +962,8 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
bool bStyleToMarked = false;
bool bListAction = false;
bool bAddUndo = false; // add ScUndoModifyStyle (style modified)
- ScStyleSaveData aOldData; // for undo/redo
- ScStyleSaveData aNewData;
+ auto xOldData = std::make_shared<ScStyleSaveData>(); // for undo/redo
+ auto xNewData = std::make_shared<ScStyleSaveData>();
SfxStyleFamily eFamily = SfxStyleFamily::Para;
const SfxUInt16Item* pFamItem;
@@ -1052,7 +1052,7 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
pStyleSheet = pStylePool->Find( aStyleName, eFamily );
- aOldData.InitFromStyle( pStyleSheet );
+ xOldData->InitFromStyle( pStyleSheet );
}
break;
@@ -1236,7 +1236,7 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
if ( pStyleSheet )
{
- aOldData.InitFromStyle( pStyleSheet );
+ xOldData->InitFromStyle( pStyleSheet );
if ( bUndo )
{
@@ -1254,7 +1254,7 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
}
}
- aNewData.InitFromStyle( pStyleSheet );
+ xNewData->InitFromStyle( pStyleSheet );
bAddUndo = true;
rReq.Done();
}
@@ -1365,7 +1365,7 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
if ( bUsed )
ScPrintFunc( pDocSh, GetPrinter(true), nInTab
).UpdatePages();
- aNewData.InitFromStyle( pStyleSheet );
+ xNewData->InitFromStyle( pStyleSheet );
bAddUndo = true;
rReq.Done();
nRetMask = sal_uInt16(true);
@@ -1442,7 +1442,7 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
else
{
pStyleSheet = GetDrawView()->GetStyleSheet();
- aOldData.InitFromStyle( pStyleSheet );
+ xOldData->InitFromStyle( pStyleSheet );
}
if ( bUndo )
@@ -1459,7 +1459,7 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
pStyleSet->Put(aCoreSet);
static_cast<SfxStyleSheet*>(pStyleSheet)->Broadcast(SfxHint(SfxHintId::DataChanged));
- aNewData.InitFromStyle( pStyleSheet );
+ xNewData->InitFromStyle( pStyleSheet );
bAddUndo = true;
// call SetStyleSheet after adding the ScUndoModifyStyle
@@ -1483,18 +1483,19 @@ void ScTabViewShell::ExecStyle( SfxRequest& rReq )
if (pStyleSheet)
{
ExecuteStyleEdit(rReq, pStyleSheet, nRetMask, nSlotId, bAddUndo,
bUndo,
- aOldData, aNewData, eFamily, bStyleToMarked, bListAction,
pEditObject, aSelection);
+ xOldData, xNewData, eFamily, bStyleToMarked, bListAction,
pEditObject, aSelection);
return; // skip calling ExecuteStyleEditPost because we invoked an
async dialog
}
}
ExecuteStyleEditPost(rReq, pStyleSheet, nSlotId, nRetMask, bAddUndo, bUndo,
- eFamily, aOldData, aNewData, bStyleToMarked, bListAction,
pEditObject, aSelection);
+ eFamily, *xOldData, *xNewData, bStyleToMarked, bListAction,
pEditObject, aSelection);
}
void ScTabViewShell::ExecuteStyleEdit(SfxRequest& rReq, SfxStyleSheetBase*
pStyleSheet, sal_uInt16 nRetMask,
sal_uInt16 nSlotId, bool bAddUndo, bool bUndo,
- ScStyleSaveData& rOldData, ScStyleSaveData& rNewData,
SfxStyleFamily eFamily,
+ const std::shared_ptr<ScStyleSaveData>& rOldData,
+ const std::shared_ptr<ScStyleSaveData>& rNewData,
SfxStyleFamily eFamily,
bool bStyleToMarked, bool bListAction,
SdrObject* pEditObject, ESelection aSelection)
{
@@ -1583,16 +1584,16 @@ void ScTabViewShell::ExecuteStyleEdit(SfxRequest& rReq,
SfxStyleSheetBase* pStyl
pDlg->StartExecuteAsync(
[this, pDlg, xRequest=std::move(xRequest), pStyleSheet,
nRetMask, xOldSet=std::move(xOldSet), nSlotId, bAddUndo, bUndo,
- aOldData=rOldData, aNewData=rNewData, aOldName, eFamily,
bStyleToMarked,
+ xOldData = rOldData, xNewData = rNewData, aOldName, eFamily,
bStyleToMarked,
bListAction, pEditObject, aSelection]
(sal_Int32 nResult) mutable -> void
{
SetInFormatDialog(false);
ExecuteStyleEditDialog(pDlg, pStyleSheet, nResult, nRetMask,
xOldSet, nSlotId,
- bAddUndo, aNewData, aOldName);
+ bAddUndo, *xNewData, aOldName);
pDlg->disposeOnce();
ExecuteStyleEditPost(*xRequest, pStyleSheet, nSlotId, nRetMask,
bAddUndo, bUndo, eFamily,
- aOldData, aNewData, bStyleToMarked, bListAction,
pEditObject, aSelection);
+ *xOldData, *xNewData, bStyleToMarked, bListAction,
pEditObject, aSelection);
}
);
}
