sc/source/filter/excel/excform8.cxx | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
New commits: commit 4fc95df9c32aa17b73c5bd08d2ab01e6f3c4c15c Author: Bogdan Buzea <buzea.bog...@libreoffice.org> AuthorDate: Sat Oct 19 18:03:32 2024 +0200 Commit: David Gilbert <freedesk...@treblig.org> CommitDate: Sun Oct 27 01:17:33 2024 +0200 tdf#163486: PVS: Identical branches V1037 Two or more case-branches perform the same actions. Check lines: 589, 643, 648 Change-Id: I808deb5f3a705ae18e97c51737213f280189fdb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175214 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesk...@treblig.org> diff --git a/sc/source/filter/excel/excform8.cxx b/sc/source/filter/excel/excform8.cxx index 6f053373d193..7de536469cff 100644 --- a/sc/source/filter/excel/excform8.cxx +++ b/sc/source/filter/excel/excform8.cxx @@ -583,11 +583,6 @@ ConvErr ExcelToSc8::Convert( std::unique_ptr<ScTokenArray>& rpTokArray, XclImpSt case 0x28: // Incomplete Constant Reference Subexpr.[331 281] aIn.Ignore( 6 ); // There isn't any more break; - case 0x49: - case 0x69: - case 0x29: // Variable Reference Subexpression [331 281] - aIn.Ignore( 2 ); // There isn't any more - break; case 0x4C: case 0x6C: case 0x2C: // Cell Reference Within a Name [323 ] @@ -637,11 +632,12 @@ ConvErr ExcelToSc8::Convert( std::unique_ptr<ScTokenArray>& rpTokArray, XclImpSt aStack << aPool.Store( aCRD ); break; } + case 0x49: + case 0x69: + case 0x29: // Variable Reference Subexpression [331 281] case 0x4E: case 0x6E: case 0x2E: // Reference Subexpression Within a Name [332 282] - aIn.Ignore( 2 ); // There isn't any more - break; case 0x4F: case 0x6F: case 0x2F: // Incomplete Reference Subexpression... [332 282]