accessibility/source/standard/vclxaccessibletabpage.cxx | 2 - basic/source/classes/eventatt.cxx | 2 - basic/source/uno/dlgcont.cxx | 2 - basic/source/uno/scriptcont.cxx | 2 - chart2/source/tools/ObjectIdentifier.cxx | 2 - connectivity/source/commontools/ConnectionWrapper.cxx | 2 - cui/source/dialogs/QrCodeGenDialog.cxx | 2 - cui/source/dialogs/SignatureLineDialog.cxx | 2 - editeng/source/misc/unolingu.cxx | 2 - embeddedobj/source/general/docholder.cxx | 6 ++--- embeddedobj/source/msole/olepersist.cxx | 4 +-- filter/source/xsltdialog/xmlfiltertestdialog.cxx | 4 +-- forms/source/xforms/model.cxx | 2 - framework/source/accelerators/documentacceleratorconfiguration.cxx | 2 - framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx | 2 - framework/source/uielement/generictoolbarcontroller.cxx | 2 - oox/source/drawingml/misccontexts.cxx | 2 - oox/source/drawingml/shape.cxx | 2 - package/source/xstor/owriteablestream.cxx | 2 - package/source/zippackage/ZipPackageStream.cxx | 2 - reportdesign/source/ui/report/ReportController.cxx | 2 - sc/source/filter/oox/pivotcachebuffer.cxx | 2 - sd/source/ui/unoidl/unomodel.cxx | 2 - sfx2/source/doc/SfxDocumentMetaData.cxx | 11 ++++------ stoc/source/inspect/introspection.cxx | 6 ++--- svx/source/form/fmshimp.cxx | 6 ++--- svx/source/form/formcontroller.cxx | 2 - sw/source/core/edit/edfcol.cxx | 2 - sw/source/uibase/uno/unomailmerge.cxx | 2 - sw/source/writerfilter/rtftok/rtfsdrimport.cxx | 2 - toolkit/source/controls/dialogcontrol.cxx | 2 - ucb/source/cacher/cacheddynamicresultsetstub.cxx | 2 - xmloff/source/core/xmlexp.cxx | 6 ++--- xmloff/source/text/XMLChangedRegionImportContext.cxx | 2 - xmloff/source/text/txtflde.cxx | 2 - 35 files changed, 49 insertions(+), 50 deletions(-)
New commits: commit 7cf8cffcb8cfb722ab27a2884c146b464ef89041 Author: Caolán McNamara <caolan.mcnam...@collabora.com> AuthorDate: Thu Oct 24 19:54:05 2024 +0100 Commit: Caolán McNamara <caolan.mcnam...@collabora.com> CommitDate: Fri Oct 25 10:48:12 2024 +0200 cid#1633347 COPY_INSTEAD_OF_MOVE and cid#1633346 COPY_INSTEAD_OF_MOVE cid#1633344 COPY_INSTEAD_OF_MOVE cid#1633343 COPY_INSTEAD_OF_MOVE cid#1633340 COPY_INSTEAD_OF_MOVE cid#1608137 COPY_INSTEAD_OF_MOVE cid#1608131 COPY_INSTEAD_OF_MOVE cid#1607860 COPY_INSTEAD_OF_MOVE cid#1607432 COPY_INSTEAD_OF_MOVE cid#1607394 COPY_INSTEAD_OF_MOVE cid#1607310 COPY_INSTEAD_OF_MOVE cid#1607156 COPY_INSTEAD_OF_MOVE cid#1607093 COPY_INSTEAD_OF_MOVE cid#1607090 COPY_INSTEAD_OF_MOVE cid#1607039 COPY_INSTEAD_OF_MOVE cid#1606709 COPY_INSTEAD_OF_MOVE cid#1558053 COPY_INSTEAD_OF_MOVE cid#1558052 COPY_INSTEAD_OF_MOVE cid#1558042 COPY_INSTEAD_OF_MOVE cid#1558038 COPY_INSTEAD_OF_MOVE cid#1558037 COPY_INSTEAD_OF_MOVE cid#1558034 COPY_INSTEAD_OF_MOVE cid#1558031 COPY_INSTEAD_OF_MOVE cid#1558027 COPY_INSTEAD_OF_MOVE cid#1557994 COPY_INSTEAD_OF_MOVE cid#1557977 COPY_INSTEAD_OF_MOVE cid#1557970 COPY_INSTEAD_OF_MOVE cid#1557966 COPY_INSTEAD_OF_MOVE cid#1557957 COPY_INSTEAD_OF_MOVE cid#1557954 COPY_INSTEAD_OF_MOVE cid#1557941 COPY_INSTEAD_OF_MOVE cid#1557933 COPY_INSTEAD_OF_MOVE cid#1557918 COPY_INSTEAD_OF_MOVE cid#1557907 COPY_INSTEAD_OF_MOVE cid#1557890 COPY_INSTEAD_OF_MOVE cid#1557883 COPY_INSTEAD_OF_MOVE cid#1557881 COPY_INSTEAD_OF_MOVE cid#1557861 COPY_INSTEAD_OF_MOVE cid#1557842 COPY_INSTEAD_OF_MOVE cid#1557840 COPY_INSTEAD_OF_MOVE cid#1557830 COPY_INSTEAD_OF_MOVE cid#1557830 COPY_INSTEAD_OF_MOVE Change-Id: If5ee3396eafdb8b338d9e6cf0705be6e2b431fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com> diff --git a/accessibility/source/standard/vclxaccessibletabpage.cxx b/accessibility/source/standard/vclxaccessibletabpage.cxx index d2e32f1dfa46..3e3c09d148a7 100644 --- a/accessibility/source/standard/vclxaccessibletabpage.cxx +++ b/accessibility/source/standard/vclxaccessibletabpage.cxx @@ -412,7 +412,7 @@ Reference< XAccessible > VCLXAccessibleTabPage::getAccessibleAtPoint( const awt: Point aPos = VCLUnoHelper::ConvertToVCLPoint(rPoint); if ( aRect.Contains( aPos ) ) { - xChild = xAcc; + xChild = std::move(xAcc); break; } } diff --git a/basic/source/classes/eventatt.cxx b/basic/source/classes/eventatt.cxx index f97f1a77afef..b7ffebb0e983 100644 --- a/basic/source/classes/eventatt.cxx +++ b/basic/source/classes/eventatt.cxx @@ -499,7 +499,7 @@ void RTL_Impl_CreateUnoDialog( SbxArray& rPar ) if ( aDlgLib.is() ) { bDocDialog = true; - xModel = xNextModel; + xModel = std::move(xNextModel); break; } } diff --git a/basic/source/uno/dlgcont.cxx b/basic/source/uno/dlgcont.cxx index e302c1dd392f..48cdfd36d628 100644 --- a/basic/source/uno/dlgcont.cxx +++ b/basic/source/uno/dlgcont.cxx @@ -324,7 +324,7 @@ Any SfxDialogLibraryContainer::importLibraryElement return aRetAny; InputSource source; - source.aInputStream = xInput; + source.aInputStream = std::move(xInput); source.sSystemId = aFile; try { diff --git a/basic/source/uno/scriptcont.cxx b/basic/source/uno/scriptcont.cxx index 07ddb654f815..4f90fecd3e13 100644 --- a/basic/source/uno/scriptcont.cxx +++ b/basic/source/uno/scriptcont.cxx @@ -228,7 +228,7 @@ Any SfxScriptLibraryContainer::importLibraryElement return aRetAny; InputSource source; - source.aInputStream = xInput; + source.aInputStream = std::move(xInput); source.sSystemId = aFile; // start parsing diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx index 712ca15796ce..1e4e2764d063 100644 --- a/chart2/source/tools/ObjectIdentifier.cxx +++ b/chart2/source/tools/ObjectIdentifier.cxx @@ -1207,7 +1207,7 @@ Reference< beans::XPropertySet > ObjectIdentifier::getObjectPropertySet( errorBar = "ErrorBarZ"; xSeries->getPropertyValue( errorBar ) >>= xErrorBarProp; - xObjectProperties = xErrorBarProp; + xObjectProperties = std::move(xErrorBarProp); } break; } diff --git a/connectivity/source/commontools/ConnectionWrapper.cxx b/connectivity/source/commontools/ConnectionWrapper.cxx index 109f3d7b9459..12e3645ed27b 100644 --- a/connectivity/source/commontools/ConnectionWrapper.cxx +++ b/connectivity/source/commontools/ConnectionWrapper.cxx @@ -82,7 +82,7 @@ void OConnectionWrapper::setDelegation(const Reference< XConnection >& _xConnect if (xConProxy.is()) { // transfer the (one and only) real ref to the aggregate to our member - m_xProxyConnection = xConProxy; + m_xProxyConnection = std::move(xConProxy); // set ourself as delegator Reference<XInterface> xIf = static_cast< XUnoTunnel* >( this ); diff --git a/cui/source/dialogs/QrCodeGenDialog.cxx b/cui/source/dialogs/QrCodeGenDialog.cxx index ae712ed7a2ca..6fdf6c130319 100644 --- a/cui/source/dialogs/QrCodeGenDialog.cxx +++ b/cui/source/dialogs/QrCodeGenDialog.cxx @@ -215,7 +215,7 @@ QrCodeGenDialog::QrCodeGenDialog(weld::Widget* pParent, Reference<XModel> xModel m_xComboType->set_active(aBarCode.Type); // Mark this as existing shape - m_xExistingShapeProperties = xProps; + m_xExistingShapeProperties = std::move(xProps); } short QrCodeGenDialog::run() diff --git a/cui/source/dialogs/SignatureLineDialog.cxx b/cui/source/dialogs/SignatureLineDialog.cxx index aece41a3d89d..84d5adf1065c 100644 --- a/cui/source/dialogs/SignatureLineDialog.cxx +++ b/cui/source/dialogs/SignatureLineDialog.cxx @@ -88,7 +88,7 @@ SignatureLineDialog::SignatureLineDialog(weld::Widget* pParent, Reference<XModel m_xCheckboxShowSignDate->set_active(bShowSignDate); // Mark this as existing shape - m_xExistingShapeProperties = xProps; + m_xExistingShapeProperties = std::move(xProps); } void SignatureLineDialog::Apply() diff --git a/editeng/source/misc/unolingu.cxx b/editeng/source/misc/unolingu.cxx index 4cf67b9e2f20..bb256e0bba60 100644 --- a/editeng/source/misc/unolingu.cxx +++ b/editeng/source/misc/unolingu.cxx @@ -659,7 +659,7 @@ uno::Reference< XDictionary > LinguMgr::GetStandard() xTmpDicList->addDictionary( xTmp ); xTmp->setActive( true ); } - xDic = xTmp; + xDic = std::move(xTmp); } #if OSL_DEBUG_LEVEL > 1 uno::Reference< XStorable > xStor( xDic, UNO_QUERY ); diff --git a/embeddedobj/source/general/docholder.cxx b/embeddedobj/source/general/docholder.cxx index ca91d964bc11..eddc8a47ca0f 100644 --- a/embeddedobj/source/general/docholder.cxx +++ b/embeddedobj/source/general/docholder.cxx @@ -411,7 +411,7 @@ bool DocumentHolder::ShowInplace( const uno::Reference< awt::XWindowPeer >& xPar xHatchWindow->setController( uno::Reference< embed::XHatchWindowController >( static_cast< embed::XHatchWindowController* >( this ) ) ); - xMyParent = xHatchWinPeer; + xMyParent = std::move(xHatchWinPeer); } else { @@ -453,8 +453,8 @@ bool DocumentHolder::ShowInplace( const uno::Reference< awt::XWindowPeer >& xPar // the call will create, initialize the frame, and register it in the parent m_xFrame.set( xFrameFact->createInstanceWithArguments( aArgs ), uno::UNO_QUERY_THROW ); - m_xHatchWindow = xHWindow; - m_xOwnWindow = xOwnWindow; + m_xHatchWindow = std::move(xHWindow); + m_xOwnWindow = std::move(xOwnWindow); if ( !SetFrameLMVisibility( m_xFrame, false ) ) { diff --git a/embeddedobj/source/msole/olepersist.cxx b/embeddedobj/source/msole/olepersist.cxx index 062ceb4adcf5..bb65e627d9e6 100644 --- a/embeddedobj/source/msole/olepersist.cxx +++ b/embeddedobj/source/msole/olepersist.cxx @@ -1241,7 +1241,7 @@ void OleEmbeddedObject::StoreToLocation_Impl( if ( bSaveAs ) { m_bWaitSaveCompleted = true; - m_xNewObjectStream = xTargetStream; + m_xNewObjectStream = std::move(xTargetStream); m_xNewParentStorage = xStorage; m_aNewEntryName = sEntName; m_bNewVisReplInStream = bStoreVis; @@ -1252,7 +1252,7 @@ void OleEmbeddedObject::StoreToLocation_Impl( if ( bNeedLocalCache ) m_xNewCachedVisRepl = GetNewFilledTempStream_Impl( xCachedVisualRepresentation->getInputStream() ); else - m_xNewCachedVisRepl = xCachedVisualRepresentation; + m_xNewCachedVisRepl = std::move(xCachedVisualRepresentation); } // TODO: register listeners for storages above, in case they are disposed diff --git a/filter/source/xsltdialog/xmlfiltertestdialog.cxx b/filter/source/xsltdialog/xmlfiltertestdialog.cxx index 45f766dd1231..edf07421e956 100644 --- a/filter/source/xsltdialog/xmlfiltertestdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltertestdialog.cxx @@ -646,7 +646,7 @@ Reference< XComponent > XMLFilterTestDialog::getFrontMostDocument( const OUStrin Reference< XComponent > xTest( mxLastFocusModel ); if( checkComponent( xTest, rServiceName ) ) { - xRet = xTest; + xRet = std::move(xTest); } else { @@ -654,7 +654,7 @@ Reference< XComponent > XMLFilterTestDialog::getFrontMostDocument( const OUStrin if( checkComponent( xTest, rServiceName ) ) { - xRet = xTest; + xRet = std::move(xTest); } else { diff --git a/forms/source/xforms/model.cxx b/forms/source/xforms/model.cxx index 04db24d1fb4c..105f7f449963 100644 --- a/forms/source/xforms/model.cxx +++ b/forms/source/xforms/model.cxx @@ -272,7 +272,7 @@ bool Model::setSimpleContent( const XNode_t& xConstNode, UNO_QUERY_THROW ); xNode->appendChild( xChild ); } - xNode = xChild; + xNode = std::move(xChild); OSL_ENSURE( xNode.is() && xNode->getNodeType() == NodeType_TEXT_NODE, diff --git a/framework/source/accelerators/documentacceleratorconfiguration.cxx b/framework/source/accelerators/documentacceleratorconfiguration.cxx index 729136823d1d..48155a2f6408 100644 --- a/framework/source/accelerators/documentacceleratorconfiguration.cxx +++ b/framework/source/accelerators/documentacceleratorconfiguration.cxx @@ -97,7 +97,7 @@ DocumentAcceleratorConfiguration::DocumentAcceleratorConfiguration( css::uno::Reference<css::embed::XStorage> xRoot; if (lArguments.getLength() == 1 && (lArguments[0] >>= xRoot)) { - m_xDocumentRoot = xRoot; + m_xDocumentRoot = std::move(xRoot); } else { diff --git a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx index 66cc6a3c2d52..2c8376f06cd4 100644 --- a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx +++ b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx @@ -795,7 +795,7 @@ void ModuleUIConfigurationManager::impl_Initialize() m_aUIElements[LAYER_USERDEFINED][i].nElementType = i; m_aUIElements[LAYER_USERDEFINED][i].bModified = false; - m_aUIElements[LAYER_USERDEFINED][i].xStorage = xElementTypeStorage; + m_aUIElements[LAYER_USERDEFINED][i].xStorage = std::move(xElementTypeStorage); } } diff --git a/framework/source/uielement/generictoolbarcontroller.cxx b/framework/source/uielement/generictoolbarcontroller.cxx index e672ce7d4ca8..8e72962018d8 100644 --- a/framework/source/uielement/generictoolbarcontroller.cxx +++ b/framework/source/uielement/generictoolbarcontroller.cxx @@ -166,7 +166,7 @@ void SAL_CALL GenericToolbarController::execute( sal_Int16 KeyModifier ) // Execute dispatch asynchronously ExecuteInfo* pExecuteInfo = new ExecuteInfo; - pExecuteInfo->xDispatch = xDispatch; + pExecuteInfo->xDispatch = std::move(xDispatch); pExecuteInfo->aTargetURL = std::move(aTargetURL); // Add key modifier to argument list pExecuteInfo->aArgs = { comphelper::makePropertyValue(u"KeyModifier"_ustr, KeyModifier) }; diff --git a/oox/source/drawingml/misccontexts.cxx b/oox/source/drawingml/misccontexts.cxx index a9070ae8da30..bca0a459171f 100644 --- a/oox/source/drawingml/misccontexts.cxx +++ b/oox/source/drawingml/misccontexts.cxx @@ -632,7 +632,7 @@ ContextHandlerRef BlipExtensionContext::onCreateContext(sal_Int32 nElement, cons // Overwrite the fill graphic with the one containing SVG mrBlipProps.mxFillGraphic = xGraphic; if (mpBlipFill) - mpBlipFill->mxGraphic = xGraphic; + mpBlipFill->mxGraphic = std::move(xGraphic); } } // TODO - link diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx index f01c4b90a7a6..991a37c99be0 100644 --- a/oox/source/drawingml/shape.cxx +++ b/oox/source/drawingml/shape.cxx @@ -506,7 +506,7 @@ void Shape::addShape( { // Our drawingml::Shape is in the list of an internal name, remember the now // inserted XShape. - it->second = xShape; + it->second = std::move(xShape); } } } diff --git a/package/source/xstor/owriteablestream.cxx b/package/source/xstor/owriteablestream.cxx index 40134c28a9c3..3a5f5253f5c5 100644 --- a/package/source/xstor/owriteablestream.cxx +++ b/package/source/xstor/owriteablestream.cxx @@ -801,7 +801,7 @@ void OWriteStream_Impl::Commit() } // the stream should be free soon, after package is stored - m_xPackageStream = xNewPackageStream; + m_xPackageStream = std::move(xNewPackageStream); m_bHasDataToFlush = false; m_bFlushed = true; // will allow to use transaction on stream level if will need it } diff --git a/package/source/zippackage/ZipPackageStream.cxx b/package/source/zippackage/ZipPackageStream.cxx index 536f6658edb1..cc365b63bc50 100644 --- a/package/source/zippackage/ZipPackageStream.cxx +++ b/package/source/zippackage/ZipPackageStream.cxx @@ -1123,7 +1123,7 @@ void SAL_CALL ZipPackageStream::setRawStream( const uno::Reference< io::XInputSt uno::Reference< io::XSeekable > xSeek( xNewStream, UNO_QUERY_THROW ); xSeek->seek( 0 ); uno::Reference< io::XInputStream > xOldStream = m_xStream; - m_xStream = xNewStream; + m_xStream = std::move(xNewStream); if ( !ParsePackageRawStream() ) { m_xStream = std::move(xOldStream); diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx index d21e40262464..a60b65e64ef1 100644 --- a/reportdesign/source/ui/report/ReportController.cxx +++ b/reportdesign/source/ui/report/ReportController.cxx @@ -2517,7 +2517,7 @@ sal_Bool SAL_CALL OReportController::attachModel(const uno::Reference< frame::XM if ( !xTestSuppUndo.is() ) return false; - m_xReportDefinition = xReportDefinition; + m_xReportDefinition = std::move(xReportDefinition); return true; } diff --git a/sc/source/filter/oox/pivotcachebuffer.cxx b/sc/source/filter/oox/pivotcachebuffer.cxx index 3af082b3c10e..20d0cbd62b83 100644 --- a/sc/source/filter/oox/pivotcachebuffer.cxx +++ b/sc/source/filter/oox/pivotcachebuffer.cxx @@ -714,7 +714,7 @@ OUString PivotCacheField::createParentGroupField( const Reference< XDataPilotFie Reference< XDataPilotField > xDPNewField = xDPGrouping->createNameGroup( comphelper::containerToSequence( aMembers ) ); SAL_WARN_IF( xDPGroupField.is() == xDPNewField.is(), "sc", "PivotCacheField::createParentGroupField - missing group field" ); if( !xDPGroupField.is() ) - xDPGroupField = xDPNewField; + xDPGroupField = std::move(xDPNewField); // get current grouping info DataPilotFieldGroupInfo aGroupInfo; diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx index 1548e54a9d84..0186b53f1b61 100644 --- a/sd/source/ui/unoidl/unomodel.cxx +++ b/sd/source/ui/unoidl/unomodel.cxx @@ -638,7 +638,7 @@ AnimationsExporter::AnimationsExporter(::tools::JsonWriter& rWriter, } } if (mbHasEffects) - mxRootNode = xRootNode; + mxRootNode = std::move(xRootNode); } catch (const RuntimeException&) { diff --git a/sfx2/source/doc/SfxDocumentMetaData.cxx b/sfx2/source/doc/SfxDocumentMetaData.cxx index 5f19e4988d8f..ea8d924c9d5a 100644 --- a/sfx2/source/doc/SfxDocumentMetaData.cxx +++ b/sfx2/source/doc/SfxDocumentMetaData.cxx @@ -692,7 +692,7 @@ SfxDocumentMetaData::setMetaText(std::unique_lock<std::mutex>& rGuard, const OUS if (xNode.is()) { // delete m_xParent->removeChild(xNode); xNode.clear(); - m_meta[name] = xNode; + m_meta[name] = std::move(xNode); return true; } else { return false; @@ -987,7 +987,7 @@ SfxDocumentMetaData::updateElement(std::unique_lock<std::mutex>& /*rGuard*/, con } m_xParent->appendChild(xNode); } - m_meta[name] = xNode; + m_meta[name] = std::move(xNode); } catch (const css::xml::dom::DOMException &) { css::uno::Any anyEx = cppu::getCaughtException(); throw css::lang::WrappedTargetRuntimeException( @@ -1201,7 +1201,7 @@ void SfxDocumentMetaData::init( i_xDoc->createElementNS(s_nsODF, sOfficeMeta), css::uno::UNO_QUERY_THROW); xRElem->appendChild(xParent); - m_xParent = xParent; + m_xParent = std::move(xParent); } catch (const css::xml::dom::DOMException &) { css::uno::Any anyEx = cppu::getCaughtException(); throw css::lang::WrappedTargetRuntimeException( @@ -1220,11 +1220,10 @@ void SfxDocumentMetaData::init( // document, it will contain the duplicates unchanged. // The ODF spec says that handling multiple occurrences is // application-specific. - css::uno::Reference<css::xml::dom::XNode> xNode = - getChildNodeByName(m_xParent, name); + // Do not create an empty element if it is missing; // for certain elements, such as dateTime, this would be invalid - m_meta[name] = xNode; + m_meta[name] = getChildNodeByName(m_xParent, name); } // select nodes for elements of which we handle all occurrences diff --git a/stoc/source/inspect/introspection.cxx b/stoc/source/inspect/introspection.cxx index c8cfa1b63150..6d9a54313923 100644 --- a/stoc/source/inspect/introspection.cxx +++ b/stoc/source/inspect/introspection.cxx @@ -874,11 +874,11 @@ void ImplIntrospectionAccess::cacheXIndexContainer(const std::unique_lock<std::m { if( !mxObjIndexContainer.is() ) - mxObjIndexContainer = xIndexContainer; + mxObjIndexContainer = std::move(xIndexContainer); if( !mxObjIndexReplace.is() ) - mxObjIndexReplace = xIndexReplace; + mxObjIndexReplace = std::move(xIndexReplace); if( !mxObjIndexAccess.is() ) - mxObjIndexAccess = xIndexAccess; + mxObjIndexAccess = std::move(xIndexAccess); } } diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx index e43c8606c9ad..8fd0b05635d5 100644 --- a/svx/source/form/fmshimp.cxx +++ b/svx/source/form/fmshimp.cxx @@ -1971,7 +1971,7 @@ bool FmXFormShell::setCurrentSelection_Lock( InterfaceBag&& _rSelection ) if ( !xNewCurrentForm.is() ) { // the first form we encountered - xNewCurrentForm = xThisRoundsForm; + xNewCurrentForm = std::move(xThisRoundsForm); } else if ( xNewCurrentForm != xThisRoundsForm ) { // different forms -> no "current form" at all @@ -2215,7 +2215,7 @@ IMPL_LINK(FmXFormShell, OnFoundData_Lock, FmFoundRecordInformation&, rfriWhere, DBG_ASSERT(xModelSet.is(), "FmXFormShell::OnFoundData : invalid control model (no property set) !"); xModelSet->setPropertyValue( FM_PROP_ALWAYSSHOWCURSOR, Any( true ) ); xModelSet->setPropertyValue( FM_PROP_CURSORCOLOR, Any( COL_LIGHTRED ) ); - m_xLastGridFound = xControlModel; + m_xLastGridFound = std::move(xControlModel); if ( xGrid.is() ) xGrid->setCurrentColumnPosition(static_cast<sal_Int16>(nGridColumn)); @@ -2441,7 +2441,7 @@ IMPL_LINK(FmXFormShell, OnSearchContextRequest_Lock, FmSearchContext&, rfmscCont return 0; } - rfmscContextInfo.xCursor = xIter; + rfmscContextInfo.xCursor = std::move(xIter); rfmscContextInfo.strUsedFields = strFieldList; rfmscContextInfo.sFieldDisplayNames = sFieldDisplayNames; diff --git a/svx/source/form/formcontroller.cxx b/svx/source/form/formcontroller.cxx index fa45f354ed12..16d7d3389048 100644 --- a/svx/source/form/formcontroller.cxx +++ b/svx/source/form/formcontroller.cxx @@ -366,7 +366,7 @@ void ColumnInfoCache::initializeControls( const Sequence< Reference< XControl > if ( gridCol < gridColCount ) { // found a grid column which is bound to the given - rCol.xFirstGridWithInputRequiredColumn = xGrid; + rCol.xFirstGridWithInputRequiredColumn = std::move(xGrid); rCol.nRequiredGridColumn = gridCol; break; } diff --git a/sw/source/core/edit/edfcol.cxx b/sw/source/core/edit/edfcol.cxx index 43b08d1086f5..bc14b129e81d 100644 --- a/sw/source/core/edit/edfcol.cxx +++ b/sw/source/core/edit/edfcol.cxx @@ -569,7 +569,7 @@ uno::Reference<text::XTextField> lcl_FindParagraphClassificationField(const rtl: uno::Reference<text::XTextField> xField(xServiceInfo, uno::UNO_QUERY); if (lcl_IsParagraphClassificationField(xModel, xField, sKey)) { - xTextField = xField; + xTextField = std::move(xField); break; } } diff --git a/sw/source/uibase/uno/unomailmerge.cxx b/sw/source/uibase/uno/unomailmerge.cxx index 86d983b27ae1..1ad9fb07f27a 100644 --- a/sw/source/uibase/uno/unomailmerge.cxx +++ b/sw/source/uibase/uno/unomailmerge.cxx @@ -161,7 +161,7 @@ static bool LoadFromURL_impl( if (bClose) CloseModelAndDocSh( rxModel, rxDocSh ); // set new stuff - rxModel = xTmpModel; + rxModel = std::move(xTmpModel); rxDocSh = pTmpDocShell; bRes = true; } diff --git a/sw/source/writerfilter/rtftok/rtfsdrimport.cxx b/sw/source/writerfilter/rtftok/rtfsdrimport.cxx index 961cd5186640..09aabf47fd1c 100644 --- a/sw/source/writerfilter/rtftok/rtfsdrimport.cxx +++ b/sw/source/writerfilter/rtftok/rtfsdrimport.cxx @@ -1163,7 +1163,7 @@ void RTFSdrImport::resolve(RTFShape& rShape, bool bClose, ShapeOrPict const shap // the outer one. rShape.getProperties().clear(); - m_xShape = xShape; + m_xShape = std::move(xShape); } void RTFSdrImport::close() { m_rImport.Mapper().endShape(); } diff --git a/toolkit/source/controls/dialogcontrol.cxx b/toolkit/source/controls/dialogcontrol.cxx index 862b78027ed7..d123194dfcfc 100644 --- a/toolkit/source/controls/dialogcontrol.cxx +++ b/toolkit/source/controls/dialogcontrol.cxx @@ -83,7 +83,7 @@ public: Reference< T > xElement; if ( ! ( aElement >>= xElement ) ) throw IllegalArgumentException(); - it->second = xElement; + it->second = std::move(xElement); } virtual Any SAL_CALL getByName( const OUString& aName ) override { diff --git a/ucb/source/cacher/cacheddynamicresultsetstub.cxx b/ucb/source/cacher/cacheddynamicresultsetstub.cxx index f5decb5e5506..1904a7be0395 100644 --- a/ucb/source/cacher/cacheddynamicresultsetstub.cxx +++ b/ucb/source/cacher/cacheddynamicresultsetstub.cxx @@ -216,7 +216,7 @@ void SAL_CALL CachedDynamicResultSetStubFactory xSortFactory->createSortedDynamicResultSet( Source, SortingInfo, CompareFactory ) ); if( xSorted.is() ) - xSource = xSorted; + xSource = std::move(xSorted); } } diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx index b28480816a6f..587700619976 100644 --- a/xmloff/source/core/xmlexp.cxx +++ b/xmloff/source/core/xmlexp.cxx @@ -663,18 +663,18 @@ void SAL_CALL SvXMLExport::initialize( const uno::Sequence< uno::Any >& aArgumen // status indicator uno::Reference<task::XStatusIndicator> xTmpStatus( xValue, UNO_QUERY ); if ( xTmpStatus.is() ) - mxStatusIndicator = xTmpStatus; + mxStatusIndicator = std::move(xTmpStatus); // graphic storage handler uno::Reference<document::XGraphicStorageHandler> xGraphicStorageHandler(xValue, UNO_QUERY); if (xGraphicStorageHandler.is()) - mxGraphicStorageHandler = xGraphicStorageHandler; + mxGraphicStorageHandler = std::move(xGraphicStorageHandler); // object resolver uno::Reference<document::XEmbeddedObjectResolver> xTmpObjectResolver( xValue, UNO_QUERY ); if ( xTmpObjectResolver.is() ) - mxEmbeddedResolver = xTmpObjectResolver; + mxEmbeddedResolver = std::move(xTmpObjectResolver); // document handler uno::Reference<xml::sax::XDocumentHandler> xTmpDocHandler( diff --git a/xmloff/source/text/XMLChangedRegionImportContext.cxx b/xmloff/source/text/XMLChangedRegionImportContext.cxx index 8ee5b7ae6e98..9b0ecbc4b866 100644 --- a/xmloff/source/text/XMLChangedRegionImportContext.cxx +++ b/xmloff/source/text/XMLChangedRegionImportContext.cxx @@ -166,7 +166,7 @@ void XMLChangedRegionImportContext::UseRedlineText() if (xNewCursor.is()) { // save old cursor and install new one - xOldCursor = xCursor; + xOldCursor = std::move(xCursor); rHelper->SetCursor( xNewCursor ); } // else: leave as is diff --git a/xmloff/source/text/txtflde.cxx b/xmloff/source/text/txtflde.cxx index d13c54c9707e..655062774c16 100644 --- a/xmloff/source/text/txtflde.cxx +++ b/xmloff/source/text/txtflde.cxx @@ -170,7 +170,7 @@ uno::Reference<text::XText> GetToplevelText(const uno::Reference<text::XText>& x uno::Reference<text::XText> xParent; if (xPropertySet->getPropertyValue(u"ParentText"_ustr) >>= xParent) - xRet = xParent; + xRet = std::move(xParent); else return xRet; }