scaddins/source/analysis/analysishelper.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 79e77a81fd3302321698ff1ecd92bc67a90e3382
Author: Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Wed Oct 23 13:50:16 2024 +0200
Commit: Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Wed Oct 23 15:52:52 2024 +0200
tdf#163486: PVS: enum type as bool
V768 The variable 'eS' is of enum type. It is odd that it is used as a
variable of a Boolean-type.
Change-Id: I959f58e80cd0a2d82e6c9fffe140a442cf4dbb0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175477
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
diff --git a/scaddins/source/analysis/analysishelper.cxx
b/scaddins/source/analysis/analysishelper.cxx
index e2ad9e2a7557..64277a2053c9 100644
--- a/scaddins/source/analysis/analysishelper.cxx
+++ b/scaddins/source/analysis/analysishelper.cxx
@@ -775,7 +775,7 @@ bool ParseDouble( const sal_Unicode*& rp, double& rRet )
sal_Int32 nMaxExp = 307;
sal_uInt16 nDigCnt = 18; // max. number of digits to read in,
rest doesn't matter
- enum State { S_End = 0, S_Sign, S_IntStart, S_Int, S_IgnoreIntDigs,
S_Frac, S_IgnoreFracDigs, S_ExpSign, S_Exp };
+ enum State { S_End, S_Sign, S_IntStart, S_Int, S_IgnoreIntDigs, S_Frac,
S_IgnoreFracDigs, S_ExpSign, S_Exp };
State eS = S_Sign;
@@ -785,7 +785,7 @@ bool ParseDouble( const sal_Unicode*& rp, double& rRet )
const sal_Unicode* p = rp;
sal_Unicode c;
- while( eS )
+ while( eS != S_End )
{
c = *p;
switch( eS )
