vcl/source/gdi/FileDefinitionWidgetDraw.cxx | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)
New commits: commit dd41459378bca78a18f32e61bfac77aa48fabb8d Author: Bogdan Buzea <buzea.bog...@libreoffice.org> AuthorDate: Sun Oct 20 11:50:15 2024 +0200 Commit: Xisco Fauli <xiscofa...@libreoffice.org> CommitDate: Mon Oct 21 01:25:45 2024 +0200 tdf#163486: PVS: Identical branches V1037 Two or more case-branches perform the same actions. Check lines: 156, 164 V1037 Two or more case-branches perform the same actions. Check lines: 898, 908 Change-Id: Iec6ceda7c4506317860950857e516991d8a507a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175238 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org> diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx index 0caee37852b8..fd1205c9d4e9 100644 --- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx +++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx @@ -152,14 +152,11 @@ bool FileDefinitionWidgetDraw::isNativeControlSupported(ControlType eType, Contr case ControlType::Radiobutton: case ControlType::Checkbox: return true; - case ControlType::Combobox: - if (ePart == ControlPart::HasBackgroundTexture) - return false; - return true; case ControlType::Editbox: case ControlType::EditboxNoBorder: case ControlType::MultilineEditbox: return true; + case ControlType::Combobox: case ControlType::Listbox: if (ePart == ControlPart::HasBackgroundTexture) return false; @@ -894,15 +891,6 @@ bool FileDefinitionWidgetDraw::getNativeControlRegion( } break; case ControlType::Checkbox: - { - auto const& pPart = m_pWidgetDefinition->getDefinition(eType, ControlPart::Entire); - if (!pPart) - return false; - - Size aSize(pPart->mnWidth, pPart->mnHeight); - rNativeContentRegion = tools::Rectangle(Point(), aSize); - return true; - } case ControlType::Radiobutton: { auto const& pPart = m_pWidgetDefinition->getDefinition(eType, ControlPart::Entire);