core.git: basctl/source

[Bogdan Buzea (via logerrit)]

 basctl/source/basicide/basides1.cxx |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

New commits:
commit ba08d8f3a9b4421556284b76ed0635a8a62d7567
Author:     Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Fri Oct 18 17:39:10 2024 +0200
Commit:     David Gilbert <freedesk...@treblig.org>
CommitDate: Sat Oct 19 19:49:40 2024 +0200

    tdf#163486: PVS: Identical branches
    
    
    Change-Id: If000f1e0bb01c6d551ef970edae8058e8020a202
    V1037: Two or more case-branches perform the same actions. Check lines: 
917, 945
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175152
    Tested-by: Jenkins
    Reviewed-by: David Gilbert <freedesk...@treblig.org>

diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
index e42c645ee9d8..1417b3799fb6 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -913,6 +913,8 @@ void Shell::GetState(SfxItemSet &rSet)
             }
             break;
             case SID_DOCINFO:
+            case SID_NEWWINDOW:
+            case SID_SAVEASDOC:
             {
                 rSet.DisableItem( nWh );
             }
@@ -939,12 +941,6 @@ void Shell::GetState(SfxItemSet &rSet)
                     rSet.DisableItem( nWh );
             }
             break;
-            case SID_NEWWINDOW:
-            case SID_SAVEASDOC:
-            {
-                rSet.DisableItem( nWh );
-            }
-            break;
             case SID_SIGNATURE:
             {
                 SignatureState nState = SignatureState::NOSIGNATURES;