connectivity/source/commontools/FValue.cxx |    6 ------
 1 file changed, 6 deletions(-)

New commits:
commit d8e10f7d94365b32c29e9fc8a2a0901528888daf
Author:     Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Fri Oct 18 06:44:17 2024 +0200
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Fri Oct 18 10:27:06 2024 +0200

    tdf#163486: PVS: Identical branches
    
    Change-Id: I27de9f10b54478fa265efcb2fa35b8c7e16666f2
    V1037: Two or more case-branches perform the same actions. Check lines: 821 
and 827, 1962 and 1967, 2006 and 2011.
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175052
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
    Tested-by: Jenkins

diff --git a/connectivity/source/commontools/FValue.cxx 
b/connectivity/source/commontools/FValue.cxx
index 799074d4207b..9ec39d8dd94d 100644
--- a/connectivity/source/commontools/FValue.cxx
+++ b/connectivity/source/commontools/FValue.cxx
@@ -818,8 +818,6 @@ bool ORowSetValue::operator==(const ORowSetValue& _rRH) 
const
         case DataType::BINARY:
         case DataType::VARBINARY:
         case DataType::LONGVARBINARY:
-            bRet = false;
-            break;
         case DataType::BLOB:
         case DataType::CLOB:
         case DataType::OBJECT:
@@ -1959,8 +1957,6 @@ css::util::Time ORowSetValue::getTime()        const
                 break;
             case DataType::DECIMAL:
             case DataType::NUMERIC:
-                aValue = DBTypeConversion::toTime(getDouble());
-                break;
             case DataType::FLOAT:
             case DataType::DOUBLE:
             case DataType::REAL:
@@ -2003,8 +1999,6 @@ css::util::DateTime ORowSetValue::getDateTime()    const
                 break;
             case DataType::DECIMAL:
             case DataType::NUMERIC:
-                aValue = DBTypeConversion::toDateTime(getDouble());
-                break;
             case DataType::FLOAT:
             case DataType::DOUBLE:
             case DataType::REAL:

Reply via email to