cppuhelper/source/component_context.cxx |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit d2032012612d28a3333863afb684d0ef7c6017c4
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Thu Oct 17 22:24:56 2024 +0200
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Fri Oct 18 08:49:15 2024 +0200

    tdf#163486: PVS: recurring check
    
    V571: Recurring check. The 'if (rEntry.lateInit)' condition was already 
verified in line 400.
    Change-Id: I0a126691213440520bab4b5bd2f2363dfdd57e52
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175103
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/cppuhelper/source/component_context.cxx 
b/cppuhelper/source/component_context.cxx
index 893e484be44d..48d8f2ea579d 100644
--- a/cppuhelper/source/component_context.cxx
+++ b/cppuhelper/source/component_context.cxx
@@ -399,13 +399,9 @@ void 
ComponentContext::disposing(std::unique_lock<std::mutex>& rGuard)
         {
             if (rEntry.lateInit)
             {
-                // late init
-                if (rEntry.lateInit)
-                {
-                    rEntry.value.clear(); // release factory
-                    rEntry.lateInit = false;
-                    continue;
-                }
+                rEntry.value.clear(); // release factory
+                rEntry.lateInit = false;
+                continue;
             }
 
             Reference< lang::XComponent > xComp;

Reply via email to