core.git: 2 commits - connectivity/source sw/source vcl/source

[Caolán McNamara (via logerrit)]

 connectivity/source/drivers/dbase/DIndexIter.cxx |    2 +-
 sw/source/core/doc/docredln.cxx                  |    5 ++++-
 vcl/source/treelist/treelist.cxx                 |    1 +
 3 files changed, 6 insertions(+), 2 deletions(-)

New commits:
commit 5f6cd97220fca3d00647a5a1641f2e3f8b9f3533
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Fri Sep 20 20:18:11 2024 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sat Sep 21 22:34:01 2024 +0200

    cid#1607193 silence Overflowed constant
    
    Change-Id: If3728d8b5410c26637411335ac2bb28a29a55fc3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173749
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/connectivity/source/drivers/dbase/DIndexIter.cxx 
b/connectivity/source/drivers/dbase/DIndexIter.cxx
index 5420d044d5c6..35f5862b1bc2 100644
--- a/connectivity/source/drivers/dbase/DIndexIter.cxx
+++ b/connectivity/source/drivers/dbase/DIndexIter.cxx
@@ -109,7 +109,7 @@ ONDXKey* OIndexIterator::GetFirstKey(ONDXPage* pPage, const 
OOperand& rKey)
             pFoundKey = nullptr;
 
         m_aCurLeaf = pPage;
-        m_nCurNode = pFoundKey ? i : i - 1;
+        m_nCurNode = pFoundKey ? i : sal_uInt16(i - 1);
     }
     return pFoundKey;
 }
commit 08db0792562f23be138c56e347a6c3121ad1512c
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Fri Aug 30 09:26:32 2024 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sat Sep 21 22:33:50 2024 +0200

    cid#1607013 silence Overflowed return value
    
    and
    
    cid#1607569 Overflowed return value
    
    Change-Id: Ie83b1e4c9942e5d74b23c5ef00032d0a8721d982
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173742
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index f6ef057d4ae5..c1b9d8f9d74a 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -778,11 +778,14 @@ SwRedlineTable::size_type SwRedlineTable::FindPrevSeqNo( 
sal_uInt16 nSeqNo, size
 
         ++nSttPos;
         while( nSttPos > nEnd )
-            if( nSeqNo == operator[]( --nSttPos )->GetSeqNo() )
+        {
+            --nSttPos;
+            if( nSeqNo == operator[](nSttPos)->GetSeqNo() )
             {
                 nRet = nSttPos;
                 break;
             }
+        }
     }
     return nRet;
 }
diff --git a/vcl/source/treelist/treelist.cxx b/vcl/source/treelist/treelist.cxx
index 3c9079cb68cb..50003c621fe7 100644
--- a/vcl/source/treelist/treelist.cxx
+++ b/vcl/source/treelist/treelist.cxx
@@ -431,6 +431,7 @@ sal_uInt32 SvTreeList::GetVisibleChildCount(const 
SvListView* pView, SvTreeListE
         pParent = NextVisible( pView, pParent, &nActDepth );
         nCount++;
     } while( pParent && nRefDepth < nActDepth );
+    assert(nCount >= 1 && "given do...while");
     nCount--;
     return nCount;
 }