configure.ac | 1 -
1 file changed, 1 deletion(-)
New commits:
commit 80d4e666dde9954a1f7387e7833e8a52d24e22df
Author: Stephan Bergmann <stephan.bergm...@allotropia.de>
AuthorDate: Wed Sep 18 13:53:08 2024 +0200
Commit: Stephan Bergmann <stephan.bergm...@allotropia.de>
CommitDate: Wed Sep 18 22:10:50 2024 +0200
Do not hardcode --with-locales=en for Emscripten build
...which had been done in 7a9e4c4ba8c6b8e068005f3831b989e3c929e8eb "WASM add
strip flags to configure.ac", but without giving a rationale. For
--enable-assert-always-abort builds, it could have caused the
> assert(pUpperMonthText[0] == "JANUAR");
in ImpSvNumberInputScan::GetMonth (svl/source/numbers/zforfind.cxx) to fire
when
running in a German-locale browser, because the rule to generate the
DISABLE_DYNLOADING-specific localedata_static.hxx in
i18npool/Library_i18npool.mk then only included English-locale fallback
locale data, so pUpperMonthText[0] was always the English "JANUARY",
regardless
of locale used.
With with_locales left uninitialized here, the generated
localedata_static.hxx
now includes the full set of locale data. Which comes with a small
increase in
size, though: For one non-debug build scenario, sofice.data stayed at ca.
68M
but soffice.wasm grew from ca. 138M to ca. 143M.
Change-Id: I46dae3f5c795ae30fc44d3ac4cb8dd162cd72966
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173619
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de>
diff --git a/configure.ac b/configure.ac
index 5597a9d6f198..9d3c459b8559 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3265,7 +3265,6 @@ if test "$enable_wasm_strip" = "yes"; then
with_x=no
test "${with_fonts+set}" = set || with_fonts=yes
- test "${with_locales+set}" = set || with_locales=en
AC_DEFINE(ENABLE_WASM_STRIP_ACCESSIBILITY)
AC_DEFINE(ENABLE_WASM_STRIP_WRITER)
