winaccessibility/source/service/AccContainerEventListener.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e77031f370ff99de10d3dd48734e1d831a6d7fd9
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Tue Sep 10 08:08:30 2024 +0100
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Tue Sep 10 12:34:36 2024 +0200
wina11y: Drop suspicious fallthrough case
Don't fallthrough from the `AccessibleEventId::TEXT_CHANGED`
case to the `AccessibleEventId::VISIBLE_DATA_CHANGED` one.
commit 3ec901fab2cb3e1a1c8222498761e72c28175bd3
Date: Wed May 25 08:38:19 2016 +0200
Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???" (in
Win-only)
had already added a TODO comment.
The IAccessible2 IDL describes `IA2_EVENT_VISIBLE_DATA_CHANGED` like
this:
/** A visible data event indicates the change of the visual appearance
of an accessible object. This includes for example most of the
attributes available via the IAccessibleComponent interface.
*/
IA2_EVENT_VISIBLE_DATA_CHANGED,
I see no real reason to always send that event as well
when text is updated.
In particular, since the description of the UNO equivalent
`AccessibleEventId::VISIBLE_DATA_CHANGED` matches the IA2
one very closely, it should explicitly be sent by the corresponding
XAccessible(Context) implementation in addition to the
`AccessibleEventId::TEXT_CHANGED` event if there are cases where
both events should actually be emitted on the platform layer
rather than being implicitly added in the platform-specific a11y bridge.
Change-Id: I00402e08278b0b0c70f8d784939344a952dfa668
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173120
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
diff --git a/winaccessibility/source/service/AccContainerEventListener.cxx
b/winaccessibility/source/service/AccContainerEventListener.cxx
index 88160df6995a..7a8ca14a1407 100644
--- a/winaccessibility/source/service/AccContainerEventListener.cxx
+++ b/winaccessibility/source/service/AccContainerEventListener.cxx
@@ -60,7 +60,7 @@ void AccContainerEventListener::notifyEvent( const
css::accessibility::Accessib
break;
case AccessibleEventId::TEXT_CHANGED:
HandleTextChangedEvent(aEvent.OldValue, aEvent.NewValue);
- [[fallthrough]]; //TODO ???
+ break;
case AccessibleEventId::VISIBLE_DATA_CHANGED:
HandleVisibleDataChangedEvent();
break;
