sw/source/uibase/utlui/content.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e7e89eaf687310a31762ef5d325c22d7cc259a0b
Author:     Miklos Vajna <vmik...@collabora.com>
AuthorDate: Wed Aug 28 12:04:15 2024 +0200
Commit:     Miklos Vajna <vmik...@collabora.com>
CommitDate: Wed Aug 28 15:32:21 2024 +0200

    sw: fix uninitialized read in SwContentTree::IsDeletable()
    
    Seen while running online.git unit-perf with asan:
    
    > sw/source/uibase/utlui/content.cxx:6203:17: runtime error: load of value 
48, which is not a valid value for type 'bool'
    
    And indeed SwDoc::HasTableAnyProtection() may leave this out parameter
    uninitialized.
    
    Change-Id: Iaaf08469580510b1dbcbad999c141884a8d8a4dc
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172528
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmik...@collabora.com>

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 9c7f1acff11e..c571cbfa6c61 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -6198,7 +6198,7 @@ bool SwContentTree::IsDeletable(const SwContent* pContent)
     // table
     if (eContentTypeId == ContentTypeId::TABLE)
     {
-        bool bFull;
+        bool bFull = false;
         m_pActiveShell->HasTableAnyProtection(&pContent->GetName(), &bFull);
         return !bFull;
     }

Reply via email to