sc/source/ui/unoobj/chart2uno.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 0a02973962f63da4f96009b61bc8584d8ed87f8d
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Wed Aug 21 22:01:00 2024 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Fri Aug 23 09:29:35 2024 +0200

    don't need to ctor + assign, ctor is enough
    
    Change-Id: I880ec68c907000829b81318fb3bf3eb7ac0109d2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172225
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/sc/source/ui/unoobj/chart2uno.cxx 
b/sc/source/ui/unoobj/chart2uno.cxx
index e0b5ae53c745..e82c5c2f8b6e 100644
--- a/sc/source/ui/unoobj/chart2uno.cxx
+++ b/sc/source/ui/unoobj/chart2uno.cxx
@@ -925,9 +925,7 @@ private:
             return false;
         bool bExternal = ScRefTokenHelper::isExternalRef(pToken);
         sal_uInt16 nFileId = bExternal ? pToken->GetIndex() : 0;
-        svl::SharedString aTabName = svl::SharedString::getEmptyString();
-        if (bExternal)
-            aTabName = pToken->GetString();
+        svl::SharedString aTabName = bExternal ? pToken->GetString() : 
svl::SharedString::getEmptyString();
 
         // In saving to XML, we don't prepend address with '$'.
         setRelative(aData.Ref1);

Reply via email to