sd/source/ui/unoidl/unomodel.cxx | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 8941140c7c458b77626a8303c74afb4489e69bcb
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Thu Aug 22 12:04:30 2024 +0100
Commit: Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Thu Aug 22 13:50:12 2024 +0200
null deref seen in SdXImpressDocument::getPostIts
Change-Id: Idb222476c6d2a6bb8e3ffea528ec4bed0c869ac8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172249
Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 779859a41d54..3eb9a6eb4ac6 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -3439,12 +3439,13 @@ Size SdXImpressDocument::getDocumentSize()
void SdXImpressDocument::getPostIts(::tools::JsonWriter& rJsonWriter)
{
auto commentsNode = rJsonWriter.startNode("comments");
+ if (!mpDoc)
+ return;
// Return annotations on master pages too ?
const sal_uInt16 nMaxPages = mpDoc->GetPageCount();
- SdrPage* pPage;
for (sal_uInt16 nPage = 0; nPage < nMaxPages; ++nPage)
{
- pPage = mpDoc->GetPage(nPage);
+ SdrPage* pPage = mpDoc->GetPage(nPage);
for (auto const& xAnnotation : pPage->getAnnotations())
{
