binaryurp/source/reader.cxx | 2 +-
drawinglayer/source/tools/wmfemfhelper.cxx | 4 ++--
sw/source/core/access/accmap.cxx | 2 +-
ucb/source/ucp/cmis/cmis_content.cxx | 4 ++--
vcl/source/filter/wmf/wmfwr.cxx | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 0aaf0a624859b7f04717b0e8f70476658dd010fe
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Tue Aug 20 09:14:33 2024 +0100
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Tue Aug 20 21:14:25 2024 +0200
doesn't look safe to move this dxarray
given the use of rDXArray after move
.
Change-Id: I27ed26228bb4a43b6dcb6edb4586e0727389dcbb
Change-Id: I66e0a6dd1837e598b620692b405bb32f79470e44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172116
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
Tested-by: Jenkins
diff --git a/drawinglayer/source/tools/wmfemfhelper.cxx
b/drawinglayer/source/tools/wmfemfhelper.cxx
index e5c631e60d7f..86182e1f1234 100644
--- a/drawinglayer/source/tools/wmfemfhelper.cxx
+++ b/drawinglayer/source/tools/wmfemfhelper.cxx
@@ -1124,7 +1124,7 @@ namespace wmfemfhelper
rText,
nTextStart,
nTextLength,
- std::move(rDXArray),
+ std::vector(rDXArray),
std::move(rKashidaArray),
aFontAttribute,
aLocale,
@@ -1170,7 +1170,7 @@ namespace wmfemfhelper
// get text width
double fTextWidth(0.0);
- if(rDXArray.empty())
+ if (rDXArray.empty())
{
fTextWidth = aTextLayouterDevice.getTextWidth(rText,
nTextStart, nTextLength);
}
commit 10b662b8bc0b42303df567603455ab92549284ce
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Tue Aug 20 08:46:37 2024 +0100
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Tue Aug 20 21:14:18 2024 +0200
cid#1557276 COPY_INSTEAD_OF_MOVE
and
cid#1556657 COPY_INSTEAD_OF_MOVE
cid#1556654 COPY_INSTEAD_OF_MOVE
cid#1556397 COPY_INSTEAD_OF_MOVE
cid#1556339 COPY_INSTEAD_OF_MOVE
Change-Id: I20be9764c327ebda9beeb62b54c399998180bfab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172098
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
diff --git a/binaryurp/source/reader.cxx b/binaryurp/source/reader.cxx
index 542787105caa..45276eab9971 100644
--- a/binaryurp/source/reader.cxx
+++ b/binaryurp/source/reader.cxx
@@ -330,7 +330,7 @@ void Reader::readMessage(Unmarshal & unmarshal) {
}
std::unique_ptr< IncomingRequest > req(
new IncomingRequest(
- bridge_, tid, oid, std::move(obj), type, functionId,
synchronous,
+ bridge_, tid, oid, std::move(obj), std::move(type),
functionId, synchronous,
memberTd, bSetter, std::move(inArgs), ccMode, std::move(cc)));
if (synchronous) {
bridge_->incrementActiveCalls();
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index aab6860c38d3..b8ec7b9a293c 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -2302,7 +2302,7 @@ void SwAccessibleMap::InvalidatePosOrSize( const SwFrame
*pFrame,
{
SwAccessibleEvent_Impl aEvent(
SwAccessibleEvent_Impl::POS_CHANGED, xAccImpl.get(),
- aFrameOrObj, rOldBox );
+ std::move(aFrameOrObj), rOldBox );
AppendEvent( aEvent );
}
else
diff --git a/ucb/source/ucp/cmis/cmis_content.cxx
b/ucb/source/ucp/cmis/cmis_content.cxx
index 9dbfe4eab4af..f932de212541 100644
--- a/ucb/source/ucp/cmis/cmis_content.cxx
+++ b/ucb/source/ucp/cmis/cmis_content.cxx
@@ -1081,7 +1081,7 @@ namespace cmis
try
{
pDoc = pPwc->checkIn( rArg.MajorVersion, OUSTR_TO_STDSTR(
rArg.VersionComment ), newProperties,
- pOut, OUSTR_TO_STDSTR( rArg.MimeType ),
OUSTR_TO_STDSTR( rArg.NewTitle ) );
+ std::move(pOut), OUSTR_TO_STDSTR(
rArg.MimeType ), OUSTR_TO_STDSTR( rArg.NewTitle ) );
}
catch ( const libcmis::Exception& e )
{
@@ -1356,7 +1356,7 @@ namespace cmis
copyData( xInputStream, xOutput );
try
{
- document->setContentStream( pOut, OUSTR_TO_STDSTR(
rMimeType ), std::string( ), bReplaceExisting );
+ document->setContentStream( std::move(pOut),
OUSTR_TO_STDSTR( rMimeType ), std::string( ), bReplaceExisting );
}
catch ( const libcmis::Exception& )
{
diff --git a/vcl/source/filter/wmf/wmfwr.cxx b/vcl/source/filter/wmf/wmfwr.cxx
index cf4dfd3509fc..bd4f8b5d8fc6 100644
--- a/vcl/source/filter/wmf/wmfwr.cxx
+++ b/vcl/source/filter/wmf/wmfwr.cxx
@@ -1768,7 +1768,7 @@ bool WMFWriter::WriteWMF( const GDIMetaFile& rMTF,
SvStream& rTargetStream,
aFont.SetCharSet(RTL_TEXTENCODING_MS_1252);
aFont.SetColor( COL_WHITE );
aFont.SetAlignment( ALIGN_BASELINE );
- aDstFont = aSrcFont = aFont;
+ aDstFont = aSrcFont = std::move(aFont);
CreateSelectDeleteFont(aDstFont);
eDstTextAlign = eSrcTextAlign = ALIGN_BASELINE;
