basic/source/sbx/sbxarray.cxx | 2 +-
binaryurp/source/writer.cxx | 2 +-
connectivity/source/drivers/postgresql/pq_connection.cxx | 2 +-
dbaccess/source/ui/querydesign/querycontroller.cxx | 2 +-
filter/source/msfilter/escherex.cxx | 2 +-
oox/source/drawingml/diagram/layoutatomvisitors.cxx | 2 +-
stoc/source/proxy_factory/proxyfac.cxx | 2 +-
svx/source/customshapes/EnhancedCustomShapeFontWork.cxx | 2 +-
svx/source/svdraw/constructhelper.cxx | 6 +++---
svx/source/unodraw/unoshtxt.cxx | 2 +-
tools/source/generic/poly.cxx | 2 +-
11 files changed, 13 insertions(+), 13 deletions(-)
New commits:
commit 437412d79b6b628ab28f15ccdc7aa95fc84cb3c1
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Mon Aug 12 13:12:05 2024 +0100
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Wed Aug 14 09:27:19 2024 +0200
cid#1557980 COPY_INSTEAD_OF_MOVE
and
cid#1557869 COPY_INSTEAD_OF_MOVE
cid#1557807 COPY_INSTEAD_OF_MOVE
cid#1557804 COPY_INSTEAD_OF_MOVE
cid#1557799 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557766 COPY_INSTEAD_OF_MOVE
cid#1557746 COPY_INSTEAD_OF_MOVE
cid#1557737 COPY_INSTEAD_OF_MOVE
Change-Id: I1866c576f525ea697c62e9e0a96890e5fdaa780f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171795
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
diff --git a/basic/source/sbx/sbxarray.cxx b/basic/source/sbx/sbxarray.cxx
index 81ad5bf64ada..6cfbefad5500 100644
--- a/basic/source/sbx/sbxarray.cxx
+++ b/basic/source/sbx/sbxarray.cxx
@@ -346,7 +346,7 @@ bool SbxArray::LoadData( SvStream& rStrm, sal_uInt16
/*nVer*/ )
if( pVar )
{
SbxVariableRef& rRef = GetRef( nIdx );
- rRef = pVar;
+ rRef = std::move(pVar);
}
else
{
diff --git a/binaryurp/source/writer.cxx b/binaryurp/source/writer.cxx
index 9b7a9e59d817..4331a419c751 100644
--- a/binaryurp/source/writer.cxx
+++ b/binaryurp/source/writer.cxx
@@ -335,7 +335,7 @@ void Writer::sendRequest(
break;
}
sendMessage(buf);
- lastType_ = t;
+ lastType_ = std::move(t);
lastOid_ = oid;
lastTid_ = tid;
}
diff --git a/connectivity/source/drivers/postgresql/pq_connection.cxx
b/connectivity/source/drivers/postgresql/pq_connection.cxx
index 156e110c2df2..50c1b54fd698 100644
--- a/connectivity/source/drivers/postgresql/pq_connection.cxx
+++ b/connectivity/source/drivers/postgresql/pq_connection.cxx
@@ -208,7 +208,7 @@ Reference< XPreparedStatement >
Connection::prepareStatement( const OUString& sq
::rtl::ByteSequence id( 16 );
rtl_createUuid( reinterpret_cast<sal_uInt8*>(id.getArray()), nullptr,
false );
m_myStatements[ id ] = Reference< XCloseable > ( stmt );
- stmt->queryAdapter()->addReference( new ClosableReference( id, this ) );
+ stmt->queryAdapter()->addReference(new ClosableReference(std::move(id),
this));
return stmt;
}
diff --git a/dbaccess/source/ui/querydesign/querycontroller.cxx
b/dbaccess/source/ui/querydesign/querycontroller.cxx
index 8c630ea13a0a..b13986769bb4 100644
--- a/dbaccess/source/ui/querydesign/querycontroller.cxx
+++ b/dbaccess/source/ui/querydesign/querycontroller.cxx
@@ -634,7 +634,7 @@ void OQueryController::impl_setViewMode(
::dbtools::SQLExceptionInfo* _pErrorInf
// don't pass &aError here, this would overwrite the error which
the first switchView call
// returned in this location.
if ( _pErrorInfo )
- *_pErrorInfo = aError;
+ *_pErrorInfo = std::move(aError);
else
showError( aError );
}
diff --git a/filter/source/msfilter/escherex.cxx
b/filter/source/msfilter/escherex.cxx
index 4af8d582a6b8..0e251dfac83c 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -1754,7 +1754,7 @@ bool
EscherPropertyContainer::CreateGraphicProperties(const uno::Reference<beans
}
else if (pGraphicProvider && pPicOutStrm && pShapeBoundRect)
// write out embedded graphic
{
- GraphicObject aGraphicObject(aGraphic);
+ GraphicObject aGraphicObject(std::move(aGraphic));
const sal_uInt32
nBlibId(pGraphicProvider->GetBlibID(*pPicOutStrm, aGraphicObject, nullptr,
pGraphicAttr.get()));
if(nBlibId)
diff --git a/oox/source/drawingml/diagram/layoutatomvisitors.cxx
b/oox/source/drawingml/diagram/layoutatomvisitors.cxx
index 1b06fad37fc6..96cbd738ea66 100644
--- a/oox/source/drawingml/diagram/layoutatomvisitors.cxx
+++ b/oox/source/drawingml/diagram/layoutatomvisitors.cxx
@@ -104,7 +104,7 @@ void ShapeCreationVisitor::visit(LayoutNode& rAtom)
xCurrParent->addChild(pShape);
xCurrParent = pShape;
rAtom.addNodeShape(pShape);
- mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] = pShape;
+ mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] =
std::move(pShape);
}
}
else
diff --git a/stoc/source/proxy_factory/proxyfac.cxx
b/stoc/source/proxy_factory/proxyfac.cxx
index 2a0ac98fe297..2d2e44013fe2 100644
--- a/stoc/source/proxy_factory/proxyfac.cxx
+++ b/stoc/source/proxy_factory/proxyfac.cxx
@@ -319,7 +319,7 @@ Any ProxyRoot::queryAggregation( Type const & rType )
UnoInterfaceReference proxy(
// ref count initially 1:
- new binuno_Proxy( this, proxy_target, oid, pTypeDescr
),
+ new binuno_Proxy( this, std::move(proxy_target), oid,
pTypeDescr ),
SAL_NO_ACQUIRE );
uno_ExtEnvironment * uno_env =
m_factory->m_uno_env.get()->pExtEnv;
diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 61029942e7c1..ab33b589b5d2 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -1082,7 +1082,7 @@ static void FitTextOutlinesToShapeOutlines(const
tools::PolyPolygon& aOutlines2d
}
// write back polygon
- rPolyPoly[ i ] = aLocalPoly;
+ rPolyPoly[i] = std::move(aLocalPoly);
}
}
}
diff --git a/svx/source/svdraw/constructhelper.cxx
b/svx/source/svdraw/constructhelper.cxx
index 4eec7dfc815c..24df4232243c 100644
--- a/svx/source/svdraw/constructhelper.cxx
+++ b/svx/source/svdraw/constructhelper.cxx
@@ -145,7 +145,7 @@ void ConstructHelper::SetLineEnds(SfxItemSet& rAttr, const
SdrObject& rObj, sal_
case SID_LINE_SQUARE_ARROW:
{
// connector with arrow end
- rAttr.Put(XLineEndItem(SvxResId(RID_SVXSTR_ARROW), aArrow));
+ rAttr.Put(XLineEndItem(SvxResId(RID_SVXSTR_ARROW),
std::move(aArrow)));
rAttr.Put(XLineEndWidthItem(nWidth));
}
break;
@@ -165,7 +165,7 @@ void ConstructHelper::SetLineEnds(SfxItemSet& rAttr, const
SdrObject& rObj, sal_
case SID_LINE_CIRCLE_ARROW:
{
// circle start
- rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_CIRCLE), aCircle));
+ rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_CIRCLE),
std::move(aCircle)));
rAttr.Put(XLineStartWidthItem(nWidth));
}
break;
@@ -181,7 +181,7 @@ void ConstructHelper::SetLineEnds(SfxItemSet& rAttr, const
SdrObject& rObj, sal_
case SID_LINE_SQUARE_ARROW:
{
// square start
- rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_SQUARE), aSquare));
+ rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_SQUARE),
std::move(aSquare)));
rAttr.Put(XLineStartWidthItem(nWidth));
}
break;
diff --git a/svx/source/unodraw/unoshtxt.cxx b/svx/source/unodraw/unoshtxt.cxx
index afc987da6cf2..9637cb99cd73 100644
--- a/svx/source/unodraw/unoshtxt.cxx
+++ b/svx/source/unodraw/unoshtxt.cxx
@@ -549,7 +549,7 @@ SvxTextForwarder*
SvxTextEditSourceImpl::GetBackgroundTextForwarder()
if (mpText && bTextEditActive && mpObject->IsEmptyPresObj() &&
pTextObj && pTextObj->IsReallyEdited())
{
mpObject->SetEmptyPresObj( false );
- static_cast< SdrTextObj* >(
mpObject)->NbcSetOutlinerParaObjectForText( pOutlinerParaObject, mpText );
+
static_cast<SdrTextObj*>(mpObject)->NbcSetOutlinerParaObjectForText(std::move(pOutlinerParaObject),
mpText);
}
}
else
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 19a6c12a89cf..d3c71bf20f8c 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1070,7 +1070,7 @@ void Polygon::Optimize( PolyOptimizeFlags nOptimizeFlags )
aNewPoly.SetSize( nNewCount );
}
- *this = aNewPoly;
+ *this = std::move(aNewPoly);
}
nSize = mpImplPolygon->mnPoints;
