chart2/source/controller/main/DrawCommandDispatch.cxx | 2 +-
chart2/source/controller/main/ObjectHierarchy.cxx | 2 +-
filter/source/msfilter/escherex.cxx | 4 ++--
sc/source/core/data/document.cxx | 2 +-
svx/source/customshapes/EnhancedCustomShape2d.cxx | 2 +-
svx/source/sdr/primitive2d/sdrattributecreator.cxx | 3 ++-
sw/source/writerfilter/dmapper/TDefTableHandler.cxx | 2 +-
vcl/source/outdev/font.cxx | 2 +-
8 files changed, 10 insertions(+), 9 deletions(-)
New commits:
commit 95bda80c626b4632a90e076060f0669146f7ed44
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Wed Aug 7 13:20:17 2024 +0100
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Wed Aug 7 18:17:50 2024 +0200
cid#1557545 COPY_INSTEAD_OF_MOVE
and
cid#1557556 COPY_INSTEAD_OF_MOVE
cid#1557583 COPY_INSTEAD_OF_MOVE
cid#1557587 COPY_INSTEAD_OF_MOVE
cid#1557591 COPY_INSTEAD_OF_MOVE
cid#1557598 COPY_INSTEAD_OF_MOVE
cid#1557600 COPY_INSTEAD_OF_MOVE
cid#1557653 COPY_INSTEAD_OF_MOVE
Change-Id: I050bed7c088678e1d767d6edbe656eab2aee235d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171591
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
diff --git a/chart2/source/controller/main/DrawCommandDispatch.cxx
b/chart2/source/controller/main/DrawCommandDispatch.cxx
index 516c2d2ec5f3..39e5956ec0e1 100644
--- a/chart2/source/controller/main/DrawCommandDispatch.cxx
+++ b/chart2/source/controller/main/DrawCommandDispatch.cxx
@@ -193,7 +193,7 @@ void DrawCommandDispatch::setLineEnds( SfxItemSet& rAttr )
}
}
- rAttr.Put( XLineEndItem( SvxResId( RID_SVXSTR_ARROW ), aArrow ) );
+ rAttr.Put( XLineEndItem( SvxResId( RID_SVXSTR_ARROW ), std::move(aArrow) )
);
rAttr.Put( XLineEndWidthItem( nWidth ) );
}
diff --git a/chart2/source/controller/main/ObjectHierarchy.cxx
b/chart2/source/controller/main/ObjectHierarchy.cxx
index 7f197a1eea5d..ee8d543571cb 100644
--- a/chart2/source/controller/main/ObjectHierarchy.cxx
+++ b/chart2/source/controller/main/ObjectHierarchy.cxx
@@ -160,7 +160,7 @@ void ObjectHierarchy::createTree( const
rtl::Reference<::chart::ChartModel>& xCh
tChildContainer aSubContainer;
createDiagramTree( aSubContainer, xChartDocument, xDiagram );
if( !aSubContainer.empty() )
- m_aChildMap[ aDiaOID ] = aSubContainer;
+ m_aChildMap[ aDiaOID ] = std::move(aSubContainer);
}
if( !m_bOrderingForElementSelector )
diff --git a/filter/source/msfilter/escherex.cxx
b/filter/source/msfilter/escherex.cxx
index 3387c9bb2fd0..4af8d582a6b8 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -4213,10 +4213,10 @@ sal_uInt32 EscherGraphicProvider::GetBlibID( SvStream&
rPicOutStrm, GraphicObjec
beans::PropertyValue aChunkProp, aFilterProp;
aChunkProp.Name = "msOG";
aChunkProp.Value <<= aGIFSeq;
- uno::Sequence<beans::PropertyValue>
aAdditionalChunkSequence{ aChunkProp };
+ uno::Sequence<beans::PropertyValue>
aAdditionalChunkSequence{ std::move(aChunkProp) };
aFilterProp.Name = "AdditionalChunks";
aFilterProp.Value <<= aAdditionalChunkSequence;
- uno::Sequence<beans::PropertyValue> aFilterData{
aFilterProp };
+ uno::Sequence<beans::PropertyValue> aFilterData{
std::move(aFilterProp) };
nErrCode = rFilter.ExportGraphic( aGraphic, u"",
aStream,
rFilter.GetExportFormatNumberForShortName( u"PNG" ), &aFilterData );
}
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 3830ed410cef..3b9c11157145 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -6564,7 +6564,7 @@ bool ScDocument::GetSparklineGroupInRange(ScRange const&
rRange, std::shared_ptr
}
}
- rGroup = pFoundGroup;
+ rGroup = std::move(pFoundGroup);
return true;
}
diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index f42d90cfd3fb..1a02bd5bd05a 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -2704,7 +2704,7 @@ void EnhancedCustomShape2d::CreateSubPath(
pObj = new SdrPathObj(
mrSdrObjCustomShape.getSdrModelFromSdrObject(),
SdrObjKind::Polygon,
- aNewB2DPolyPolygon);
+ std::move(aNewB2DPolyPolygon));
}
if(bNoStroke)
diff --git a/svx/source/sdr/primitive2d/sdrattributecreator.cxx
b/svx/source/sdr/primitive2d/sdrattributecreator.cxx
index 1d99ee733e74..4a1f2c6560e2 100644
--- a/svx/source/sdr/primitive2d/sdrattributecreator.cxx
+++ b/svx/source/sdr/primitive2d/sdrattributecreator.cxx
@@ -751,7 +751,8 @@ namespace drawinglayer::primitive2d
const attribute::SdrGlowAttribute
aGlow(createNewSdrGlowAttribute(rSet));
const sal_Int32 nSoftEdgeRadius(getSoftEdgeRadius(rSet));
- return attribute::SdrEffectsTextAttribute(aShadow, aText, aGlow,
nSoftEdgeRadius);
+ return attribute::SdrEffectsTextAttribute(aShadow,
std::move(aText),
+ aGlow, nSoftEdgeRadius);
}
attribute::SdrLineEffectsTextAttribute
createNewSdrLineEffectsTextAttribute(
diff --git a/sw/source/writerfilter/dmapper/TDefTableHandler.cxx
b/sw/source/writerfilter/dmapper/TDefTableHandler.cxx
index e676f2a74b38..8a406c4d2726 100644
--- a/sw/source/writerfilter/dmapper/TDefTableHandler.cxx
+++ b/sw/source/writerfilter/dmapper/TDefTableHandler.cxx
@@ -446,7 +446,7 @@ void TDefTableHandler::localResolve(Id rName, const
writerfilter::Reference<Prop
default:;
}
if (!m_aInteropGrabBagName.isEmpty())
- m_aInteropGrabBag = aSavedGrabBag;
+ m_aInteropGrabBag = std::move(aSavedGrabBag);
}
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index 9462bb23acd1..b8a29adcfcc8 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -240,7 +240,7 @@ bool OutputDevice::GetFontCharMap( FontCharMapRef&
rxFontCharMap ) const
if (!xFontCharMap.is())
rxFontCharMap = FontCharMapRef(new FontCharMap());
else
- rxFontCharMap = xFontCharMap;
+ rxFontCharMap = std::move(xFontCharMap);
return !rxFontCharMap->IsDefaultMap();
}
