sal/rtl/strtmpl.hxx | 7 ------- 1 file changed, 7 deletions(-) New commits: commit 6c413b1e75c98175bc2b498e8980150d9f69d13e Author: Mike Kaganski <mike.kagan...@collabora.com> AuthorDate: Wed Jul 31 09:34:20 2024 +0200 Commit: Mike Kaganski <mike.kagan...@collabora.com> CommitDate: Thu Aug 1 07:26:39 2024 +0200
This special case handling is redundant The same check and effect is done in the overload called later. Change-Id: I91baa1f3318d55a3f4ae3564064d8ccf66016853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171286 Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com> Tested-by: Jenkins diff --git a/sal/rtl/strtmpl.hxx b/sal/rtl/strtmpl.hxx index 8c63f1081f9c..154e553ad2d4 100644 --- a/sal/rtl/strtmpl.hxx +++ b/sal/rtl/strtmpl.hxx @@ -1083,13 +1083,6 @@ void newReplaceStrAt(rtl_tString** ppThis, rtl_tString* pStr, sal_Int32 nIndex, nCount = pStr->length - nIndex; } - /* Assign of Str? */ - if (!nCount && (!pNewSubStr || !pNewSubStr->length)) - { - assign(ppThis, pStr); - return; - } - const auto* pNewSubStrBuf = pNewSubStr ? pNewSubStr->buffer : nullptr; const sal_Int32 nNewSubStrLength = pNewSubStr ? pNewSubStr->length : 0; newReplaceStrAt(ppThis, pStr, nIndex, nCount, pNewSubStrBuf, nNewSubStrLength);