connectivity/source/drivers/dbase/dindexnode.cxx | 2 +-
dbaccess/source/core/inc/definitioncontainer.hxx | 2 +-
filter/source/msfilter/msdffimp.cxx | 2 +-
helpcompiler/source/HelpCompiler.cxx | 2 +-
linguistic/source/hyphdsp.cxx | 2 +-
sc/source/ui/unoobj/appluno.cxx | 2 +-
svx/source/svdraw/svdorect.cxx | 2 +-
sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit e571123891968b60333ef161e68e2d45ccc25a94
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Thu Jul 25 21:52:19 2024 +0100
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Fri Jul 26 12:24:39 2024 +0200
cid#1557746 COPY_INSTEAD_OF_MOVE
and
cid#1557751 COPY_INSTEAD_OF_MOVE
cid#1557771 COPY_INSTEAD_OF_MOVE
cid#1557775 COPY_INSTEAD_OF_MOVE
cid#1557786 COPY_INSTEAD_OF_MOVE
cid#1557787 COPY_INSTEAD_OF_MOVE
cid#1557790 COPY_INSTEAD_OF_MOVE
cid#1557793 COPY_INSTEAD_OF_MOVE
cid#1557794 COPY_INSTEAD_OF_MOVE
Change-Id: I1b02b6eca303b1a08975ea8aae7c9dbefbada47f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171061
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
diff --git a/connectivity/source/drivers/dbase/dindexnode.cxx
b/connectivity/source/drivers/dbase/dindexnode.cxx
index d091335f5495..f88f72d445f7 100644
--- a/connectivity/source/drivers/dbase/dindexnode.cxx
+++ b/connectivity/source/drivers/dbase/dindexnode.cxx
@@ -235,7 +235,7 @@ bool ONDXPage::Insert(ONDXNode& rNode, sal_uInt32 nRowsLeft)
ONDXPagePtr aNewRoot = rIndex.CreatePage(nNewPagePos + 1);
aNewRoot->SetChild(this);
- rIndex.m_aRoot = aNewRoot;
+ rIndex.m_aRoot = std::move(aNewRoot);
rIndex.SetRootPos(nNewPagePos + 1);
rIndex.SetPageCount(++nNewPageCount);
}
diff --git a/dbaccess/source/core/inc/definitioncontainer.hxx
b/dbaccess/source/core/inc/definitioncontainer.hxx
index 02f145776c8f..33367a1d2fcc 100644
--- a/dbaccess/source/core/inc/definitioncontainer.hxx
+++ b/dbaccess/source/core/inc/definitioncontainer.hxx
@@ -63,7 +63,7 @@ public:
void erase( const OUString& _rName ) { m_aDefinitions.erase( _rName ); }
void erase( const TContentPtr& _pDefinition );
- void insert( const OUString& _rName, TContentPtr _pDefinition )
+ void insert( const OUString& _rName, const TContentPtr& _pDefinition )
{
m_aDefinitions.emplace( _rName, _pDefinition );
}
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 7350c76c4327..2cc3cda31fb0 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -6686,7 +6686,7 @@ bool SvxMSDffManager::GetBLIPDirect( SvStream&
rBLIPStream, Graphic& rData, tool
if (!aGraphic.IsNone())
{
- rData = aGraphic;
+ rData = std::move(aGraphic);
nRes = ERRCODE_NONE;
}
else
diff --git a/helpcompiler/source/HelpCompiler.cxx
b/helpcompiler/source/HelpCompiler.cxx
index 5e259713d94b..c27954c4cb1a 100644
--- a/helpcompiler/source/HelpCompiler.cxx
+++ b/helpcompiler/source/HelpCompiler.cxx
@@ -474,7 +474,7 @@ void HelpCompiler::compile()
streamTable.appl_keywords = std::move(aparser.keywords);
streamTable.document_path = fileName;
- streamTable.document_title = title;
+ streamTable.document_title = std::move(title);
std::string actMod = module;
if ( !bExtensionMode && !fileName.empty())
diff --git a/linguistic/source/hyphdsp.cxx b/linguistic/source/hyphdsp.cxx
index 6113960d4c9e..677fe74f9ff4 100644
--- a/linguistic/source/hyphdsp.cxx
+++ b/linguistic/source/hyphdsp.cxx
@@ -674,7 +674,7 @@ void HyphenatorDispatcher::SetServiceList( const Locale
&rLocale,
{
auto pTmpEntry = std::make_shared<LangSvcEntries_Hyph>(
rSvcImplNames[0] );
pTmpEntry->aSvcRefs = Sequence< Reference < XHyphenator > >( 1 );
- aSvcMap[ nLanguage ] = pTmpEntry;
+ aSvcMap[ nLanguage ] = std::move(pTmpEntry);
}
}
}
diff --git a/sc/source/ui/unoobj/appluno.cxx b/sc/source/ui/unoobj/appluno.cxx
index c4c6f73dc7a2..bda4c87b1f54 100644
--- a/sc/source/ui/unoobj/appluno.cxx
+++ b/sc/source/ui/unoobj/appluno.cxx
@@ -464,7 +464,7 @@ static void lcl_FillSequence(
uno::Sequence<beans::PropertyValue>& rSequence, co
aArgument.Name = rDesc.maDefArgNames[i];
aArgument.Description = rDesc.maDefArgDescs[i];
aArgument.IsOptional = rDesc.pDefArgFlags[i].bOptional;
- pArgAry[j++] = aArgument;
+ pArgAry[j++] = std::move(aArgument);
}
pArray[4].Value <<= aArgSeq;
}
diff --git a/svx/source/svdraw/svdorect.cxx b/svx/source/svdraw/svdorect.cxx
index fc07af830bfb..d5775ccaa8c4 100644
--- a/svx/source/svdraw/svdorect.cxx
+++ b/svx/source/svdraw/svdorect.cxx
@@ -119,7 +119,7 @@ XPolygon SdrRectObj::ImpCalcXPoly(const tools::Rectangle&
rRect1, tools::Long nR
}
aNewPoly[0]=rRect1.BottomCenter();
aNewPoly[nPointCnt]=aNewPoly[0];
- aXPoly=aNewPoly;
+ aXPoly=std::move(aNewPoly);
// these angles always relate to the top left corner of aRect
if (maGeo.m_nShearAngle) ShearXPoly(aXPoly, getRectangle().TopLeft(),
maGeo.mfTanShearAngle);
diff --git a/sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx
b/sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx
index 84022cfbe9d9..4707727f87ab 100644
--- a/sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx
+++ b/sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx
@@ -1583,7 +1583,7 @@ void
OOXMLFastContextHandlerTextTableRow::handleGridBefore( const OOXMLValue::Po
NS_ooxml::LN_CT_TcBorders_start,
NS_ooxml::LN_CT_TcBorders_end };
for(sal_uInt32 border : borders)
pBorderProps->add(border, fakeNoBorder(),
OOXMLProperty::SPRM);
- OOXMLValue::Pointer_t pValue( new OOXMLPropertySetValue(
pBorderProps ));
+ OOXMLValue::Pointer_t pValue( new
OOXMLPropertySetValue(std::move(pBorderProps)) );
pCellProps->add(NS_ooxml::LN_CT_TcPrBase_tcBorders, pValue,
OOXMLProperty::SPRM);
mpParserState->setCellProperties(pCellProps);
}
