sfx2/source/doc/guisaveas.cxx | 1 +
1 file changed, 1 insertion(+)
New commits:
commit ebada44e9bac76d6ccbdc387ed673d938830bfd0
Author: Stephan Bergmann <stephan.bergm...@allotropia.de>
AuthorDate: Thu Jul 25 09:13:23 2024 +0200
Commit: Stephan Bergmann <stephan.bergm...@allotropia.de>
CommitDate: Thu Jul 25 12:30:38 2024 +0200
Read of uninitialized bool
after 426c641976688e3e4d1ce66f76b27ccbd2dca55a "tdf#159040: add sign with
default certificate to save dialog", causing
> /sfx2/source/doc/guisaveas.cxx:307:54: runtime error: load of value 190,
which is not a valid value for type 'bool'
> #0 0x7f1ab45ca7d6 in ModelData_Impl::IsSignWithDefaultSignature()
const /sfx2/source/doc/guisaveas.cxx:307:54
> #1 0x7f1ab45957de in
SfxStoringHelper::FinishGUIStoreModel(__gnu_debug::_Safe_iterator<std::__detail::_Node_const_iterator<std::pair<comphelper::OUStringAndHashCode
const, com::sun::star::uno::Any>, false, true>,
std::__debug::unordered_map<comphelper::OUStringAndHashCode,
com::sun::star::uno::Any, comphelper::OUStringAndHashCodeHash,
comphelper::OUStringAndHashCodeEqual,
std::allocator<std::pair<comphelper::OUStringAndHashCode const,
com::sun::star::uno::Any> > >, std::forward_iterator_tag>&, ModelData_Impl&,
bool, short,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, bool,
bool, bool, std::basic_string_view<char16_t, std::char_traits<char16_t> >,
std::basic_string_view<char16_t, std::char_traits<char16_t> >,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&,
rtl::OUString) /sfx2/source/doc/guisaveas.cxx:1896:20
> #2 0x7f1ab45b49b0 in
SfxStoringHelper::GUIStoreModel(com::sun::star::uno::Reference<com::sun::star::frame::XModel>
const&, std::basic_string_view<char16_t, std::char_traits<char16_t> >,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, bool,
SignatureState, bool) /sfx2/source/doc/guisaveas.cxx:1626:12
> #3 0x7f1ab46b6ac3 in SfxObjectShell::ExecFile_Impl(SfxRequest&)
/sfx2/source/doc/objserv.cxx:1096:26
> #4 0x7f1ab46a2ea4 in SfxStubSfxObjectShellExecFile_Impl(SfxShell*,
SfxRequest&) /workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:221:1
> #5 0x7f1ab343ae1e in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot
const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:254:9
> #6 0x7f1ab3450745 in SfxDispatcher::Execute_(SfxShell&, SfxSlot
const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
> #7 0x7f1ab34515ab in SfxDispatcher::Execute(unsigned short,
SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short)
/sfx2/source/control/dispatch.cxx:812:9
> #8 0x7f1ab3861c1b in
SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&,
com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener>
const&) /sfx2/source/control/unoctitm.cxx:675:46
> #9 0x7f1ab3864f41 in
SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&,
com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener>
const&) /sfx2/source/control/unoctitm.cxx:270:16
> #10 0x7f1a86be9616 in
framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch>
const&, com::sun::star::util::URL const&, bool,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
/framework/source/services/dispatchhelper.cxx:164:30
> #11 0x7f1a86be84eb in
framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider>
const&, rtl::OUString const&, rtl::OUString const&, int,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
/framework/source/services/dispatchhelper.cxx:121:16
> #12 0x7f1a86be9ec4 in non-virtual thunk to
framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider>
const&, rtl::OUString const&, rtl::OUString const&, int,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
/framework/source/services/dispatchhelper.cxx
> #13 0x7f1aaea0e879 in
unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent>
const&, rtl::OUString const&,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
/unotest/source/cpp/macros_test.cxx:94:33
> #14 0x7f1ad66c521e in
ScPDFExportTest::exportToPDFWithUnoCommands(rtl::OUString const&)
/sc/qa/extras/scpdfexport.cxx:196:5
> #15 0x7f1ad66d1e94 in ScPDFExportTest::testUnoCommands_Tdf120161()
/sc/qa/extras/scpdfexport.cxx:376:9
during CppunitTest_sc_pdf_export
(<https://ci.libreoffice.org/job/lo_ubsan/3255/>)
Change-Id: If9e1b4b75a430506b999ecff916191ab1d3d58d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171000
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de>
diff --git a/sfx2/source/doc/guisaveas.cxx b/sfx2/source/doc/guisaveas.cxx
index eee91ba06a38..dc88659e6b1e 100644
--- a/sfx2/source/doc/guisaveas.cxx
+++ b/sfx2/source/doc/guisaveas.cxx
@@ -356,6 +356,7 @@ ModelData_Impl::ModelData_Impl( SfxStoringHelper& aOwner,
, m_xModel(std::move( xModel ))
, m_aMediaDescrHM( aMediaDescr )
, m_bRecommendReadOnly( false )
+, m_bSignWithDefaultSignature( false )
{
CheckInteractionHandler();
}
