core.git: 2 commits - package/source vcl/source

[Caolán McNamara (via logerrit)]

 package/source/zipapi/ZipFile.cxx  |    1 +
 vcl/source/filter/egif/giflzwc.cxx |    1 +
 2 files changed, 2 insertions(+)

New commits:
commit 1cf263e8387a21e740d49890fe00a8e684a117cc
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 21 20:25:44 2024 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 22 09:34:29 2024 +0200

    cid#1608288 silence Overflowed constant
    
    Change-Id: Ic20c62c06f67792b263a15adcc4855297f2fefef
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170823
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/vcl/source/filter/egif/giflzwc.cxx 
b/vcl/source/filter/egif/giflzwc.cxx
index 41c65d2da4c2..95137f75fa0d 100644
--- a/vcl/source/filter/egif/giflzwc.cxx
+++ b/vcl/source/filter/egif/giflzwc.cxx
@@ -53,6 +53,7 @@ inline void GIFImageDataOutputStream::FlushBitsBufsFullBytes()
         if( nBlockBufSize==255 )
             FlushBlockBuf();
 
+        assert(nBlockBufSize != 255 && "FlushBlockBuf ensures this is 
incrementable without overflow");
         pBlockBuf[nBlockBufSize++] = static_cast<sal_uInt8>(nBitsBuf);
         nBitsBuf >>= 8;
         nBitsBufSize -= 8;
commit fdd5d471c10b3e349b51b9f4396cbbbd6d2190d8
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 21 20:18:57 2024 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 22 09:34:18 2024 +0200

    cid#1607270 silence Overflowed integer argument
    
    Change-Id: Ie5973c23d2d106815af0d1300a99687a84cfed1b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170822
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/package/source/zipapi/ZipFile.cxx 
b/package/source/zipapi/ZipFile.cxx
index e46d7c561e34..b83d52cfae79 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -573,6 +573,7 @@ uno::Reference<io::XInputStream> 
ZipFile::checkValidPassword(
         if ( nSize > n_ConstDigestDecrypt )
             nSize = n_ConstDigestDecrypt;
 
+        assert(nSize <= n_ConstDigestDecrypt && "silence bogus coverity 
overflow_sink");
         Sequence < sal_Int8 > aReadBuffer ( nSize );
 
         xStream->readBytes( aReadBuffer, nSize );