offapi/com/sun/star/accessibility/XAccessibleAction.idl | 10 ++++------
test/source/a11y/accessibletestbase.cxx | 2 +-
2 files changed, 5 insertions(+), 7 deletions(-)
New commits:
commit 5495a2ef9c5e0a457c44e2fe0f6a62effda43ebc
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Tue Jul 16 11:08:13 2024 +0200
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Tue Jul 16 12:47:45 2024 +0200
a11y tests: Double the timeout for UI tests
Increase the timeout for a11y UI tests from 1 to 2 min,
to see whether this helps with one slow Windows Jenkins
builder running into the timeout every once in a while,
as was mentioned in ESC calls.
Example from [1]:
timeout waiting for dialog 'Bookmark' to show up
warn:vcl.schedule:6600:11456:vcl/source/app/scheduler.cxx:524: Uncaught
exception during Task::Invoke()!
abort() has been
calledwarn:sal.cppunittester:6600:11456:sal/cppunittester/cppunittester.cxx:601:
CAUGHT SIGABRT:
[...]
[1] https://ci.libreoffice.org/job/gerrit_windows/181051/console
Change-Id: I5b16ea8c538f6e2b5a30ebac714e177e696aac92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170569
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
Tested-by: Jenkins
diff --git a/test/source/a11y/accessibletestbase.cxx
b/test/source/a11y/accessibletestbase.cxx
index 27bea36f6084..5d8f50c90f10 100644
--- a/test/source/a11y/accessibletestbase.cxx
+++ b/test/source/a11y/accessibletestbase.cxx
@@ -436,7 +436,7 @@ test::AccessibleTestBase::awaitDialog(const
std::u16string_view name,
mxToolkit->addTopWindowListener(mxTopWindowListener);
maTimeoutTimer.SetInvokeHandler(LINK(this, ListenerHelper,
timeoutTimerHandler));
- maTimeoutTimer.SetTimeout(60000);
+ maTimeoutTimer.SetTimeout(120000);
maTimeoutTimer.Start();
maIdleHandler.SetInvokeHandler(LINK(this, ListenerHelper,
idleHandler));
commit 4f63dd8b374ce6e5c6fd783625c287eef6079265
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Tue Jul 16 10:51:59 2024 +0200
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Tue Jul 16 12:47:34 2024 +0200
a11y: Clean up XAccessibleAction doc
The `XAccessibleAction::getAccessibleActionDescription`
and `XAcccessibleAction::doAccessibleAction` doc mentions
that an `IndexOutOfBoundsException` exception is thrown
when the index is invalid, which is indeed the expected
behaviour. However, they mentioned in addition that false
or an empty string is returned, which doesn't make sense
when exception gets thrown, so drop that.
Also slightly improve wording at 2 other places.
Change-Id: Idcc1fd669f32ff5a160cb35d2fbf6c2d23f65ab9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170567
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
Tested-by: Jenkins
diff --git a/offapi/com/sun/star/accessibility/XAccessibleAction.idl
b/offapi/com/sun/star/accessibility/XAccessibleAction.idl
index bae281c8e98f..e35d049e1b44 100644
--- a/offapi/com/sun/star/accessibility/XAccessibleAction.idl
+++ b/offapi/com/sun/star/accessibility/XAccessibleAction.idl
@@ -47,8 +47,7 @@ interface XAccessibleAction :
::com::sun::star::uno::XInterface
/** Perform the specified Action on the object.
@param nIndex
- This index specifies the action to perform. If it lies outside
- the valid range `FALSE` is returned and no action is performed.
+ This index specifies the action to perform.
@return
Returns `TRUE` if the action was successfully performed. If
the action could not be performed successfully `FALSE` is
@@ -66,14 +65,13 @@ interface XAccessibleAction :
::com::sun::star::uno::XInterface
@param nIndex
This index specifies the action of which to return a
- description. If it lies outside the valid range an empty string
- is returned.
+ description.
@return
The returned value is a localized string of the specified action.
@throws IndexOutOfBoundsException
- If the given index lies not in the valid range then an
+ If the given index does not lie in the valid range then a
::com::sun::star::lang::IndexOutOfBoundsException
exception is thrown.
*/
@@ -86,7 +84,7 @@ interface XAccessibleAction :
::com::sun::star::uno::XInterface
more information about how key bindings are represented.
@param nIndex
- This index specifies the action of which to return the key
+ This index specifies the action for which to return the key
binding.
@return
