logerrit | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 2fab1a73b11a500c38e9df67d1b2061e9a6c9232
Author: Miklos Vajna <vmik...@suse.cz>
Date: Thu Jul 5 13:22:47 2012 +0200
logerrit: for review, we need to grep for revision, not ref
Change-Id: I0fb8b1e4f14e153adae7a2ec1b3adbb0dab5c847
diff --git a/logerrit b/logerrit
index cc24c76..e5b2ba5 100755
--- a/logerrit
+++ b/logerrit
@@ -8,6 +8,10 @@ get_SHA_for_change() {
SHA=`ssh ${GERRITHOST?} gerrit query --all-approvals change:$1|grep
ref|tail -1|cut -d: -f2`
}
+get_REVISION_for_change() {
+ REVISION=`ssh ${GERRITHOST?} gerrit query --all-approvals
change:$1|grep revision|tail -1|cut -d: -f2`
+}
+
ask_tristate() {
case $1 in
[yY] | [yY][Ee][Ss] | [+] )
@@ -159,8 +163,8 @@ case "$1" in
;;
esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
- get_SHA_for_change $CHANGEID
- ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG
$CODEREVIEWFLAG $SHA
+ get_REVISION_for_change $CHANGEID
+ ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG
$CODEREVIEWFLAG $REVISION
;;
checkout)
get_SHA_for_change $2
commit f3b1a1581324085257f3eb8290a086b22dcca8f5
Author: Bjoern Michaelsen <bjoern.michael...@canonical.com>
Date: Thu Jul 5 12:41:59 2012 +0200
fix ./logerrit review
* ./logerrit review did not resolve the ChangeId to a SHA
* ./logerrit did still echo the command instead of executing it.
Change-Id: Ie4f8630f7a83134d6eb7992f4a61b5d3faf7e138
diff --git a/logerrit b/logerrit
index 851af7d..cc24c76 100755
--- a/logerrit
+++ b/logerrit
@@ -159,7 +159,8 @@ case "$1" in
;;
esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
- echo ssh ${GERRITHOST?} gerrit review -m '\"'$MESSAGE'\"'
$VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID
+ get_SHA_for_change $CHANGEID
+ ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG
$CODEREVIEWFLAG $SHA
;;
checkout)
get_SHA_for_change $2
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
