chart2/source/view/charttypes/PieChart.cxx | 5 +++++
1 file changed, 5 insertions(+)
New commits:
commit 1036994301de43f5a41134084ca866ed9ec7bf35
Author: Kurt Nordback <kurt.nordb...@protonmail.com>
AuthorDate: Mon Nov 20 11:53:42 2023 -0700
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Sun Feb 18 10:10:39 2024 +0100
tdf#50934: Add a comment
Change-Id: I3986242fa584310acccba4830d8872043381cef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160732
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/chart2/source/view/charttypes/PieChart.cxx
b/chart2/source/view/charttypes/PieChart.cxx
index 9b1494596598..402857b85cdc 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -996,6 +996,11 @@ void PieChart::createShapes()
sal_Int32 nEnd = pDataSrc->getNPoints(pSeries, SubPieType::LEFT);
double compFrac = pDataSrc->getData(pSeries, nEnd - 1,
SubPieType::LEFT) / aParam.mfLogicYSum;
+ // The following isn't quite right. The tangent points on the left
+ // pie are only at pi/2 and -pi/2 for composite wedges over 1/2 the
+ // total if left and right pies are the same diameter. And the
+ // threshold of 1/2 isn't quite right either. So there
+ // really should be a more sophisticated approach here. TODO
if (compFrac < 0.5) {
// Translated, per below
xl0 = aParam.mfUnitCircleOuterRadius * m_fLeftScale *
