oox/source/drawingml/chart/plotareaconverter.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3fb9859c6aa4a32f2333d86fa438e9f1d6ef7f55
Author:     Stephan Bergmann <stephan.bergm...@allotropia.de>
AuthorDate: Fri Jan 19 08:42:13 2024 +0100
Commit:     Stephan Bergmann <stephan.bergm...@allotropia.de>
CommitDate: Fri Jan 19 10:20:57 2024 +0100

    PlotAreaConverter::mbSingleSeriesTitle is apparently read uninitialized
    
    ...in code newly introduced in 135ce256ce9e879663d828ec6e699de521fad867
    "tdf#146487 Don't show generic diagram title when there is an empty title
    given", which caused CppunitTest_chart2_export2 to fail with
    
    > /oox/inc/drawingml/chart/plotareaconverter.hxx:78:62: runtime error: load 
of value 222, which is not a valid value for type 'bool'
    >     #0 0x7f95cd9ed87c in 
oox::drawingml::chart::PlotAreaConverter::isSingleSeriesTitle() const 
/oox/inc/drawingml/chart/plotareaconverter.hxx:78:62
    >     #1 0x7f95cd9e506f in 
oox::drawingml::chart::ChartSpaceConverter::convertFromModel(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes>
 const&, com::sun::star::awt::Point const&) 
/oox/source/drawingml/chart/chartspaceconverter.cxx:189:53
    >     #2 0x7f95cd9b6c34 in 
oox::drawingml::chart::ChartConverter::convertFromModel(oox::core::XmlFilterBase&,
 oox::drawingml::chart::ChartSpaceModel&, 
com::sun::star::uno::Reference<com::sun::star::chart2::XChartDocument> const&, 
com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, 
com::sun::star::awt::Point const&, com::sun::star::awt::Size const&) 
/oox/source/drawingml/chart/chartconverter.cxx:93:20
    >     #3 0x7f95ce548f59 in 
oox::drawingml::Shape::finalizeXShape(oox::core::XmlFilterBase&, 
com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&) 
/oox/source/drawingml/shape.cxx:2245:50
    >     #4 0x7f95438150b2 in 
oox::xls::Shape::finalizeXShape(oox::core::XmlFilterBase&, 
com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&) 
/sc/source/filter/oox/drawingfragment.cxx:113:30
    >     #5 0x7f95ce5267bb in 
oox::drawingml::Shape::createAndInsert(oox::core::XmlFilterBase&, rtl::OUString 
const&, oox::drawingml::Theme const*, 
com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, bool, 
bool, basegfx::B2DHomMatrix&, oox::drawingml::FillProperties const&, 
std::shared_ptr<oox::drawingml::Shape>) /oox/source/drawingml/shape.cxx:1964:9
    >     #6 0x7f95ce4edb54 in 
oox::drawingml::Shape::addShape(oox::core::XmlFilterBase&, 
oox::drawingml::Theme const*, 
com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, 
basegfx::B2DHomMatrix const&, oox::drawingml::FillProperties const&, 
std::__debug::map<rtl::OUString, std::shared_ptr<oox::drawingml::Shape>, 
std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, 
std::shared_ptr<oox::drawingml::Shape> > > >*, 
std::shared_ptr<oox::drawingml::Shape>) /oox/source/drawingml/shape.cxx:366:41
    >     #7 0x7f954381ef79 in oox::xls::DrawingFragment::onEndElement() 
/sc/source/filter/oox/drawingfragment.cxx:335:30
    >     #8 0x7f95cdcaee54 in 
oox::core::ContextHandler2Helper::implEndElement(int) 
/oox/source/core/contexthandler2.cxx:125:9
    >     #9 0x7f95cdd5c116 in oox::core::FragmentHandler2::endFastElement(int) 
/oox/source/core/fragmenthandler2.cxx:91:5
    >     #10 0x7f95caf68fca in (anonymous namespace)::Entity::endElement() 
/sax/source/fastparser/fastparser.cxx:514:27
    >     #11 0x7f95caf68998 in 
sax_fastparser::FastSaxParserImpl::callbackEndElement() 
/sax/source/fastparser/fastparser.cxx:1331:17
    >     #12 0x7f95caf58444 in (anonymous 
namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char 
const*, unsigned char const*) /sax/source/fastparser/fastparser.cxx:338:18
    >     #13 0x7f960adebeda in xmlParseEndTag2 
/workdir/UnpackedTarball/libxml2/parser.c:10090:2
    >     #14 0x7f960ad929b5 in xmlParseTryOrFinish 
/workdir/UnpackedTarball/libxml2/parser.c:11868:14
    >     #15 0x7f960ad86334 in xmlParseChunk 
/workdir/UnpackedTarball/libxml2/parser.c:12151:5
    >     #16 0x7f95caf53231 in sax_fastparser::FastSaxParserImpl::parse() 
/sax/source/fastparser/fastparser.cxx:1085:21
    >     #17 0x7f95caf4cd18 in 
sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource
 const&) /sax/source/fastparser/fastparser.cxx:890:9
    >     #18 0x7f95caf6e950 in 
sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource
 const&) /sax/source/fastparser/fastparser.cxx:1470:13
    >     #19 0x7f95cdce50d1 in 
oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource 
const&, bool) /oox/source/core/fastparser.cxx:121:15
    >     #20 0x7f95cdce5868 in 
oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream>
 const&, rtl::OUString const&) /oox/source/core/fastparser.cxx:129:5
    >     #21 0x7f95cddbb234 in 
oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler>
 const&, oox::core::FastParser&) /oox/source/core/xmlfilterbase.cxx:414:21
    >     #22 0x7f95cddb9b8d in 
oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler>
 const&) /oox/source/core/xmlfilterbase.cxx:344:12
    >     #23 0x7f95441ceaa8 in 
oox::xls::WorkbookHelper::importOoxFragment(rtl::Reference<oox::core::FragmentHandler>
 const&) /sc/source/filter/oox/workbookhelper.cxx:1046:27
    >     #24 0x7f95442797f1 in oox::xls::WorksheetGlobals::finalizeDrawings() 
/sc/source/filter/oox/worksheethelper.cxx:1373:9
    >     #25 0x7f95442789e0 in 
oox::xls::WorksheetGlobals::finalizeDrawingImport() 
/sc/source/filter/oox/worksheethelper.cxx:996:5
    >     #26 0x7f954428744d in 
oox::xls::WorksheetHelper::finalizeDrawingImport() 
/sc/source/filter/oox/worksheethelper.cxx:1637:17
    >     #27 0x7f95441771de in oox::xls::WorkbookFragment::finalizeImport() 
/sc/source/filter/oox/workbookfragment.cxx:511:18
    >     #28 0x7f95cdd5b3ae in oox::core::FragmentHandler2::endDocument() 
/oox/source/core/fragmenthandler2.cxx:53:5
    >     #29 0x7f95caf4cfc2 in 
sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource
 const&) /sax/source/fastparser/fastparser.cxx:896:36
    >     #30 0x7f95caf6e950 in 
sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource
 const&) /sax/source/fastparser/fastparser.cxx:1470:13
    >     #31 0x7f95cdce50d1 in 
oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource 
const&, bool) /oox/source/core/fastparser.cxx:121:15
    >     #32 0x7f95cdce5868 in 
oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream>
 const&, rtl::OUString const&) /oox/source/core/fastparser.cxx:129:5
    >     #33 0x7f95cddbb234 in 
oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler>
 const&, oox::core::FastParser&) /oox/source/core/xmlfilterbase.cxx:414:21
    >     #34 0x7f95cddb9b8d in 
oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler>
 const&) /oox/source/core/xmlfilterbase.cxx:344:12
    >     #35 0x7f95435c4daa in oox::xls::ExcelFilter::importDocument() 
/sc/source/filter/oox/excelfilter.cxx:113:25
    >     #36 0x7f95cdcf953b in 
oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
 const&) /oox/source/core/filterbase.cxx:488:49
    >     #37 0x7f95435c7733 in 
oox::xls::ExcelFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
 const&) /sc/source/filter/oox/excelfilter.cxx:176:25
    >     #38 0x7f95857c5b40 in SfxObjectShell::ImportFrom(SfxMedium&, 
com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) 
/sfx2/source/doc/objstor.cxx:2393:34
    >     #39 0x7f9585781c6a in SfxObjectShell::DoLoad(SfxMedium*) 
/sfx2/source/doc/objstor.cxx:761:23
    >     #40 0x7f95859a9652 in 
SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
 const&) /sfx2/source/doc/sfxbasemodel.cxx:1980:36
    >     #41 0x7f95862145e9 in (anonymous 
namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
 const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) 
/sfx2/source/view/frmload.cxx:720:28
    >     #42 0x7f95536a9900 in framework::LoadEnv::impl_loadContent() 
/framework/source/loadenv/loadenv.cxx:1176:37
    >     #43 0x7f95536a091b in framework::LoadEnv::start() 
/framework/source/loadenv/loadenv.cxx:412:20
    >     #44 0x7f9553698f59 in framework::LoadEnv::startLoading(rtl::OUString 
const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> 
const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, 
rtl::OUString const&, int, LoadEnvFeatures) 
/framework/source/loadenv/loadenv.cxx:308:5
    >     #45 0x7f95536946e7 in 
framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader>
 const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> 
const&, rtl::OUString const&, rtl::OUString const&, int, 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) 
/framework/source/loadenv/loadenv.cxx:168:14
    >     #46 0x7f955376867d in 
framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString 
const&, int, 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) 
/framework/source/services/desktop.cxx:591:16
    >     #47 0x7f95537688a6 in non-virtual thunk to 
framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString 
const&, int, 
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) 
/framework/source/services/desktop.cxx
    >     #48 0x7f9569f7cafa in 
unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString 
const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> 
const&) /unotest/source/cpp/macros_test.cxx:71:62
    >     #49 0x7f9580718c56 in UnoApiTest::loadWithParams(rtl::OUString 
const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> 
const&) /test/source/unoapi_test.cxx:126:19
    >     #50 0x7f9580717ef8 in UnoApiTest::load(rtl::OUString const&, char 
const*) /test/source/unoapi_test.cxx:108:5
    >     #51 0x7f9580719254 in 
UnoApiTest::loadFromFile(std::basic_string_view<char16_t, 
std::char_traits<char16_t> >, char const*) /test/source/unoapi_test.cxx:132:5
    >     #52 0x7f95d8bf1018 in testTdf123647::TestBody() 
/chart2/qa/extras/chart2export2.cxx:1242:5
    
    (<https://ci.libreoffice.org//job/lo_ubsan/3048/>)
    
    Change-Id: I870d811e78b8c55b84627ae609f98f623465dd9d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162294
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de>

diff --git a/oox/source/drawingml/chart/plotareaconverter.cxx 
b/oox/source/drawingml/chart/plotareaconverter.cxx
index 32e4de7d1ee4..cd2ec9e5bdc9 100644
--- a/oox/source/drawingml/chart/plotareaconverter.cxx
+++ b/oox/source/drawingml/chart/plotareaconverter.cxx
@@ -304,7 +304,8 @@ PlotAreaConverter::PlotAreaConverter( const ConverterRoot& 
rParent, PlotAreaMode
     ConverterBase< PlotAreaModel >( rParent, rModel ),
     mb3dChart( false ),
     mbWall3dChart( false ),
-    mbPieChart( false )
+    mbPieChart( false ),
+    mbSingleSeriesTitle( false )
 {
 }
 

Reply via email to