postprocess/CustomTarget_signing.mk | 1 +
1 file changed, 1 insertion(+)
New commits:
commit 59529949edc864f99e5a64ae3b77dcb33c71fe65
Author: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
AuthorDate: Mon Jan 8 14:33:22 2024 +0100
Commit: Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Tue Jan 9 09:36:45 2024 +0100
windows signing: also wait for/depend on extras (gallery)
Otherwise, doing 'make' with --enable-windows-build-signing
fails with
ERROR: SignTool Error: The file is being used by another process.
SignTool Error: An error occurred while attempting to sign:
C:/cygwin64/home/buildslave/r/instdir/program/Argon2OptDll.dll
make[1]: ***
[C:/cygwin64/home/buildslave/source/libo-core/postprocess/CustomTarget_signing.mk:31:
C:/cygwin64/home/buildslave/r/workdir/CustomTarget/postprocess/signing/signing.done]
Error 1
make: *** [Makefile:289: build] Error 2
Change-Id: I9d0793f3e42577a47b92025d5670caa44fbd912e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161388
Reviewed-by: Michael Stahl <michael.st...@allotropia.de>
Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
Tested-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
(cherry picked from commit 39b5c2f5ee90364c2cad2b53dd005db8cb28538a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161759
Tested-by: Jenkins
diff --git a/postprocess/CustomTarget_signing.mk
b/postprocess/CustomTarget_signing.mk
index 6fdd4950f4cb..6c061e86afeb 100644
--- a/postprocess/CustomTarget_signing.mk
+++ b/postprocess/CustomTarget_signing.mk
@@ -20,6 +20,7 @@ TIMESTAMPURL ?=
"http://timestamp.globalsign.com/scripts/timestamp.dll";
$(call gb_CustomTarget_get_workdir,postprocess/signing)/signing.done: \
$(SRCDIR)/postprocess/signing/signing.pl \
$(SRCDIR)/postprocess/signing/no_signing.txt \
+ $(call gb_Module_get_target,extras) \
$(call gb_Postprocess_get_target,AllLibraries) \
$(call gb_Postprocess_get_target,AllExecutables) \
$(call gb_Postprocess_get_target,AllModuleTests) \
