Markus Mohrhard píše v Út 26. 06. 2012 v 13:12 +0200: > Hey, > > we need to revert > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=6c6a4ed070acc0b106e951864fa5d20927f5c1e0 > in 3-5. The patch is correct and does the right thing but sadly our > cell export code is insane and therefore this patch makes our export > incredibly slow if we have a whole formatted column. After looking > into the code and my profiling results I see no easy solution for this > problem and think that the performance problem is much worse than the > bug this patch fixed. See fdo#49582 for a bug which is caused by this > commit. I will also revert this commit in master and 3-6 because we > will not be able to fix the underlying problem with a bit of > refactoring of the export code.
I tested it with the document from the bug 49582. The revert really improved the performance a lot. In addition, it solved an error message about too many rows. The original bug 46738 was already in LO-3.3 => old bug => less critical. => reverted in both 3-5 and 3-5-5 branch. I think that we do not need 3-ple review for reverting commits when it is requested by the author. Best Regards, Petr _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
