basctl/source/basicide/brkdlg.cxx | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
New commits:
commit e94cbd7dbf4a8c82f17522806a9011c89bf20865
Author: Hossein <hoss...@libreoffice.org>
AuthorDate: Wed Oct 18 10:29:22 2023 +0200
Commit: Hossein <hoss...@libreoffice.org>
CommitDate: Wed Oct 18 17:41:52 2023 +0200
Remove obsolete comments in basctl
First comment was last updated with USHORT -> sal_uInt16 in
a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit
68ec95b3f80408ae50897b043eed69a07d084df9 there is no remaining sal_uInt16
left, and thus the comment is no longer relevant.
Second comment was added in 1fac87f84723a3d6e7e13c091e39b09e0dea1aa5,
but with changes in 444c242c51e6b049598359ea6cf98e34f611838b it is no
longer relevant.
Third comment was also last updated with USHORT -> sal_uInt16 in
a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit
444c242c51e6b049598359ea6cf98e34f611838b it is no longer relevant.
Change-Id: I9ed383f15a5b403740c0b8bcdd153d04bb1a2b0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158111
Tested-by: Jenkins
Reviewed-by: Hossein <hoss...@libreoffice.org>
diff --git a/basctl/source/basicide/brkdlg.cxx
b/basctl/source/basicide/brkdlg.cxx
index 37ba1dbb60ae..48522d11ac37 100644
--- a/basctl/source/basicide/brkdlg.cxx
+++ b/basctl/source/basicide/brkdlg.cxx
@@ -28,15 +28,11 @@
namespace basctl
{
-// FIXME Why does BreakPointDialog allow only sal_uInt16 for break-point line
-// numbers, whereas BreakPoint supports sal_uLong?
-
namespace
{
bool lcl_ParseText(OUString const& rText, size_t& rLineNr)
{
- // aText should look like "# n" where
- // n > 0 && n < std::numeric_limits< sal_uInt16 >::max().
+ // aText should look like "# n" where n > 0
// All spaces are ignored, so there can even be spaces within the
// number n. (Maybe it would be better to ignore all whitespace instead
// of just spaces.)
@@ -48,7 +44,6 @@ bool lcl_ParseText(OUString const& rText, size_t& rLineNr)
return false;
if (cFirst == '#')
aText = aText.copy(1);
- // XXX Assumes that sal_uInt16 is contained within sal_Int32:
sal_Int32 n = aText.toInt32();
if (n <= 0)
return false;
