editeng/qa/unit/core-test.cxx | 33 +++++++++++++--------------------
1 file changed, 13 insertions(+), 20 deletions(-)
New commits:
commit 4fd6b125751897923428523336a768310a58b36e
Author: Tomaž Vajngerl <tomaz.vajng...@collabora.co.uk>
AuthorDate: Wed Oct 11 22:41:02 2023 +0900
Commit: Tomaž Vajngerl <qui...@gmail.com>
CommitDate: Thu Oct 12 05:08:27 2023 +0200
editeng: move the methods into Test class definition
This makes makes all the Test class methods contined in the
class definition body, so more readable and less noise for the
actual test definitions.
Change-Id: I3ea177f27aa868a396e537b1682ce91d93c1208e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157837
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <qui...@gmail.com>
diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index d3f92ce60c2c..12099ea0a719 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -45,10 +45,20 @@ namespace {
class Test : public test::BootstrapFixture
{
public:
- Test();
+ Test() {}
- virtual void setUp() override;
- virtual void tearDown() override;
+ void setUp() override
+ {
+ test::BootstrapFixture::setUp();
+ mpItemPool = new EditEngineItemPool();
+ SfxApplication::GetOrCreate();
+ }
+
+ void tearDown() override
+ {
+ mpItemPool.clear();
+ test::BootstrapFixture::tearDown();
+ }
#if HAVE_MORE_FONTS
/// Test text portions position when percentage line spacing is set
@@ -135,23 +145,6 @@ private:
rtl::Reference<EditEngineItemPool> mpItemPool;
};
-Test::Test() {}
-
-void Test::setUp()
-{
- test::BootstrapFixture::setUp();
-
- mpItemPool = new EditEngineItemPool();
-
- SfxApplication::GetOrCreate();
-}
-
-void Test::tearDown()
-{
- mpItemPool.clear();
- test::BootstrapFixture::tearDown();
-}
-
#if HAVE_MORE_FONTS
void Test::testLineSpacing()
{
