[Libreoffice-commits] core.git: filter/source

[Justin Luth (via logerrit)]

 filter/source/pdf/impdialog.cxx |   24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

New commits:
commit 1cf500366e8de4c1c89c1f9235629d2efeaa89af
Author:     Justin Luth <jl...@mail.com>
AuthorDate: Fri Sep 29 11:10:11 2023 -0400
Commit:     Justin Luth <jl...@mail.com>
CommitDate: Sat Sep 30 17:26:51 2023 +0200

    NFC pdfexport dialog: cleanup impdialog.cxx
    
    No Functional Change intended
    
    Change-Id: Ie08883af2a6cf3d84f77f550e147f8aba24a152b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157432
    Tested-by: Jenkins
    Reviewed-by: Justin Luth <jl...@mail.com>

diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index a444f69891c6..ba412851c393 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -593,13 +593,6 @@ void 
ImpPDFTabGeneralPage::SetFilterConfigItem(ImpPDFTabDialog* pParent)
     mbIsWriter = pParent->mbIsWriter;
     mbIsSpreadsheet = pParent->mbIsSpreadsheet;
 
-    mxCbExportNotesInMargin->set_sensitive(
-        mbIsWriter && 
!pParent->maConfigItem.IsReadOnly("ExportNotesInMargin"));
-    mxCbExportEmptyPages->set_sensitive(
-        mbIsWriter && !pParent->maConfigItem.IsReadOnly("IsSkipEmptyPages"));
-    mxCbExportPlaceholders->set_sensitive(
-        mbIsWriter && !pParent->maConfigItem.IsReadOnly("ExportPlaceholders"));
-
     mxRbLosslessCompression->connect_toggled( LINK( this, 
ImpPDFTabGeneralPage, ToggleCompressionHdl ) );
     const bool bUseLosslessCompression = pParent->mbUseLosslessCompression;
     if ( bUseLosslessCompression )
@@ -678,7 +671,10 @@ void 
ImpPDFTabGeneralPage::SetFilterConfigItem(ImpPDFTabDialog* pParent)
 
 
     mxCbExportNotes->set_active( pParent->mbExportNotes );
-    mxCbExportNotesInMargin->set_active( pParent->mbExportNotesInMargin );
+    mxCbExportNotesInMargin->set_active(mbIsWriter && 
pParent->mbExportNotesInMargin);
+    mxCbExportNotesInMargin->set_sensitive(
+        mbIsWriter && 
!pParent->maConfigItem.IsReadOnly("ExportNotesInMargin"));
+
     if (comphelper::LibreOfficeKit::isActive())
     {
         mxCbViewPDF->hide();
@@ -733,14 +729,14 @@ void 
ImpPDFTabGeneralPage::SetFilterConfigItem(ImpPDFTabDialog* pParent)
         mxCbSinglePageSheets->set_active(false);
     }
 
-    mxCbExportPlaceholders->set_visible(mbIsWriter);
-    if( !mbIsWriter )
-    {
-        mxCbExportPlaceholders->set_active(false);
-        mxCbExportNotesInMargin->set_active(false);
-    }
     mxCbExportEmptyPages->set_active(!pParent->mbIsSkipEmptyPages);
+    mxCbExportEmptyPages->set_sensitive(
+        mbIsWriter && !pParent->maConfigItem.IsReadOnly("IsSkipEmptyPages"));
+
+    mxCbExportPlaceholders->set_visible(mbIsWriter);
     mxCbExportPlaceholders->set_active(pParent->mbIsExportPlaceholders);
+    mxCbExportPlaceholders->set_sensitive(
+        mbIsWriter && !pParent->maConfigItem.IsReadOnly("ExportPlaceholders"));
 
     mxCbAddStream->show();
     mxCbAddStream->set_active(pParent->mbAddStream);