[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/skia

[Patrick Luby (via logerrit)]

 vcl/skia/gdiimpl.cxx |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 41b8243464a0aa4730e4c6177f1c4fd6adc260d9
Author:     Patrick Luby <plub...@neooffice.org>
AuthorDate: Thu Sep 21 20:20:33 2023 -0400
Commit:     Patrick Luby <plub...@neooffice.org>
CommitDate: Fri Sep 22 15:51:31 2023 +0200

    tdf#157312 Don't change priority
    
    Instances of this class are constructed with
    TaskPriority::POST_PAINT, but then it was set to
    TaskPriority::HIGHEST when reused. Flushing
    seems to be expensive (at least with Skia/Metal) so keep the
    existing priority when reused.
    
    Change-Id: Ieb40cd6122f543f76e66456cc92a8643e2320d73
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157162
    Tested-by: Jenkins
    Reviewed-by: Patrick Luby <plub...@neooffice.org>
    (cherry picked from commit daa4a29c993df2e137b222ac3e60aa4b417a2d2d)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157122

diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 7145644b01eb..2ae3b8d85e23 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -268,7 +268,13 @@ public:
     {
         mpGraphics->performFlush();
         Stop();
-        SetPriority(TaskPriority::HIGHEST);
+        // tdf#157312 Don't change priority
+        // Instances of this class are constructed with
+        // TaskPriority::POST_PAINT, but then it was set to
+        // TaskPriority::HIGHEST when reused. Flushing
+        // seems to be expensive (at least with Skia/Metal) so keep the
+        // existing priority when reused.
+        SetPriority(TaskPriority::POST_PAINT);
     }
 };