accessibility/inc/extended/accessibletabbarpage.hxx | 2
accessibility/inc/standard/vclxaccessiblestatusbaritem.hxx | 1
sd/source/ui/inc/sdtreelb.hxx | 9 -
sfx2/source/control/thumbnailviewacc.cxx | 12 --
sfx2/source/control/thumbnailviewacc.hxx | 4
svtools/source/control/valueacc.cxx | 7 -
svtools/source/control/valueimp.hxx | 2
sw/inc/AnnotationWin.hxx | 1
sw/inc/txtatr.hxx | 1
sw/inc/unodraw.hxx | 1
sw/source/core/doc/CntntIdxStore.cxx | 8 -
sw/source/core/inc/mvsave.hxx | 2
sw/source/uibase/docvw/AnnotationWin.cxx | 6 -
vcl/inc/qt5/QtMenu.hxx | 1
vcl/inc/qt5/QtTools.hxx | 5 -
vcl/qt5/QtMenu.cxx | 9 -
writerperfect/inc/WPXSvInputStream.hxx | 1
writerperfect/source/common/WPXSvInputStream.cxx | 61 -------------
xmlsecurity/inc/certificatechooser.hxx | 1
19 files changed, 134 deletions(-)
New commits:
commit 747a9838ee53a4d2c005729419047b1ffde0db70
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed Sep 13 12:40:18 2023 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed Sep 13 13:28:16 2023 +0200
loplugin:unusedmethods
Change-Id: I00f228451574ca9f9e352d233c7f326c88e90a95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156892
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/accessibility/inc/extended/accessibletabbarpage.hxx
b/accessibility/inc/extended/accessibletabbarpage.hxx
index 5fd91f19b538..052650c19de0 100644
--- a/accessibility/inc/extended/accessibletabbarpage.hxx
+++ b/accessibility/inc/extended/accessibletabbarpage.hxx
@@ -54,8 +54,6 @@ namespace accessibility
void SetSelected( bool bSelected );
void SetPageText( const OUString& sPageText );
- sal_uInt16 GetPageId() const { return m_nPageId; }
-
void FillAccessibleStateSet( sal_Int64& rStateSet );
// OCommonAccessibleComponent
diff --git a/accessibility/inc/standard/vclxaccessiblestatusbaritem.hxx
b/accessibility/inc/standard/vclxaccessiblestatusbaritem.hxx
index 8bcf8e33024b..0ab119fe19eb 100644
--- a/accessibility/inc/standard/vclxaccessiblestatusbaritem.hxx
+++ b/accessibility/inc/standard/vclxaccessiblestatusbaritem.hxx
@@ -52,7 +52,6 @@ private:
OUString GetItemName();
void SetItemText( const OUString& sItemText );
OUString GetItemText();
- sal_uInt16 GetItemId() const { return m_nItemId; }
void FillAccessibleStateSet( sal_Int64& rStateSet );
diff --git a/sd/source/ui/inc/sdtreelb.hxx b/sd/source/ui/inc/sdtreelb.hxx
index 712a6ebf3860..1f6026b557d4 100644
--- a/sd/source/ui/inc/sdtreelb.hxx
+++ b/sd/source/ui/inc/sdtreelb.hxx
@@ -176,15 +176,6 @@ public:
bool IsEditingActive() const {return m_bEditing;}
- void start_editing()
- {
- std::unique_ptr<weld::TreeIter> xIter(m_xTreeView->make_iterator());
- if (m_xTreeView->get_cursor(xIter.get()))
- {
- m_xTreeView->start_editing(*xIter);
- }
- }
-
void set_sensitive(bool bSensitive)
{
m_xTreeView->set_sensitive(bSensitive);
diff --git a/sfx2/source/control/thumbnailviewacc.cxx
b/sfx2/source/control/thumbnailviewacc.cxx
index 54a3af71fb93..ac1e320be25b 100644
--- a/sfx2/source/control/thumbnailviewacc.cxx
+++ b/sfx2/source/control/thumbnailviewacc.cxx
@@ -44,12 +44,6 @@ ThumbnailViewAcc::~ThumbnailViewAcc()
{
}
-ThumbnailViewAcc* ThumbnailViewAcc::getImplementation( const uno::Reference<
uno::XInterface >& rxData )
- noexcept
-{
- return dynamic_cast<ThumbnailViewAcc*>(rxData.get());
-}
-
uno::Reference< accessibility::XAccessibleContext > SAL_CALL
ThumbnailViewAcc::getAccessibleContext()
{
ThrowIfDisposed();
@@ -539,12 +533,6 @@ void ThumbnailViewAcc::FireAccessibleEvent( short
nEventId, const uno::Any& rOld
}
}
-ThumbnailViewItemAcc* ThumbnailViewItemAcc::getImplementation( const
uno::Reference< uno::XInterface >& rxData )
- noexcept
-{
- return dynamic_cast<ThumbnailViewItemAcc*>(rxData.get());
-}
-
void ThumbnailViewAcc::GetFocus()
{
// Broadcast the state change.
diff --git a/sfx2/source/control/thumbnailviewacc.hxx
b/sfx2/source/control/thumbnailviewacc.hxx
index 1fcf9d3ac9a6..63ea533009ad 100644
--- a/sfx2/source/control/thumbnailviewacc.hxx
+++ b/sfx2/source/control/thumbnailviewacc.hxx
@@ -56,8 +56,6 @@ public:
bool HasAccessibleListeners() const { return( mxEventListeners.size() > 0
); }
- static ThumbnailViewAcc* getImplementation( const css::uno::Reference<
css::uno::XInterface >& rxData ) noexcept;
-
public:
/** Called by the corresponding ValueSet when it gets the focus.
Stores the new focus state and broadcasts a state change event.
@@ -164,8 +162,6 @@ public:
void ParentDestroyed();
- static ThumbnailViewItemAcc* getImplementation( const css::uno::Reference<
css::uno::XInterface >& rxData ) noexcept;
-
public:
// XAccessible
diff --git a/svtools/source/control/valueacc.cxx
b/svtools/source/control/valueacc.cxx
index 57c1777d4800..2497d4513b2c 100644
--- a/svtools/source/control/valueacc.cxx
+++ b/svtools/source/control/valueacc.cxx
@@ -436,13 +436,6 @@ void ValueSetAcc::FireAccessibleEvent( short nEventId,
const uno::Any& rOldValue
}
}
-ValueSetAcc* ValueSetAcc::getImplementation( const uno::Reference<
uno::XInterface >& rxData )
- noexcept
-{
- return dynamic_cast<ValueSetAcc*>(rxData.get());
-}
-
-
void ValueSetAcc::GetFocus()
{
mbIsFocused = true;
diff --git a/svtools/source/control/valueimp.hxx
b/svtools/source/control/valueimp.hxx
index fca4e438f72f..61e849cc1acd 100644
--- a/svtools/source/control/valueimp.hxx
+++ b/svtools/source/control/valueimp.hxx
@@ -83,8 +83,6 @@ public:
void FireAccessibleEvent( short nEventId, const
css::uno::Any& rOldValue, const css::uno::Any& rNewValue );
bool HasAccessibleListeners() const { return(
mxEventListeners.size() > 0 ); }
- static ValueSetAcc* getImplementation( const css::uno::Reference<
css::uno::XInterface >& rxData ) noexcept;
-
public:
/** Called by the corresponding ValueSet when it gets the focus.
diff --git a/sw/inc/AnnotationWin.hxx b/sw/inc/AnnotationWin.hxx
index 2aad107fe04e..62b20cb352cc 100644
--- a/sw/inc/AnnotationWin.hxx
+++ b/sw/inc/AnnotationWin.hxx
@@ -194,7 +194,6 @@ class SAL_DLLPUBLIC_RTTI SwAnnotationWin final : public
InterimItemWindow
// Get annotation paraId or generate one if it doesn't exist
sal_uInt32 GetParaId();
- sal_uInt32 GetPostItId();
// Used to generate a unique paraId
static sal_uInt32 CreateUniqueParaId();
diff --git a/sw/inc/txtatr.hxx b/sw/inc/txtatr.hxx
index b97501bb8dfd..cb96256fcb10 100644
--- a/sw/inc/txtatr.hxx
+++ b/sw/inc/txtatr.hxx
@@ -41,7 +41,6 @@ public:
virtual ~SwTextCharFormat( ) override;
void TriggerNodeUpdate(const sw::LegacyModifyHint&);
- bool GetInfo( SfxPoolItem const & rInfo ) const;
// get and set TextNode pointer
void ChgTextNode( SwTextNode* pNew ) { m_pTextNode = pNew; }
diff --git a/sw/inc/unodraw.hxx b/sw/inc/unodraw.hxx
index 1d78e1fc6d7f..4494e1c4a989 100644
--- a/sw/inc/unodraw.hxx
+++ b/sw/inc/unodraw.hxx
@@ -243,7 +243,6 @@ public:
SwShapeDescriptor_Impl* GetDescImpl() {return m_pImpl.get();}
SwFrameFormat* GetFrameFormat() const;
- const css::uno::Reference< css::uno::XAggregation >&
GetAggregationInterface() const {return m_xShapeAgg;}
SvxShape* GetSvxShape();
// helper
diff --git a/sw/source/core/doc/CntntIdxStore.cxx
b/sw/source/core/doc/CntntIdxStore.cxx
index d87e0c2f2374..6b82ebc20cd3 100644
--- a/sw/source/core/doc/CntntIdxStore.cxx
+++ b/sw/source/core/doc/CntntIdxStore.cxx
@@ -127,14 +127,6 @@ namespace
std::vector<PaMEntry> m_aUnoCursorEntries;
std::vector<PaMEntry> m_aShellCursorEntries;
typedef std::function<void (SwPosition& rPos, sal_Int32 nContent)>
updater_t;
- virtual void Clear() override
- {
- m_aBkmkEntries.clear();
- m_aRedlineEntries.clear();
- m_aFlyEntries.clear();
- m_aUnoCursorEntries.clear();
- m_aShellCursorEntries.clear();
- }
virtual bool Empty() override
{
return m_aBkmkEntries.empty() && m_aRedlineEntries.empty() &&
m_aFlyEntries.empty() && m_aUnoCursorEntries.empty() &&
m_aShellCursorEntries.empty();
diff --git a/sw/source/core/inc/mvsave.hxx b/sw/source/core/inc/mvsave.hxx
index 024276b78ccd..718e0e02d2f9 100644
--- a/sw/source/core/inc/mvsave.hxx
+++ b/sw/source/core/inc/mvsave.hxx
@@ -76,8 +76,6 @@ namespace sw::mark
class ContentIdxStore
{
public:
-
- virtual void Clear() =0;
virtual bool Empty() =0;
virtual void Save(SwDoc& rDoc, SwNodeOffset nNode, sal_Int32
nContent, bool bSaveFlySplit=false) =0;
virtual void Restore(SwDoc& rDoc, SwNodeOffset nNode, sal_Int32
nOffset=0, bool bAuto = false, bool bAtStart = false, RestoreMode =
RestoreMode::All) =0;
diff --git a/sw/source/uibase/docvw/AnnotationWin.cxx
b/sw/source/uibase/docvw/AnnotationWin.cxx
index 57c8616f997b..e57f90532294 100644
--- a/sw/source/uibase/docvw/AnnotationWin.cxx
+++ b/sw/source/uibase/docvw/AnnotationWin.cxx
@@ -264,12 +264,6 @@ sal_uInt32 SwAnnotationWin::GetParaId()
return nParaId;
}
-sal_uInt32 SwAnnotationWin::GetPostItId()
-{
- auto pField = static_cast<SwPostItField*>(mpFormatField->GetField());
- return pField->GetPostItId();
-}
-
sal_uInt32 SwAnnotationWin::CreateUniqueParaId()
{
return comphelper::rng::uniform_uint_distribution(0,
std::numeric_limits<sal_uInt32>::max());
diff --git a/vcl/inc/qt5/QtMenu.hxx b/vcl/inc/qt5/QtMenu.hxx
index ffc00d402950..587e1cfea8d1 100644
--- a/vcl/inc/qt5/QtMenu.hxx
+++ b/vcl/inc/qt5/QtMenu.hxx
@@ -80,7 +80,6 @@ public:
virtual void RemoveItem(unsigned nPos) override;
virtual void SetSubMenu(SalMenuItem* pSalMenuItem, SalMenu* pSubMenu,
unsigned nPos) override;
virtual void SetFrame(const SalFrame* pFrame) override;
- const QtFrame* GetFrame() const;
virtual void ShowMenuBar(bool bVisible) override;
virtual bool ShowNativePopupMenu(FloatingWindow* pWin, const
tools::Rectangle& rRect,
FloatWinPopupFlags nFlags) override;
diff --git a/vcl/inc/qt5/QtTools.hxx b/vcl/inc/qt5/QtTools.hxx
index 9a5d0da00ee4..5a0032ccc352 100644
--- a/vcl/inc/qt5/QtTools.hxx
+++ b/vcl/inc/qt5/QtTools.hxx
@@ -57,11 +57,6 @@ inline QRect toQRect(const tools::Rectangle& rRect)
return QRect(rRect.Left(), rRect.Top(), rRect.GetWidth(),
rRect.GetHeight());
}
-inline QRect toQRect(const tools::Rectangle& rRect, const qreal fScale)
-{
- return QRect(floor(rRect.Left() * fScale), floor(rRect.Top() * fScale),
- ceil(rRect.GetWidth() * fScale), ceil(rRect.GetHeight() *
fScale));
-}
inline QRect toQRect(const AbsoluteScreenPixelRectangle& rRect, const qreal
fScale)
{
return QRect(floor(rRect.Left() * fScale), floor(rRect.Top() * fScale),
diff --git a/vcl/qt5/QtMenu.cxx b/vcl/qt5/QtMenu.cxx
index cd42139e713b..e2a0d7bd714c 100644
--- a/vcl/qt5/QtMenu.cxx
+++ b/vcl/qt5/QtMenu.cxx
@@ -621,15 +621,6 @@ void QtMenu::ShowMenuBar(bool bVisible)
lcl_force_menubar_layout_update(*mpQMenuBar);
}
-const QtFrame* QtMenu::GetFrame() const
-{
- SolarMutexGuard aGuard;
- const QtMenu* pMenu = this;
- while (pMenu && !pMenu->mpFrame)
- pMenu = pMenu->mpParentSalMenu;
- return pMenu ? pMenu->mpFrame : nullptr;
-}
-
void QtMenu::slotMenuHovered(QtMenuItem* pItem)
{
const OUString sHelpId =
pItem->mpParentMenu->GetMenu()->GetHelpId(pItem->mnId);
diff --git a/writerperfect/inc/WPXSvInputStream.hxx
b/writerperfect/inc/WPXSvInputStream.hxx
index 45d8e0008861..9370e655fd2f 100644
--- a/writerperfect/inc/WPXSvInputStream.hxx
+++ b/writerperfect/inc/WPXSvInputStream.hxx
@@ -51,7 +51,6 @@ public:
private:
tools::Long tellImpl();
- const unsigned char* readImpl(unsigned long numBytes, unsigned long&
numBytesRead);
int seek(tools::Long offset);
void invalidateReadBuffer();
bool isOLE();
diff --git a/writerperfect/source/common/WPXSvInputStream.cxx
b/writerperfect/source/common/WPXSvInputStream.cxx
index ded992e69c5c..c7bbd12ddb2e 100644
--- a/writerperfect/source/common/WPXSvInputStream.cxx
+++ b/writerperfect/source/common/WPXSvInputStream.cxx
@@ -761,67 +761,6 @@ void WPXSvInputStream::ensureZipIsInitialized()
WPXSvInputStream::~WPXSvInputStream() {}
-#define BUFFER_MAX 65536
-
-const unsigned char* WPXSvInputStream::readImpl(unsigned long numBytes,
unsigned long& numBytesRead)
-{
- numBytesRead = 0;
-
- if (numBytes == 0 || numBytes > std::numeric_limits<unsigned long>::max()
/ 2)
- return nullptr;
-
- if (mpReadBuffer)
- {
- if ((mnReadBufferPos + numBytes > mnReadBufferPos)
- && (mnReadBufferPos + numBytes <= mnReadBufferLength))
- {
- const unsigned char* pTmp = mpReadBuffer + mnReadBufferPos;
- mnReadBufferPos += numBytes;
- numBytesRead = numBytes;
- return pTmp;
- }
-
- invalidateReadBuffer();
- }
-
- unsigned long curpos = static_cast<unsigned long>(tellImpl());
- if (curpos == static_cast<unsigned long>(-1)) // returned ERROR
- return nullptr;
-
- if ((curpos + numBytes < curpos) /*overflow*/
- || (curpos + numBytes >= o3tl::make_unsigned(mnLength))) /*reading
more than available*/
- {
- numBytes = mnLength - curpos;
- }
-
- if (numBytes < BUFFER_MAX)
- {
- if (BUFFER_MAX < mnLength - curpos)
- mnReadBufferLength = BUFFER_MAX;
- else /* BUFFER_MAX >= mnLength - curpos */
- mnReadBufferLength = mnLength - curpos;
- }
- else
- mnReadBufferLength = numBytes;
-
- unsigned long tmpNumBytes(0);
- mpReadBuffer = readImpl(mnReadBufferLength, tmpNumBytes);
- if (tmpNumBytes != mnReadBufferLength)
- mnReadBufferLength = tmpNumBytes;
-
- mnReadBufferPos = 0;
- if (!mnReadBufferLength)
- return nullptr;
-
- if (numBytes <= mnReadBufferLength)
- numBytesRead = numBytes;
- else
- numBytesRead = mnReadBufferLength;
-
- mnReadBufferPos += numBytesRead;
- return mpReadBuffer;
-}
-
long WPXSvInputStream::tell()
{
tools::Long retVal = tellImpl();
diff --git a/xmlsecurity/inc/certificatechooser.hxx
b/xmlsecurity/inc/certificatechooser.hxx
index 4279781f6fa3..12303fbf1cd5 100644
--- a/xmlsecurity/inc/certificatechooser.hxx
+++ b/xmlsecurity/inc/certificatechooser.hxx
@@ -83,7 +83,6 @@ private:
void ImplShowCertificateDetails();
void ImplInitialize(bool mbSearch = false);
void ImplReloadCertificates();
- void ImplSecCtxToCerts(SvtUserOptions &aUserOpts, bool bOnlyReload);
static void HandleOneUsageBit(OUString& string, int& bits, int bit,
TranslateId name);
public:
