[Libreoffice-commits] core.git: svx/source

[Caolán McNamara (via logerrit)]

 svx/source/theme/ThemeColorChangerCommon.cxx |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 60880c9a7634468a852d4b0bf2d7a69d41ac7d11
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Thu Aug 31 09:03:31 2023 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Thu Aug 31 15:23:18 2023 +0200

    cid#1542447 Explicit null dereferenced
    
    Change-Id: I1de10a8a459175f79bb2b8f796cde287be1945c9
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156326
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/svx/source/theme/ThemeColorChangerCommon.cxx 
b/svx/source/theme/ThemeColorChangerCommon.cxx
index 5629036f9a68..44f041f5f3b0 100644
--- a/svx/source/theme/ThemeColorChangerCommon.cxx
+++ b/svx/source/theme/ThemeColorChangerCommon.cxx
@@ -48,16 +48,16 @@ const SvxColorItem* getColorItem(const editeng::Section& 
rSection)
     return nullptr;
 }
 
-bool updateEditEngTextSections(model::ColorSet const& rColorSet, SdrObject* 
pObject, SdrView* pView)
+bool updateEditEngTextSections(model::ColorSet const& rColorSet, SdrObject* 
pObject, SdrView& rView)
 {
     SdrTextObj* pTextObject = DynCastSdrTextObj(pObject);
 
     if (!pTextObject)
         return false;
 
-    pView->SdrBeginTextEdit(pTextObject);
+    rView.SdrBeginTextEdit(pTextObject);
 
-    auto* pOutlinerView = pView->GetTextEditOutlinerView();
+    auto* pOutlinerView = rView.GetTextEditOutlinerView();
     if (!pOutlinerView)
         return false;
 
@@ -96,7 +96,7 @@ bool updateEditEngTextSections(model::ColorSet const& 
rColorSet, SdrObject* pObj
         }
     }
 
-    pView->SdrEndTextEdit();
+    rView.SdrEndTextEdit();
 
     return true;
 }
@@ -165,7 +165,8 @@ void updateSdrObject(model::ColorSet const& rColorSet, 
SdrObject* pObject, SdrVi
     if (!pObject)
         return;
 
-    updateEditEngTextSections(rColorSet, pObject, pView);
+    if (pView)
+        updateEditEngTextSections(rColorSet, pObject, *pView);
     updateObjectAttributes(rColorSet, *pObject, pUndoManager);
 }