vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bb2bd14b941ea0a8463264dcf8902ae67302b386
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Fri Aug 25 08:04:07 2023 +0200
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Fri Aug 25 09:50:11 2023 +0200
This copy ctor should probably take its arg by const ref
It was introduced in 3426dcfec2b4d5c755024c355f323ecc9f656e4a "vcl gtk3:
Introduce AT-SPI2 tests for the GTK3 accessibility layer", and caused at
least a
build with recent GCC 14 trunk to failed with
> In file included from vcl/qa/cppunit/a11y/atspi2/atspiwrapper.cxx:10:
> vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx: In member function
‘Atspi::Accessible::iterator Atspi::Accessible::iterator::operator++(int)’:
> vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:524:20: error: cannot bind
non-const lvalue reference of type ‘Atspi::Accessible::iterator&’ to an rvalue
of type ‘Atspi::Accessible::iterator’
> 524 | return other;
> | ^~~~~
> vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:508:28: note: initializing
argument 1 of
‘Atspi::Accessible::iterator::iterator(Atspi::Accessible::iterator&)’
> 508 | iterator(iterator& other)
> | ~~~~~~~~~~^~~~~
Change-Id: Ia9a1e3f58d67db1fc9851fe8a844f2076ff740c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156075
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx
b/vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx
index 91ddd9dac217..635f9b76d407 100644
--- a/vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx
+++ b/vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx
@@ -505,7 +505,7 @@ public:
{
}
- iterator(iterator& other)
+ iterator(iterator const& other)
: m_pAccessible(other.m_pAccessible)
, m_idx(other.m_idx)
{
