sfx2/source/dialog/infobar.cxx | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit e7ff004892c950a863602e9380aef91a7ae2404d
Author: Patrick Luby <plub...@neooffice.org>
AuthorDate: Mon Jul 24 12:27:51 2023 -0400
Commit: Patrick Luby <plub...@neooffice.org>
CommitDate: Mon Jul 24 21:14:14 2023 +0200
Regression: eliminate white lines in infobar's close button
When drawing the close button's background, the right and bottom need to be
extended by 1 or there will be a white line on both edges.
Change-Id: I67dcad422c0f33af3035621cd624c1ddafc89d00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154871
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plub...@neooffice.org>
diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx
index 5bcb8b7e9a69..81e8ffe9d864 100644
--- a/sfx2/source/dialog/infobar.cxx
+++ b/sfx2/source/dialog/infobar.cxx
@@ -114,12 +114,13 @@ void SfxInfoBarWindow::SetCloseButtonImage()
drawinglayer::primitive2d::Primitive2DContainer aSeq(2);
- // background
+ // Draw backround. The right and bottom need to be extended by 1 or
+ // there will be a white line on both edges when Skia is enabled.
B2DPolygon aPolygon;
aPolygon.append(B2DPoint(aRect.Left(), aRect.Top()));
- aPolygon.append(B2DPoint(aRect.Right(), aRect.Top()));
- aPolygon.append(B2DPoint(aRect.Right(), aRect.Bottom()));
- aPolygon.append(B2DPoint(aRect.Left(), aRect.Bottom()));
+ aPolygon.append(B2DPoint(aRect.Right() + 1, aRect.Top()));
+ aPolygon.append(B2DPoint(aRect.Right() + 1, aRect.Bottom() + 1));
+ aPolygon.append(B2DPoint(aRect.Left(), aRect.Bottom() + 1));
aPolygon.setClosed(true);
aSeq[0] = new PolyPolygonColorPrimitive2D(B2DPolyPolygon(aPolygon),
m_aBackgroundColor);
