vcl/jsdialog/enabled.cxx | 1 +
vcl/jsdialog/jsdialogbuilder.cxx | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 3e10169b0508d46ffea2e72f11608a19038b8016
Author: Szymon Kłos <szymon.k...@collabora.com>
AuthorDate: Wed May 31 11:16:36 2023 +0200
Commit: Szymon Kłos <szymon.k...@collabora.com>
CommitDate: Tue Jul 4 20:47:23 2023 +0200
jsdialog: enable sparkline dialog
Change-Id: Iaf5de5c1c15313075afdf8dbc48dcb22da448fea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152417
Tested-by: Szymon Kłos <szymon.k...@collabora.com>
Reviewed-by: Szymon Kłos <szymon.k...@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153949
Tested-by: Jenkins
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index 36707140b927..171294bf5372 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -130,6 +130,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool
bMobile)
|| rUIFile == u"modules/scalc/ui/sortdialog.ui"
|| rUIFile == u"modules/scalc/ui/sortkey.ui"
|| rUIFile == u"modules/scalc/ui/sortoptionspage.ui"
+ || rUIFile == u"modules/scalc/ui/sparklinedialog.ui"
|| rUIFile == u"modules/scalc/ui/standardfilterdialog.ui"
|| rUIFile == u"modules/scalc/ui/textimportcsv.ui"
|| rUIFile == u"modules/scalc/ui/ttestdialog.ui"
commit d077c6bf7b1697abc977a8bea5b19cb624c4a5b1
Author: Szymon Kłos <szymon.k...@collabora.com>
AuthorDate: Fri May 19 13:45:22 2023 +0200
Commit: Szymon Kłos <szymon.k...@collabora.com>
CommitDate: Tue Jul 4 20:47:15 2023 +0200
jsdialog: lazy json generation when closing tab in dialog
After profiling Writer -> Format -> Character dialog
I found that full dialog update happens while creating
the dialog as some of the tabs are destroyed.
Instead of instant JSON generation we should
add the message to the queue and send it in idle time.
Problem is that we are closing the tab and it's builder
so we will not be able to do it later.
So using jsdialog::SendFullUpdate trigger update in parent
dialog which shares the same WINDOW_ID.
This behaviour can be tested in Highlight tab when switching
between "Color" and "None". As previous solution was introduced
for it in:
commit 41a1a2f04301dc22b156b4e11767859e40473897
jsdialog: don't close dialog on tab page destroy
Change-Id: I916250cf08d87c1109dc2db6dbbc1fbff7f48c07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152008
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
Reviewed-by: Szymon Kłos <szymon.k...@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153945
Tested-by: Szymon Kłos <szymon.k...@collabora.com>
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index 328a03340c97..d37c5c2ffb59 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -677,8 +677,7 @@ JSInstanceBuilder::~JSInstanceBuilder()
// tab page closed -> refresh parent window
if (m_bIsNestedBuilder && m_sTypeOfJSON == "dialog")
{
- sendFullUpdate(true);
- flush();
+ jsdialog::SendFullUpdate(OUString::number(m_nWindowId), "__DIALOG__");
}
if (m_sTypeOfJSON == "popup")
