sc/uiconfig/scalc/ui/notebookbar.ui | 2 +-
sc/uiconfig/scalc/ui/notebookbar_compact.ui | 2 +-
sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui | 2 +-
sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui | 2 +-
sw/uiconfig/swriter/ui/notebookbar.ui | 2 +-
sw/uiconfig/swriter/ui/notebookbar_compact.ui | 2 +-
sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui | 2 +-
sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 506db23af4da2c5c8775fb0fd6fb9b8668e2fe86
Author: Justin Luth <jl...@mail.com>
AuthorDate: Fri Jun 16 16:52:58 2023 -0400
Commit: Justin Luth <jl...@mail.com>
CommitDate: Sat Jun 17 01:15:36 2023 +0200
tdf#118335 notebookbar: set visible false for PrintPreview in MenuFile
The label for "Print Preview" comes from ContextLabel in
these menus - and it displays "Close Preview" even if
the print preview is not active.
The PrintPreview buttons in the notebookbar ribbon itself work fine.
So just hide the menu ones for now.
Perhaps that is not good for accessibility,
but I would imagine accessibility people would
stick with the traditional menu anyway,
since the notebookbar is also horrendous
in many other ways for accessiblity.
The user can turn this back on again if they want.
Customize - Notebookbar - File Tab | File | Menu File
Change-Id: I807941650295132c9e15f04094cece26246318d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153199
Tested-by: Jenkins
Reviewed-by: Justin Luth <jl...@mail.com>
diff --git a/sc/uiconfig/scalc/ui/notebookbar.ui
b/sc/uiconfig/scalc/ui/notebookbar.ui
index fc1e1cb91b75..0adc829feab4 100644
--- a/sc/uiconfig/scalc/ui/notebookbar.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar.ui
@@ -499,7 +499,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
index b95915468420..8991949ac917 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
@@ -739,7 +739,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
index 4b8a5dfe8309..dc0bb54cdc2f 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
@@ -745,7 +745,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
index fe46648df3b1..9520227fb4be 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
@@ -1323,7 +1323,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
diff --git a/sw/uiconfig/swriter/ui/notebookbar.ui
b/sw/uiconfig/swriter/ui/notebookbar.ui
index 8d17c21344fd..e10063f8750e 100644
--- a/sw/uiconfig/swriter/ui/notebookbar.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar.ui
@@ -246,7 +246,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
diff --git a/sw/uiconfig/swriter/ui/notebookbar_compact.ui
b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
index 109e33e5ea40..6fb6f4017763 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_compact.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
@@ -376,7 +376,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
diff --git a/sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui
b/sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui
index e531107b21f6..30731e6f572b 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui
@@ -1042,7 +1042,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
diff --git a/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui
b/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui
index 3c682f99830b..1c1060b0ba4b 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui
@@ -1032,7 +1032,7 @@
</child>
<child>
<object class="GtkMenuItem" id="MenuFile-PrintPreview">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="action_name">.uno:PrintPreview</property>
</object>
