[Libreoffice-commits] core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/uibase/misc/redlndlg.cxx |    5 -----
 1 file changed, 5 deletions(-)

New commits:
commit 76d5bf35a618dc8f7f268ec5cd40e546a4d48e17
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Tue Jun 13 17:22:18 2023 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Tue Jun 13 21:02:10 2023 +0200

    cid#1532367 Unused value
    
    Within the loop nPrevRowChange is not read after it is set
    and nPrevRowChange is always set to nRowChange at the end of
    the loop. There is no continue within the loop, so it looks
    like there is no point changing nPrevRowChange as it will be
    overwritten with nRowChange in any case.
    
    probably this is the case since:
    
    commit cc52d895314dd7b67de916bd90ccbfa098e77419
    Date:   Wed Jun 7 16:53:42 2023 +0200
    
        tdf#155342 sw tracked table column: manage changes
    
    Change-Id: Ib7cf2da23a7553bdeea13862cf4f67248bc829a7
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152994
    Tested-by: Jenkins
    Tested-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sw/source/uibase/misc/redlndlg.cxx 
b/sw/source/uibase/misc/redlndlg.cxx
index e583dc3af1a9..3a0a67fa005d 100644
--- a/sw/source/uibase/misc/redlndlg.cxx
+++ b/sw/source/uibase/misc/redlndlg.cxx
@@ -871,7 +871,6 @@ void 
SwRedlineAcceptDlg::InsertParents(SwRedlineTable::size_type nStart, SwRedli
                     {
                         nNewTableParent = i;
                         nLastChangeInRow = i;
-                        nPrevRowChange = nRowChange;
                     }
                 }
                 else
@@ -884,12 +883,8 @@ void 
SwRedlineAcceptDlg::InsertParents(SwRedlineTable::size_type nStart, SwRedli
             {
                 // redline is not in a tracked table change
                 bChange = bRowChange = false;
-                nPrevRowChange = SwRedlineTable::npos;
             }
         }
-        else
-            // redline is not in a tracked table change
-            nPrevRowChange = SwRedlineTable::npos;
 
         bool bShowDeletedTextAsComment = bIsShowChangesInMargin &&
                 RedlineType::Delete == rRedln.GetType() && 
rRedln.GetComment().isEmpty();