comphelper/source/misc/diagnose_ex.cxx |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit 71ea95ba55ba9e52318423041c4804771818e01f
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Tue May 9 15:47:13 2023 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed May 10 08:02:07 2023 +0200

    re-enable typeid checking in exceptionToStringImpl
    
    now that we have valid RTTI tables for the UNO proxy objects generated
    by the bridge code. (We won't get a useful typeid for them, but for all
    other objects, we will, so this is still worth doing)
    
    Change-Id: I32bfa0099a242021f353fc4065e8660eb6c7cd93
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151585
    Tested-by: Noel Grandin <noel.gran...@collabora.co.uk>
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/comphelper/source/misc/diagnose_ex.cxx 
b/comphelper/source/misc/diagnose_ex.cxx
index 020aa69ca241..e805c5b4c2a5 100644
--- a/comphelper/source/misc/diagnose_ex.cxx
+++ b/comphelper/source/misc/diagnose_ex.cxx
@@ -71,7 +71,6 @@ static void exceptionToStringImpl(OStringBuffer& sMessage, 
const css::uno::Any &
         sMessage.append(toOString(exception.Message));
         sMessage.append("\"");
     }
-/*  TODO FIXME (see https://gerrit.libreoffice.org/#/c/83245/)
     if ( exception.Context.is() )
     {
         const char* pContext = typeid( *exception.Context ).name();
@@ -86,7 +85,6 @@ static void exceptionToStringImpl(OStringBuffer& sMessage, 
const css::uno::Any &
         std::free(const_cast<char *>(pContext));
 #endif
     }
-*/
     {
         css::configuration::CorruptedConfigurationException specialized;
         if ( caught >>= specialized )

Reply via email to