The browselabel seems to be a (dynamic) label for the GtkEntry browseurl, and should provide a mnemonic. An example for the dynamic part might be the sortkey.ui.
On 27.04.23 06:19, Lionel Élie Mamane wrote:
Hi, I'm reviewing https://gerrit.libreoffice.org/150546 by Nirnay. It adds a .ui file, and a "make" outputs warning like WARNING: 'GtkLabel' 'browselabel' does not specify what it labels within 'GtkFrame' 'frame1' The other preexisting .ui files also generate a bunch of them, but they are silenced in a .suppr file... What is our policy on this? Should/can Nirnay just silence them, too, by adding them to the .suppr file? I guess not. Please tell Nirnay what he should do in respect of this; I'd rather not commit as is with the warning (nor simply suppressing them) unless a UI/accessibility knowledgeable persons signs off on it (the rest of the change is nearly ready to merge, and should be completely ready within an hour so.) Thanks in advance, Lionel
-- Dr. Heiko Tietze, UX-Designer and UX-Mentor Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: https://www.documentfoundation.org/imprint
OpenPGP_signature
Description: OpenPGP digital signature
