On Mon, 24 Apr 2023 at 13:33, Julien Nabet <serval2...@yahoo.fr> wrote:
> Hello, > > I noticed in include/svx/xdef.hxx that the numbering was wrong from > XATTRSET_LINE (line 105) > > 103 constexpr TypedWhichId<XLineCapItem> XATTR_LINECAP > (XATTR_LINE_FIRST + 12); /* V3: 1012 */ > 104 constexpr sal_uInt16 XATTR_LINE_LAST (XATTR_LINECAP); > 105 constexpr TypedWhichId<XLineAttrSetItem> XATTRSET_LINE > (XATTR_LINE_LAST + 1); /* V3: 1017 V2: 1017 */ > > The actualy numbering is fine, although the comments are wrong. > > 2) Are "V2" "V3" numbers in comments useful or can we remove them to > just keep the last real number ? > > The comments are no longer of any use and can be remove (IMO). > Remark: ideally, I'd like being able to do this in gdb: > > > (gdb) p SDRATTR_TABLE_FIRST > No symbol "SDRATTR_TABLE_FIRST" in current context. > > > no idea why that doesn't work, maybe the linker is stripping unused symbols.
