[Libreoffice-commits] core.git: include/vcl

[Mike Kaganski (via logerrit)]

 include/vcl/vclptr.hxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 60022965ce3791e578468b366baf33c64338a388
Author:     Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Mon Apr 17 18:40:24 2023 +0300
Commit:     Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Mon Apr 17 20:36:09 2023 +0200

    Use move ctor here
    
    Change-Id: Ic20b91ee6d674c7fe5f08f07c3f29fc9fbaf5282
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150524
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>

diff --git a/include/vcl/vclptr.hxx b/include/vcl/vclptr.hxx
index 3775034ff0c6..326881edd105 100644
--- a/include/vcl/vclptr.hxx
+++ b/include/vcl/vclptr.hxx
@@ -200,8 +200,8 @@ public:
     void disposeAndClear()
     {
         // hold it alive for the lifetime of this method
-        ::rtl::Reference<reference_type> aTmp(m_rInnerRef);
-        m_rInnerRef.clear(); // we should use some 'swap' method ideally ;-)
+        ::rtl::Reference<reference_type> aTmp(std::move(m_rInnerRef));
+        assert(!m_rInnerRef); // the move ctor above must take care of it
         if (aTmp.get()) {
             aTmp->disposeOnce();
         }