sal/osl/w32/backtrace.cxx | 7 ++----- sal/osl/w32/procimpl.cxx | 3 +-- 2 files changed, 3 insertions(+), 7 deletions(-)
New commits: commit a0c08ce6cf5e0cd88238fefb3b819305daf4005e Author: Stephan Bergmann <sberg...@redhat.com> AuthorDate: Mon Apr 17 09:20:53 2023 +0200 Commit: Stephan Bergmann <sberg...@redhat.com> CommitDate: Mon Apr 17 17:16:29 2023 +0200 loplugin:stringadd Change-Id: I674655aa4bfe38675dd3c9d677a7d7c64b3eaac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150478 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sberg...@redhat.com> diff --git a/sal/osl/w32/backtrace.cxx b/sal/osl/w32/backtrace.cxx index d9231de44517..8d55c6485a12 100644 --- a/sal/osl/w32/backtrace.cxx +++ b/sal/osl/w32/backtrace.cxx @@ -75,12 +75,9 @@ OUString sal::backtrace_to_string(BacktraceState* backtraceState) for( int i = 0; i < nFrames; i++ ) { SymFromAddr( hProcess, reinterpret_cast<DWORD64>(backtraceState->buffer[ i ]), nullptr, pSymbol ); - aBuf.append( static_cast<sal_Int32>(nFrames - i - 1) ); - aBuf.append( ": " ); + aBuf.append( OUString::number(nFrames - i - 1) + ": " ); aBuf.appendAscii( pSymbol->Name ); - aBuf.append( " - 0x" ); - aBuf.append( static_cast<sal_Int64>(pSymbol->Address), 16 ); - aBuf.append( "\n" ); + aBuf.append( " - 0x" + OUString::number(pSymbol->Address, 16) + "\n" ); } free( pSymbol ); diff --git a/sal/osl/w32/procimpl.cxx b/sal/osl/w32/procimpl.cxx index 5fb9a46348b2..1689d6ac6be9 100644 --- a/sal/osl/w32/procimpl.cxx +++ b/sal/osl/w32/procimpl.cxx @@ -422,8 +422,7 @@ oslProcessError SAL_CALL osl_executeProcess_WithRedirectedIO( if (!(Options & osl_Process_WAIT) || (Options & osl_Process_DETACHED)) flags |= CREATE_NEW_CONSOLE; - command_line.append(batch_processor); - command_line.append(" /c "); + command_line.append(batch_processor + " /c "); } else // should we return here in case of error?